From: miaoqinglang <miaoqinglang@huawei.com> To: Daniel Vetter <daniel@ffwll.ch>, "james qian wang (Arm Technology China)" <james.qian.wang@arm.com> Cc: Mihail Atanassov <mihail.atanassov@arm.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Liviu Dudau <liviu.dudau@arm.com>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, nd <nd@arm.com> Subject: Re: [PATCH -next] drm/komeda: Convert to DEFINE_SHOW_ATTRIBUTE Date: Fri, 17 Jul 2020 16:00:36 +0800 [thread overview] Message-ID: <7264de7e-6da4-288d-855d-410b2e05458b@huawei.com> (raw) In-Reply-To: <CAKMK7uEpmhKok9Q3Rrg0v=1p7pv-wpV0Y3-k9GVav+Ad5Z4AkQ@mail.gmail.com> 在 2020/7/17 15:06, Daniel Vetter 写道: > On Fri, Jul 17, 2020 at 8:40 AM james qian wang (Arm Technology China) > <james.qian.wang@arm.com> wrote: >> >> On Thu, Jul 16, 2020 at 05:03:33PM +0800, Qinglang Miao wrote: >>> From: Liu Shixin <liushixin2@huawei.com> >>> >>> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. >>> >>> Signed-off-by: Liu Shixin <liushixin2@huawei.com> >>> --- >>> drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 13 +------------ >>> 1 file changed, 1 insertion(+), 12 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c >>> index 0246b2e94..4a10e6b9e 100644 >>> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c >>> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c >>> @@ -41,18 +41,7 @@ static int komeda_register_show(struct seq_file *sf, void *x) >>> return 0; >>> } >>> >>> -static int komeda_register_open(struct inode *inode, struct file *filp) >>> -{ >>> - return single_open(filp, komeda_register_show, inode->i_private); >>> -} >>> - >>> -static const struct file_operations komeda_register_fops = { >>> - .owner = THIS_MODULE, >>> - .open = komeda_register_open, >>> - .read_iter = seq_read_iter, >>> - .llseek = seq_lseek, >>> - .release = single_release, >>> -}; >>> +DEFINE_SHOW_ATTRIBUTE(komeda_register); >>> >> >> Hi Shixin & Qinglang >> >> Thanks for your patch. >> >> Reviewed-by: James Qian Wang <james.qian.wang@arm.com> >> >> Since your patch is not for drm-misc-next, so seems better >> to leave it to you to merge it. :) > > I do think it's for drm-misc-next, what other tree would it be for? > Some people put -next in their patch tag to differentiate from -fixes, > so maintainers know what to do with the patch. It's also not part of a > series, hence I think this is on you to apply it. > Hi James & Daniel, Sorry I didn't make it clear in commit log, but it do based on linux-next. I think the reason why James think it's not for drm-misc-next is conflicts exists when this patch being applied. There's conflicts because commit <4d4901c6d7> which switched over direct seq_read method calls to seq_read_iter should applied before this clean-up patch(linkage listed as below). https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next/+/4d4901c6d748efab8aab6e7d2405dadaed0bea50 I can send a new patch based on mainline if needed. Thanks. Qinglang . > > Cheers, Daniel > >> >> Thanks >> James >> >>> #ifdef CONFIG_DEBUG_FS >>> static void komeda_debugfs_init(struct komeda_dev *mdev) >>> -- >>> 2.17.1 >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > > >
WARNING: multiple messages have this Message-ID (diff)
From: miaoqinglang <miaoqinglang@huawei.com> To: Daniel Vetter <daniel@ffwll.ch>, "james qian wang (Arm Technology China)" <james.qian.wang@arm.com> Cc: Mihail Atanassov <mihail.atanassov@arm.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Liviu Dudau <liviu.dudau@arm.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, nd <nd@arm.com> Subject: Re: [PATCH -next] drm/komeda: Convert to DEFINE_SHOW_ATTRIBUTE Date: Fri, 17 Jul 2020 16:00:36 +0800 [thread overview] Message-ID: <7264de7e-6da4-288d-855d-410b2e05458b@huawei.com> (raw) In-Reply-To: <CAKMK7uEpmhKok9Q3Rrg0v=1p7pv-wpV0Y3-k9GVav+Ad5Z4AkQ@mail.gmail.com> 在 2020/7/17 15:06, Daniel Vetter 写道: > On Fri, Jul 17, 2020 at 8:40 AM james qian wang (Arm Technology China) > <james.qian.wang@arm.com> wrote: >> >> On Thu, Jul 16, 2020 at 05:03:33PM +0800, Qinglang Miao wrote: >>> From: Liu Shixin <liushixin2@huawei.com> >>> >>> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. >>> >>> Signed-off-by: Liu Shixin <liushixin2@huawei.com> >>> --- >>> drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 13 +------------ >>> 1 file changed, 1 insertion(+), 12 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c >>> index 0246b2e94..4a10e6b9e 100644 >>> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c >>> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c >>> @@ -41,18 +41,7 @@ static int komeda_register_show(struct seq_file *sf, void *x) >>> return 0; >>> } >>> >>> -static int komeda_register_open(struct inode *inode, struct file *filp) >>> -{ >>> - return single_open(filp, komeda_register_show, inode->i_private); >>> -} >>> - >>> -static const struct file_operations komeda_register_fops = { >>> - .owner = THIS_MODULE, >>> - .open = komeda_register_open, >>> - .read_iter = seq_read_iter, >>> - .llseek = seq_lseek, >>> - .release = single_release, >>> -}; >>> +DEFINE_SHOW_ATTRIBUTE(komeda_register); >>> >> >> Hi Shixin & Qinglang >> >> Thanks for your patch. >> >> Reviewed-by: James Qian Wang <james.qian.wang@arm.com> >> >> Since your patch is not for drm-misc-next, so seems better >> to leave it to you to merge it. :) > > I do think it's for drm-misc-next, what other tree would it be for? > Some people put -next in their patch tag to differentiate from -fixes, > so maintainers know what to do with the patch. It's also not part of a > series, hence I think this is on you to apply it. > Hi James & Daniel, Sorry I didn't make it clear in commit log, but it do based on linux-next. I think the reason why James think it's not for drm-misc-next is conflicts exists when this patch being applied. There's conflicts because commit <4d4901c6d7> which switched over direct seq_read method calls to seq_read_iter should applied before this clean-up patch(linkage listed as below). https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next/+/4d4901c6d748efab8aab6e7d2405dadaed0bea50 I can send a new patch based on mainline if needed. Thanks. Qinglang . > > Cheers, Daniel > >> >> Thanks >> James >> >>> #ifdef CONFIG_DEBUG_FS >>> static void komeda_debugfs_init(struct komeda_dev *mdev) >>> -- >>> 2.17.1 >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-07-17 8:00 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-16 9:03 [PATCH -next] drm/komeda: Convert to DEFINE_SHOW_ATTRIBUTE Qinglang Miao 2020-07-16 9:03 ` Qinglang Miao 2020-07-17 6:40 ` james qian wang (Arm Technology China) 2020-07-17 6:40 ` james qian wang (Arm Technology China) 2020-07-17 7:06 ` Daniel Vetter 2020-07-17 7:06 ` Daniel Vetter 2020-07-17 7:59 ` james qian wang (Arm Technology China) 2020-07-17 7:59 ` james qian wang (Arm Technology China) 2020-07-17 8:00 ` miaoqinglang [this message] 2020-07-17 8:00 ` miaoqinglang 2020-07-17 9:10 ` Daniel Vetter 2020-07-17 9:10 ` Daniel Vetter 2020-09-17 12:36 ` miaoqinglang 2020-09-17 12:36 ` miaoqinglang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7264de7e-6da4-288d-855d-410b2e05458b@huawei.com \ --to=miaoqinglang@huawei.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=gregkh@linuxfoundation.org \ --cc=james.qian.wang@arm.com \ --cc=linux-kernel@vger.kernel.org \ --cc=liviu.dudau@arm.com \ --cc=mihail.atanassov@arm.com \ --cc=nd@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.