* [PATCH 1/4] dt-bindings: mailbox: Add compatible for the MSM8976
2022-03-05 16:49 [PATCH 0/4] *** Add SCM and mailbox support on MSM8976 *** Adam Skladowski
@ 2022-03-05 16:49 ` Adam Skladowski
2022-03-05 21:11 ` Krzysztof Kozlowski
2022-03-05 16:49 ` [PATCH 2/4] mailbox: qcom-apcs-ipc: Add compatible for MSM8976 SoC Adam Skladowski
` (3 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Adam Skladowski @ 2022-03-05 16:49 UTC (permalink / raw)
To: phone-devel
Cc: ~postmarketos/upstreaming, Adam Skladowski, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Jassi Brar,
linux-arm-msm, devicetree, linux-kernel
Add the mailbox compatible for the MSM8976 SoC.
Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
---
.../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
index 01e9d9155c836..3b5ba7ecc19d9 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
@@ -21,6 +21,7 @@ properties:
- qcom,msm8916-apcs-kpss-global
- qcom,msm8939-apcs-kpss-global
- qcom,msm8953-apcs-kpss-global
+ - qcom,msm8976-apcs-kpss-global
- qcom,msm8994-apcs-kpss-global
- qcom,msm8996-apcs-hmss-global
- qcom,msm8998-apcs-hmss-global
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/4] dt-bindings: mailbox: Add compatible for the MSM8976
2022-03-05 16:49 ` [PATCH 1/4] dt-bindings: mailbox: Add compatible for the MSM8976 Adam Skladowski
@ 2022-03-05 21:11 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-05 21:11 UTC (permalink / raw)
To: Adam Skladowski, phone-devel
Cc: ~postmarketos/upstreaming, Andy Gross, Bjorn Andersson,
Rob Herring, Jassi Brar, linux-arm-msm, devicetree, linux-kernel
On 05/03/2022 17:49, Adam Skladowski wrote:
> Add the mailbox compatible for the MSM8976 SoC.
Missing empty line. With this fixed:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
P.S. Please avoid some unusual formatting/bold in commit title (*** of
cover letter). The subject should be informative and simple.
> Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
> ---
> .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> index 01e9d9155c836..3b5ba7ecc19d9 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> @@ -21,6 +21,7 @@ properties:
> - qcom,msm8916-apcs-kpss-global
> - qcom,msm8939-apcs-kpss-global
> - qcom,msm8953-apcs-kpss-global
> + - qcom,msm8976-apcs-kpss-global
> - qcom,msm8994-apcs-kpss-global
> - qcom,msm8996-apcs-hmss-global
> - qcom,msm8998-apcs-hmss-global
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/4] mailbox: qcom-apcs-ipc: Add compatible for MSM8976 SoC
2022-03-05 16:49 [PATCH 0/4] *** Add SCM and mailbox support on MSM8976 *** Adam Skladowski
2022-03-05 16:49 ` [PATCH 1/4] dt-bindings: mailbox: Add compatible for the MSM8976 Adam Skladowski
@ 2022-03-05 16:49 ` Adam Skladowski
2022-03-05 16:49 ` [PATCH 3/4] dt-bindings: firmware: qcom-scm: Document msm8976 bindings Adam Skladowski
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Adam Skladowski @ 2022-03-05 16:49 UTC (permalink / raw)
To: phone-devel
Cc: ~postmarketos/upstreaming, Adam Skladowski, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Jassi Brar,
linux-arm-msm, devicetree, linux-kernel
MSM8976 APCS block is similar to one found in MSM8994.
Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
---
drivers/mailbox/qcom-apcs-ipc-mailbox.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
index 9325d2abc745b..80a54d81412e3 100644
--- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
+++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
@@ -146,6 +146,7 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] = {
{ .compatible = "qcom,msm8916-apcs-kpss-global", .data = &msm8916_apcs_data },
{ .compatible = "qcom,msm8939-apcs-kpss-global", .data = &msm8916_apcs_data },
{ .compatible = "qcom,msm8953-apcs-kpss-global", .data = &msm8994_apcs_data },
+ { .compatible = "qcom,msm8976-apcs-kpss-global", .data = &msm8994_apcs_data },
{ .compatible = "qcom,msm8994-apcs-kpss-global", .data = &msm8994_apcs_data },
{ .compatible = "qcom,msm8996-apcs-hmss-global", .data = &msm8996_apcs_data },
{ .compatible = "qcom,msm8998-apcs-hmss-global", .data = &msm8994_apcs_data },
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 3/4] dt-bindings: firmware: qcom-scm: Document msm8976 bindings
2022-03-05 16:49 [PATCH 0/4] *** Add SCM and mailbox support on MSM8976 *** Adam Skladowski
2022-03-05 16:49 ` [PATCH 1/4] dt-bindings: mailbox: Add compatible for the MSM8976 Adam Skladowski
2022-03-05 16:49 ` [PATCH 2/4] mailbox: qcom-apcs-ipc: Add compatible for MSM8976 SoC Adam Skladowski
@ 2022-03-05 16:49 ` Adam Skladowski
2022-03-05 21:12 ` Krzysztof Kozlowski
2022-03-05 16:49 ` [PATCH 4/4] firmware: qcom_scm: Add compatible for MSM8976 SoC Adam Skladowski
2022-04-13 14:30 ` [PATCH 0/4] *** Add SCM and mailbox support on MSM8976 *** patchwork-bot+linux-arm-msm
4 siblings, 1 reply; 8+ messages in thread
From: Adam Skladowski @ 2022-03-05 16:49 UTC (permalink / raw)
To: phone-devel
Cc: ~postmarketos/upstreaming, Adam Skladowski, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Jassi Brar,
linux-arm-msm, devicetree, linux-kernel
SCM driver on MSM8976 requires 3 clocks.
Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
---
Documentation/devicetree/bindings/firmware/qcom,scm.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
index b1cd4ad1889ae..0f4e5ab264779 100644
--- a/Documentation/devicetree/bindings/firmware/qcom,scm.txt
+++ b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
@@ -19,6 +19,7 @@ Required properties:
* "qcom,scm-msm8953"
* "qcom,scm-msm8960"
* "qcom,scm-msm8974"
+ * "qcom,scm-msm8976"
* "qcom,scm-msm8994"
* "qcom,scm-msm8996"
* "qcom,scm-msm8998"
@@ -37,7 +38,7 @@ Required properties:
* core clock required for "qcom,scm-apq8064", "qcom,scm-msm8660" and
"qcom,scm-msm8960"
* core, iface and bus clocks required for "qcom,scm-apq8084",
- "qcom,scm-msm8916", "qcom,scm-msm8953" and "qcom,scm-msm8974"
+ "qcom,scm-msm8916", "qcom,scm-msm8953", "qcom,scm-msm8974" and "qcom,scm-msm8976"
- clock-names: Must contain "core" for the core clock, "iface" for the interface
clock and "bus" for the bus clock per the requirements of the compatible.
- qcom,dload-mode: phandle to the TCSR hardware block and offset of the
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 3/4] dt-bindings: firmware: qcom-scm: Document msm8976 bindings
2022-03-05 16:49 ` [PATCH 3/4] dt-bindings: firmware: qcom-scm: Document msm8976 bindings Adam Skladowski
@ 2022-03-05 21:12 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-05 21:12 UTC (permalink / raw)
To: Adam Skladowski, phone-devel
Cc: ~postmarketos/upstreaming, Andy Gross, Bjorn Andersson,
Rob Herring, Jassi Brar, linux-arm-msm, devicetree, linux-kernel
On 05/03/2022 17:49, Adam Skladowski wrote:
> SCM driver on MSM8976 requires 3 clocks.
> Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
> ---
> Documentation/devicetree/bindings/firmware/qcom,scm.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Same as in other patches - missing blank line before SoB.
With that fixed:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 4/4] firmware: qcom_scm: Add compatible for MSM8976 SoC
2022-03-05 16:49 [PATCH 0/4] *** Add SCM and mailbox support on MSM8976 *** Adam Skladowski
` (2 preceding siblings ...)
2022-03-05 16:49 ` [PATCH 3/4] dt-bindings: firmware: qcom-scm: Document msm8976 bindings Adam Skladowski
@ 2022-03-05 16:49 ` Adam Skladowski
2022-04-13 14:30 ` [PATCH 0/4] *** Add SCM and mailbox support on MSM8976 *** patchwork-bot+linux-arm-msm
4 siblings, 0 replies; 8+ messages in thread
From: Adam Skladowski @ 2022-03-05 16:49 UTC (permalink / raw)
To: phone-devel
Cc: ~postmarketos/upstreaming, Adam Skladowski, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Jassi Brar,
linux-arm-msm, devicetree, linux-kernel
Add compatible for SCM on MSM8976.
Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
---
drivers/firmware/qcom_scm.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
index 491bbf70c94a2..3163660fa8e29 100644
--- a/drivers/firmware/qcom_scm.c
+++ b/drivers/firmware/qcom_scm.c
@@ -1379,6 +1379,10 @@ static const struct of_device_id qcom_scm_dt_match[] = {
SCM_HAS_IFACE_CLK |
SCM_HAS_BUS_CLK)
},
+ { .compatible = "qcom,scm-msm8976", .data = (void *)(SCM_HAS_CORE_CLK |
+ SCM_HAS_IFACE_CLK |
+ SCM_HAS_BUS_CLK)
+ },
{ .compatible = "qcom,scm-msm8994" },
{ .compatible = "qcom,scm-msm8996" },
{ .compatible = "qcom,scm" },
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 0/4] *** Add SCM and mailbox support on MSM8976 ***
2022-03-05 16:49 [PATCH 0/4] *** Add SCM and mailbox support on MSM8976 *** Adam Skladowski
` (3 preceding siblings ...)
2022-03-05 16:49 ` [PATCH 4/4] firmware: qcom_scm: Add compatible for MSM8976 SoC Adam Skladowski
@ 2022-04-13 14:30 ` patchwork-bot+linux-arm-msm
4 siblings, 0 replies; 8+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2022-04-13 14:30 UTC (permalink / raw)
To: Adam Skladowski; +Cc: linux-arm-msm
Hello:
This series was applied to qcom/linux.git (for-next)
by Bjorn Andersson <bjorn.andersson@linaro.org>:
On Sat, 5 Mar 2022 17:49:01 +0100 you wrote:
> This patch series adds support for SCM and mailbox as found on the QCOM
> MSM8976 platform.
>
>
> Adam Skladowski (4):
> dt-bindings: mailbox: Add compatible for the MSM8976
> mailbox: qcom-apcs-ipc: Add compatible for MSM8976 SoC
> dt-bindings: firmware: qcom-scm: Document msm8976 bindings
> firmware: qcom_scm: Add compatible for MSM8976 SoC
>
> [...]
Here is the summary with links:
- [1/4] dt-bindings: mailbox: Add compatible for the MSM8976
(no matching commit)
- [2/4] mailbox: qcom-apcs-ipc: Add compatible for MSM8976 SoC
(no matching commit)
- [3/4] dt-bindings: firmware: qcom-scm: Document msm8976 bindings
https://git.kernel.org/qcom/c/a175c6faaa36
- [4/4] firmware: qcom_scm: Add compatible for MSM8976 SoC
https://git.kernel.org/qcom/c/34128350b838
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 8+ messages in thread