All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] ASoC: sirf-audio: Remove redundant of_match_node call
@ 2019-03-22 22:00 ` Aditya Pakki
  0 siblings, 0 replies; 7+ messages in thread
From: Aditya Pakki @ 2019-03-22 22:00 UTC (permalink / raw)
  To: pakki001
  Cc: kjlu, Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	Barry Song, alsa-devel, linux-arm-kernel, linux-kernel

Unlike other drivers probe method, of_match_node return value
is not used or checked. This patch removes the redundant code.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>

---
v2: Move the signed by above the version change log
v1: A check is unnecessary as match is never used.
---
 sound/soc/codecs/sirf-audio-codec.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sound/soc/codecs/sirf-audio-codec.c b/sound/soc/codecs/sirf-audio-codec.c
index e424499a8450..e0af21050078 100644
--- a/sound/soc/codecs/sirf-audio-codec.c
+++ b/sound/soc/codecs/sirf-audio-codec.c
@@ -461,9 +461,6 @@ static int sirf_audio_codec_driver_probe(struct platform_device *pdev)
 	struct sirf_audio_codec *sirf_audio_codec;
 	void __iomem *base;
 	struct resource *mem_res;
-	const struct of_device_id *match;
-
-	match = of_match_node(sirf_audio_codec_of_match, pdev->dev.of_node);
 
 	sirf_audio_codec = devm_kzalloc(&pdev->dev,
 		sizeof(struct sirf_audio_codec), GFP_KERNEL);
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH v3] ASoC: sirf-audio: Remove redundant of_match_node call
@ 2019-03-22 22:00 ` Aditya Pakki
  0 siblings, 0 replies; 7+ messages in thread
From: Aditya Pakki @ 2019-03-22 22:00 UTC (permalink / raw)
  To: pakki001
  Cc: Barry Song, alsa-devel, linux-kernel, kjlu, Takashi Iwai,
	Liam Girdwood, Mark Brown, Jaroslav Kysela, linux-arm-kernel

Unlike other drivers probe method, of_match_node return value
is not used or checked. This patch removes the redundant code.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>

---
v2: Move the signed by above the version change log
v1: A check is unnecessary as match is never used.
---
 sound/soc/codecs/sirf-audio-codec.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sound/soc/codecs/sirf-audio-codec.c b/sound/soc/codecs/sirf-audio-codec.c
index e424499a8450..e0af21050078 100644
--- a/sound/soc/codecs/sirf-audio-codec.c
+++ b/sound/soc/codecs/sirf-audio-codec.c
@@ -461,9 +461,6 @@ static int sirf_audio_codec_driver_probe(struct platform_device *pdev)
 	struct sirf_audio_codec *sirf_audio_codec;
 	void __iomem *base;
 	struct resource *mem_res;
-	const struct of_device_id *match;
-
-	match = of_match_node(sirf_audio_codec_of_match, pdev->dev.of_node);
 
 	sirf_audio_codec = devm_kzalloc(&pdev->dev,
 		sizeof(struct sirf_audio_codec), GFP_KERNEL);
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH v3] ASoC: sirf-audio: Remove redundant of_match_node call
  2019-03-22 22:00 ` Aditya Pakki
@ 2019-03-25 11:10   ` Steven Price
  -1 siblings, 0 replies; 7+ messages in thread
From: Steven Price @ 2019-03-25 11:10 UTC (permalink / raw)
  To: Aditya Pakki
  Cc: Barry Song, alsa-devel, linux-kernel, kjlu, Takashi Iwai,
	Liam Girdwood, Mark Brown, Jaroslav Kysela, linux-arm-kernel

On 22/03/2019 22:00, Aditya Pakki wrote:
> Unlike other drivers probe method, of_match_node return value
> is not used or checked. This patch removes the redundant code.
> 
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>

Reviewed-by: Steven Price <steven.price@arm.com>

> 
> ---
> v2: Move the signed by above the version change log
> v1: A check is unnecessary as match is never used.
> ---
>  sound/soc/codecs/sirf-audio-codec.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/sound/soc/codecs/sirf-audio-codec.c b/sound/soc/codecs/sirf-audio-codec.c
> index e424499a8450..e0af21050078 100644
> --- a/sound/soc/codecs/sirf-audio-codec.c
> +++ b/sound/soc/codecs/sirf-audio-codec.c
> @@ -461,9 +461,6 @@ static int sirf_audio_codec_driver_probe(struct platform_device *pdev)
>  	struct sirf_audio_codec *sirf_audio_codec;
>  	void __iomem *base;
>  	struct resource *mem_res;
> -	const struct of_device_id *match;
> -
> -	match = of_match_node(sirf_audio_codec_of_match, pdev->dev.of_node);
>  
>  	sirf_audio_codec = devm_kzalloc(&pdev->dev,
>  		sizeof(struct sirf_audio_codec), GFP_KERNEL);
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v3] ASoC: sirf-audio: Remove redundant of_match_node call
@ 2019-03-25 11:10   ` Steven Price
  0 siblings, 0 replies; 7+ messages in thread
From: Steven Price @ 2019-03-25 11:10 UTC (permalink / raw)
  To: Aditya Pakki
  Cc: Barry Song, alsa-devel, linux-kernel, kjlu, Liam Girdwood,
	Takashi Iwai, Mark Brown, Jaroslav Kysela, linux-arm-kernel

On 22/03/2019 22:00, Aditya Pakki wrote:
> Unlike other drivers probe method, of_match_node return value
> is not used or checked. This patch removes the redundant code.
> 
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>

Reviewed-by: Steven Price <steven.price@arm.com>

> 
> ---
> v2: Move the signed by above the version change log
> v1: A check is unnecessary as match is never used.
> ---
>  sound/soc/codecs/sirf-audio-codec.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/sound/soc/codecs/sirf-audio-codec.c b/sound/soc/codecs/sirf-audio-codec.c
> index e424499a8450..e0af21050078 100644
> --- a/sound/soc/codecs/sirf-audio-codec.c
> +++ b/sound/soc/codecs/sirf-audio-codec.c
> @@ -461,9 +461,6 @@ static int sirf_audio_codec_driver_probe(struct platform_device *pdev)
>  	struct sirf_audio_codec *sirf_audio_codec;
>  	void __iomem *base;
>  	struct resource *mem_res;
> -	const struct of_device_id *match;
> -
> -	match = of_match_node(sirf_audio_codec_of_match, pdev->dev.of_node);
>  
>  	sirf_audio_codec = devm_kzalloc(&pdev->dev,
>  		sizeof(struct sirf_audio_codec), GFP_KERNEL);
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v3] ASoC: sirf-audio: Remove redundant of_match_node call
  2019-03-22 22:00 ` Aditya Pakki
  (?)
  (?)
@ 2019-03-25 13:51 ` Mukesh Ojha
  -1 siblings, 0 replies; 7+ messages in thread
From: Mukesh Ojha @ 2019-03-25 13:51 UTC (permalink / raw)
  To: Aditya Pakki
  Cc: Barry Song, alsa-devel, linux-kernel, kjlu, Liam Girdwood,
	Takashi Iwai, Mark Brown, linux-arm-kernel


On 3/23/2019 3:30 AM, Aditya Pakki wrote:
> Unlike other drivers probe method, of_match_node return value

Instead could be written like "Use of `of_match_node` is redundant in 
sirf-audio-codec driver probe. Remove it."

> is not used or checked. This patch removes the redundant code.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>

Reviewed-by: Mukesh Ojha <mojha@codeaurora.org 
<mailto:mojha@codeaurora.org>>

Thanks.
Mukesh


> ---
> v2: Move the signed by above the version change log
> v1: A check is unnecessary as match is never used.
> ---
>   sound/soc/codecs/sirf-audio-codec.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/sound/soc/codecs/sirf-audio-codec.c b/sound/soc/codecs/sirf-audio-codec.c
> index e424499a8450..e0af21050078 100644
> --- a/sound/soc/codecs/sirf-audio-codec.c
> +++ b/sound/soc/codecs/sirf-audio-codec.c
> @@ -461,9 +461,6 @@ static int sirf_audio_codec_driver_probe(struct platform_device *pdev)
>   	struct sirf_audio_codec *sirf_audio_codec;
>   	void __iomem *base;
>   	struct resource *mem_res;
> -	const struct of_device_id *match;
> -
> -	match = of_match_node(sirf_audio_codec_of_match, pdev->dev.of_node);
>   
>   	sirf_audio_codec = devm_kzalloc(&pdev->dev,
>   		sizeof(struct sirf_audio_codec), GFP_KERNEL);

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v3] ASoC: sirf-audio: Remove redundant of_match_node call
  2019-03-22 22:00 ` Aditya Pakki
@ 2019-03-27 14:33   ` Mukesh Ojha
  -1 siblings, 0 replies; 7+ messages in thread
From: Mukesh Ojha @ 2019-03-27 14:33 UTC (permalink / raw)
  To: Aditya Pakki
  Cc: Barry Song, alsa-devel, linux-kernel, kjlu, Takashi Iwai,
	Liam Girdwood, Mark Brown, Jaroslav Kysela, linux-arm-kernel


On 3/23/2019 3:30 AM, Aditya Pakki wrote:
> Unlike other drivers probe method, of_match_node return value
> is not used or checked. This patch removes the redundant code.

Instead could be written like "Use of `of_match_node` is redundant in 
sirf-audio-codec driver probe. Remove it."

>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>

Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

-Mukesh


>
> ---
> v2: Move the signed by above the version change log
> v1: A check is unnecessary as match is never used.
> ---
>   sound/soc/codecs/sirf-audio-codec.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/sound/soc/codecs/sirf-audio-codec.c b/sound/soc/codecs/sirf-audio-codec.c
> index e424499a8450..e0af21050078 100644
> --- a/sound/soc/codecs/sirf-audio-codec.c
> +++ b/sound/soc/codecs/sirf-audio-codec.c
> @@ -461,9 +461,6 @@ static int sirf_audio_codec_driver_probe(struct platform_device *pdev)
>   	struct sirf_audio_codec *sirf_audio_codec;
>   	void __iomem *base;
>   	struct resource *mem_res;
> -	const struct of_device_id *match;
> -
> -	match = of_match_node(sirf_audio_codec_of_match, pdev->dev.of_node);
>   
>   	sirf_audio_codec = devm_kzalloc(&pdev->dev,
>   		sizeof(struct sirf_audio_codec), GFP_KERNEL);

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v3] ASoC: sirf-audio: Remove redundant of_match_node call
@ 2019-03-27 14:33   ` Mukesh Ojha
  0 siblings, 0 replies; 7+ messages in thread
From: Mukesh Ojha @ 2019-03-27 14:33 UTC (permalink / raw)
  To: Aditya Pakki
  Cc: Barry Song, alsa-devel, linux-kernel, kjlu, Liam Girdwood,
	Takashi Iwai, Mark Brown, Jaroslav Kysela, linux-arm-kernel


On 3/23/2019 3:30 AM, Aditya Pakki wrote:
> Unlike other drivers probe method, of_match_node return value
> is not used or checked. This patch removes the redundant code.

Instead could be written like "Use of `of_match_node` is redundant in 
sirf-audio-codec driver probe. Remove it."

>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>

Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

-Mukesh


>
> ---
> v2: Move the signed by above the version change log
> v1: A check is unnecessary as match is never used.
> ---
>   sound/soc/codecs/sirf-audio-codec.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/sound/soc/codecs/sirf-audio-codec.c b/sound/soc/codecs/sirf-audio-codec.c
> index e424499a8450..e0af21050078 100644
> --- a/sound/soc/codecs/sirf-audio-codec.c
> +++ b/sound/soc/codecs/sirf-audio-codec.c
> @@ -461,9 +461,6 @@ static int sirf_audio_codec_driver_probe(struct platform_device *pdev)
>   	struct sirf_audio_codec *sirf_audio_codec;
>   	void __iomem *base;
>   	struct resource *mem_res;
> -	const struct of_device_id *match;
> -
> -	match = of_match_node(sirf_audio_codec_of_match, pdev->dev.of_node);
>   
>   	sirf_audio_codec = devm_kzalloc(&pdev->dev,
>   		sizeof(struct sirf_audio_codec), GFP_KERNEL);

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-03-27 14:33 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-22 22:00 [PATCH v3] ASoC: sirf-audio: Remove redundant of_match_node call Aditya Pakki
2019-03-22 22:00 ` Aditya Pakki
2019-03-25 11:10 ` Steven Price
2019-03-25 11:10   ` Steven Price
2019-03-25 13:51 ` Mukesh Ojha
2019-03-27 14:33 ` Mukesh Ojha
2019-03-27 14:33   ` Mukesh Ojha

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.