All of lore.kernel.org
 help / color / mirror / Atom feed
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
To: Tamas K Lengyel <tamas@tklengyel.com>
Cc: "Sahita, Ravi" <ravi.sahita@intel.com>,
	"wei.liu2@citrix.com" <wei.liu2@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Xen-devel <xen-devel@lists.xen.org>,
	Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] common/mem_access: merged mem_access setting interfaces
Date: Thu, 16 Mar 2017 20:33:44 +0200	[thread overview]
Message-ID: <72908986-994e-f5d7-502a-c1af070abcd7@bitdefender.com> (raw)
In-Reply-To: <CABfawhmW8BJzxG=B0E1U9_N4qLBtHs-nuz-gRpmVvzrM9aSytw@mail.gmail.com>

On 03/16/2017 08:10 PM, Tamas K Lengyel wrote:
> 
> 
>     diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h
>     index 6eee0c8..ca53a0c 100644
>     --- a/xen/include/public/memory.h
>     +++ b/xen/include/public/memory.h
>     @@ -444,6 +444,8 @@ struct xen_mem_access_op {
>          /* xenmem_access_t */
>          uint8_t access;
>          domid_t domid;
>     +    uint16_t view_id;
>     +    uint16_t pad;
> 
> 
> I think this will mess with the next uint32_t struct member, so either
> this pad should be uint16_t pad[3], or another pad needs to be added
> after the following uint32_t nr.

Fair enough, I'll need to send V2 anyway as Roger's "x86: remove PVHv1
code" has also bumped XEN_DOMCTL_INTERFACE_VERSION and I now need to
take it out.


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-03-16 18:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-16 12:32 [PATCH] common/mem_access: merged mem_access setting interfaces Razvan Cojocaru
2017-03-16 14:12 ` Wei Liu
2017-03-16 18:10 ` Tamas K Lengyel
2017-03-16 18:33   ` Razvan Cojocaru [this message]
2017-03-16 18:36     ` Tamas K Lengyel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72908986-994e-f5d7-502a-c1af070abcd7@bitdefender.com \
    --to=rcojocaru@bitdefender.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=ravi.sahita@intel.com \
    --cc=tamas@tklengyel.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.