Re: [PATCH] common/mem_access: merged mem_access setting interfaces

From: Tamas K Lengyel <tamas@tklengyel.com>
To: Razvan Cojocaru <rcojocaru@bitdefender.com>
Cc: "Sahita, Ravi" <ravi.sahita@intel.com>,
	"wei.liu2@citrix.com" <wei.liu2@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Xen-devel <xen-devel@lists.xen.org>,
	Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] common/mem_access: merged mem_access setting interfaces
Date: Thu, 16 Mar 2017 12:36:11 -0600	[thread overview]
Message-ID: <CABfawhktLF7N580oLkj6u4FoQZTs+R=1GUkso5B=s=AyHs_qOA@mail.gmail.com> (raw)
In-Reply-To: <72908986-994e-f5d7-502a-c1af070abcd7@bitdefender.com>

[-- Attachment #1.1: Type: text/plain, Size: 967 bytes --]

On Thu, Mar 16, 2017 at 12:33 PM, Razvan Cojocaru <rcojocaru@bitdefender.com
> wrote:

> On 03/16/2017 08:10 PM, Tamas K Lengyel wrote:
> >
> >
> >     diff --git a/xen/include/public/memory.h
> b/xen/include/public/memory.h
> >     index 6eee0c8..ca53a0c 100644
> >     --- a/xen/include/public/memory.h
> >     +++ b/xen/include/public/memory.h
> >     @@ -444,6 +444,8 @@ struct xen_mem_access_op {
> >          /* xenmem_access_t */
> >          uint8_t access;
> >          domid_t domid;
> >     +    uint16_t view_id;
> >     +    uint16_t pad;
> >
> >
> > I think this will mess with the next uint32_t struct member, so either
> > this pad should be uint16_t pad[3], or another pad needs to be added
> > after the following uint32_t nr.
>
> Fair enough, I'll need to send V2 anyway as Roger's "x86: remove PVHv1
> code" has also bumped XEN_DOMCTL_INTERFACE_VERSION and I now need to
> take it out.
>

Sounds good. The patch looks good to me otherwise.

Tamas

[-- Attachment #1.2: Type: text/html, Size: 1510 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel