From: Edward Cree <ecree@solarflare.com> To: David Miller <davem@davemloft.net>, <wsa+renesas@sang-engineering.com> Cc: <linux-i2c@vger.kernel.org>, <linux-net-drivers@solarflare.com>, <mhabets@solarflare.com>, <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] net: sfc: falcon: convert to i2c_new_dummy_device Date: Thu, 25 Jul 2019 13:37:57 +0100 [thread overview] Message-ID: <72968faa-e260-3640-99be-9c63bc79ad5e@solarflare.com> (raw) In-Reply-To: <20190724.154739.72147269285837223.davem@davemloft.net> On 24/07/2019 23:47, David Miller wrote: > From: Wolfram Sang <wsa+renesas@sang-engineering.com> > Date: Mon, 22 Jul 2019 19:26:35 +0200 > >> Move from i2c_new_dummy() to i2c_new_dummy_device(). So, we now get an >> ERRPTR which we use in error handling. >> >> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Subject & description are incomplete, you're also changing i2c_new_device() to i2c_new_client_device(). Other than that, Acked-by: Edward Cree <ecree@solarflare.com> > Solarflare folks, please review/test. > > Thank you. Falcon isn't likely to get tested by us, I think we only have about three of them left in the building, two of which are in display cabinets ;-) We end-of-lifed this hardware a couple of years ago, maybe it should be downgraded from 'supported' to 'odd fixes'. Or even moved to staging, like that qlogic driver recently was.
WARNING: multiple messages have this Message-ID (diff)
From: Edward Cree <ecree@solarflare.com> To: David Miller <davem@davemloft.net>, wsa+renesas@sang-engineering.com Cc: linux-i2c@vger.kernel.org, linux-net-drivers@solarflare.com, mhabets@solarflare.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: sfc: falcon: convert to i2c_new_dummy_device Date: Thu, 25 Jul 2019 13:37:57 +0100 [thread overview] Message-ID: <72968faa-e260-3640-99be-9c63bc79ad5e@solarflare.com> (raw) In-Reply-To: <20190724.154739.72147269285837223.davem@davemloft.net> On 24/07/2019 23:47, David Miller wrote: > From: Wolfram Sang <wsa+renesas@sang-engineering.com> > Date: Mon, 22 Jul 2019 19:26:35 +0200 > >> Move from i2c_new_dummy() to i2c_new_dummy_device(). So, we now get an >> ERRPTR which we use in error handling. >> >> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Subject & description are incomplete, you're also changing i2c_new_device() to i2c_new_client_device(). Other than that, Acked-by: Edward Cree <ecree@solarflare.com> > Solarflare folks, please review/test. > > Thank you. Falcon isn't likely to get tested by us, I think we only have about three of them left in the building, two of which are in display cabinets ;-) We end-of-lifed this hardware a couple of years ago, maybe it should be downgraded from 'supported' to 'odd fixes'. Or even moved to staging, like that qlogic driver recently was.
next prev parent reply other threads:[~2019-07-25 12:38 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-22 17:26 [PATCH] net: sfc: falcon: convert to i2c_new_dummy_device Wolfram Sang 2019-07-24 22:47 ` David Miller 2019-07-25 12:37 ` Edward Cree [this message] 2019-07-25 12:37 ` Edward Cree 2019-07-25 19:27 ` Wolfram Sang 2019-07-25 18:19 ` David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=72968faa-e260-3640-99be-9c63bc79ad5e@solarflare.com \ --to=ecree@solarflare.com \ --cc=davem@davemloft.net \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-net-drivers@solarflare.com \ --cc=mhabets@solarflare.com \ --cc=netdev@vger.kernel.org \ --cc=wsa+renesas@sang-engineering.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.