All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
To: "ikjn@chromium.org" <ikjn@chromium.org>, "tiwai@suse.de" <tiwai@suse.de>
Cc: "grpintar@gmail.com" <grpintar@gmail.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"dylan_robinson@motu.com" <dylan_robinson@motu.com>,
	"kai.heng.feng@canonical.com" <kai.heng.feng@canonical.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"tiwai@suse.com" <tiwai@suse.com>,
	"livvy@base.nu" <livvy@base.nu>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"alexander@tsoy.me" <alexander@tsoy.me>,
	"perex@perex.cz" <perex@perex.cz>
Subject: Re: [PATCH] ALSA: usb-audio: Apply sample rate quirk to Logitech Connect
Date: Thu, 25 Mar 2021 11:01:08 +0000	[thread overview]
Message-ID: <72c6194f84221d2902941286e8ba0f74f4f1ad6d.camel@infinera.com> (raw)
In-Reply-To: <s5ho8f8ogx8.wl-tiwai@suse.de>

On Wed, 2021-03-24 at 13:49 +0100, Takashi Iwai wrote:
> On Wed, 24 Mar 2021 13:03:14 +0100,
> Ikjoon Jang wrote:
> > 
> > On Wed, Mar 24, 2021, 7:16 PM Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> > wrote:
> > 
> 
> The Logitech devices with 046d:* should be covered generally in
> snd_usb_ctl_msg_quirk(), so I guess it's a different problem.
> But please check it first.
> 
> > And 20ms can be too long if it's applied to every control transfer. I will
> > test the device with shorter delay if you didn't try it before.
> 
> Actually the delay applied to Logitech devices is from 1 to 2ms, not
> 20ms.  The 20ms delay is applied for some other devices.  But if
> extending the delay fixes the problem, we need to reconsider the delay
> length.
> 

There are a lot of devices USB Audio devices that need that 1-2 ms delay. Have
you considered to make this delay generic(for all Audio USB devices) ?
Seems like Windows has something similar as these devices just work there.

 Jocke

WARNING: multiple messages have this Message-ID (diff)
From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
To: "ikjn@chromium.org" <ikjn@chromium.org>, "tiwai@suse.de" <tiwai@suse.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"dylan_robinson@motu.com" <dylan_robinson@motu.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"tiwai@suse.com" <tiwai@suse.com>,
	"alexander@tsoy.me" <alexander@tsoy.me>,
	"kai.heng.feng@canonical.com" <kai.heng.feng@canonical.com>,
	"grpintar@gmail.com" <grpintar@gmail.com>,
	"livvy@base.nu" <livvy@base.nu>
Subject: Re: [PATCH] ALSA: usb-audio: Apply sample rate quirk to Logitech Connect
Date: Thu, 25 Mar 2021 11:01:08 +0000	[thread overview]
Message-ID: <72c6194f84221d2902941286e8ba0f74f4f1ad6d.camel@infinera.com> (raw)
In-Reply-To: <s5ho8f8ogx8.wl-tiwai@suse.de>

On Wed, 2021-03-24 at 13:49 +0100, Takashi Iwai wrote:
> On Wed, 24 Mar 2021 13:03:14 +0100,
> Ikjoon Jang wrote:
> > 
> > On Wed, Mar 24, 2021, 7:16 PM Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> > wrote:
> > 
> 
> The Logitech devices with 046d:* should be covered generally in
> snd_usb_ctl_msg_quirk(), so I guess it's a different problem.
> But please check it first.
> 
> > And 20ms can be too long if it's applied to every control transfer. I will
> > test the device with shorter delay if you didn't try it before.
> 
> Actually the delay applied to Logitech devices is from 1 to 2ms, not
> 20ms.  The 20ms delay is applied for some other devices.  But if
> extending the delay fixes the problem, we need to reconsider the delay
> length.
> 

There are a lot of devices USB Audio devices that need that 1-2 ms delay. Have
you considered to make this delay generic(for all Audio USB devices) ?
Seems like Windows has something similar as these devices just work there.

 Jocke

  reply	other threads:[~2021-03-25 11:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-24 10:51 [PATCH] ALSA: usb-audio: Apply sample rate quirk to Logitech Connect Ikjoon Jang
2021-03-24 10:51 ` Ikjoon Jang
2021-03-24 11:16 ` Joakim Tjernlund
2021-03-24 11:16   ` Joakim Tjernlund
2021-03-24 12:03   ` Ikjoon Jang
2021-03-24 12:05     ` Dmitry Panchenko | d-Systems
2021-03-24 12:49     ` Takashi Iwai
2021-03-24 12:49       ` Takashi Iwai
2021-03-25 11:01       ` Joakim Tjernlund [this message]
2021-03-25 11:01         ` Joakim Tjernlund
2021-03-29  6:23       ` Ikjoon Jang
2021-03-29  6:23         ` Ikjoon Jang
2021-03-29 11:23         ` Takashi Iwai
2021-03-29 11:23           ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72c6194f84221d2902941286e8ba0f74f4f1ad6d.camel@infinera.com \
    --to=joakim.tjernlund@infinera.com \
    --cc=alexander@tsoy.me \
    --cc=alsa-devel@alsa-project.org \
    --cc=dylan_robinson@motu.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=grpintar@gmail.com \
    --cc=ikjn@chromium.org \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=livvy@base.nu \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.