Re: [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195

From: "Nancy Lin (林欣螢)" <Nancy.Lin@mediatek.com>
To: "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
	"angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>,
	"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	"Singo Chang (張興國)" <Singo.Chang@mediatek.com>,
	"ndesaulniers@google.com" <ndesaulniers@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"nathan@kernel.org" <nathan@kernel.org>,
	"clang-built-linux@googlegroups.com"
	<clang-built-linux@googlegroups.com>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195
Date: Fri, 17 Mar 2023 07:55:41 +0000	[thread overview]
Message-ID: <72cf6344a1c5942bff0872d05dce82b787b49b76.camel@mediatek.com> (raw)
In-Reply-To: <0ebf187d-972e-4228-d8a0-8c0ce02f642d@linaro.org>

[-- Attachment #1: Type: text/html, Size: 7270 bytes --]

[-- Attachment #2: Type: text/plain, Size: 2994 bytes --]

On Thu, 2023-03-16 at 12:36 +0100, Krzysztof Kozlowski wrote:
> On 16/03/2023 10:53, AngeloGioacchino Del Regno wrote:
> 
> > Hello Krzysztof, Nancy,
> > 
> > Since this series has reached v29, can we please reach an agreement
> > on the bindings
> > to use here, so that we can get this finally upstreamed?
> > 
> > I will put some examples to try to get this issue resolved.
> > 
> > ### Example 1: Constrain the number of GCE entries to *seven* array
> > elements (7x4!)
> > 
> >    mediatek,gce-client-reg:
> >      $ref: /schemas/types.yaml#/definitions/phandle-array
> >      maxItems: 1
> >      description: The register of display function block to be set
> > by gce.
> >        There are 4 arguments in this property, gce node, subsys id,
> > offset and
> >        register size. The subsys id is defined in the gce header of
> > each chips
> >        include/dt-bindings/gce/<chip>-gce.h, mapping to the
> > register of display
> >        function block.
> >      items:
> >        minItems: 28
> >        maxItems: 28
> >        items:                     <----- this block doesn't seem to
> > get checked :\
> >          - description: phandle of GCE
> >          - description: GCE subsys id
> >          - description: register offset
> >          - description: register size
> 
> This is what we would like to have but it requires exception in
> dtschema. Thus:
> 
> > 
> > 
> > ### Example 2: Don't care about constraining the number of
> > arguments
> > 
> >    mediatek,gce-client-reg:
> >      $ref: /schemas/types.yaml#/definitions/phandle-array
> >      maxItems: 1
> >      description: The register of display function block to be set
> > by gce.
> >        There are 4 arguments in this property, gce node, subsys id,
> > offset and
> >        register size. The subsys id is defined in the gce header of
> > each chips
> >        include/dt-bindings/gce/<chip>-gce.h, mapping to the
> > register of display
> >        function block.
> 
> use this.
> 
> Best regards,
> Krzysztof

Hi Krzysztof, Angelo,

Thanks for the comment.
The Example 2 can pass dt_binding_check. 

But the example in the binding has 7 items [1] and dts [2]. Does the
"maxItems: 1" affect any other schema or dts check? 

[1]
+    mediatek,gce-client-reg = <&gce0 SUBSYS_1c11XXXX 0x4000 0x1000>,
+                              <&gce0 SUBSYS_1c11XXXX 0x5000 0x1000>,
+                              <&gce0 SUBSYS_1c11XXXX 0x7000 0x1000>,
+                              <&gce0 SUBSYS_1c11XXXX 0x9000 0x1000>,
+                              <&gce0 SUBSYS_1c11XXXX 0xa000 0x1000>,
+                              <&gce0 SUBSYS_1c11XXXX 0xb000 0x1000>,
+                              <&gce0 SUBSYS_1c11XXXX 0xc000 0x1000>;
> 

[2] [v21,25/25] arm64: dts: mt8195: add display node for vdosys1

https://patchwork.kernel.org/project/linux-mediatek/patch/20220504091440.2052-26-nancy.lin@mediatek.com/

Regards,
Nancy