All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Paul Mackerras" <paulus@ozlabs.org>,
	"Radim Krčmář" <rkrcmar@redhat.com>
Cc: kvm@vger.kernel.org, David Gibson <david@gibson.dropbear.id.au>,
	kvm-ppc@vger.kernel.org
Subject: Re: [GIT PULL] Please pull my kvm-ppc-fixes branch
Date: Wed, 21 Jun 2017 12:30:51 +0200	[thread overview]
Message-ID: <7304ec7d-9eb3-0eec-706f-b7689e64560a@redhat.com> (raw)
In-Reply-To: <20170620233756.GA3644@fergus.ozlabs.ibm.com>



On 21/06/2017 01:37, Paul Mackerras wrote:
>> Right, and the arch doesn't even match ... let's forget I asked. :)
>>
>> Pushed into kvm/master, thanks.
> Thanks.
> 
> On a related note, we still have the warning in virt/kvm/kvm_main.c
> for CONFIG_SMP=n builds about the variable 'wait' being unused in
> kvm_make_all_cpus_request(), because smp_call_function_many() doesn't
> reference its 'wait' argument for uniprocessor configs.
> 
> This then causes the build to fail on powerpc because kvm_main.c
> actually gets compiled under arch/powerpc, and we use -Werror for
> arch/powerpc by default.
> 
> Paolo posted a sketch of a patch to make smp_call_function_many be a
> static inline instead of a macro on UP, but it wasn't quite right and
> no-one sent it anywhere.  Paolo, if you're OK with me cleaning it up
> and sending it on, I'll do that.

The problem is that it breaks MIPS, which uses an unused variable.  I'll
send an alternative patch that is confined in KVM.

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Paul Mackerras" <paulus@ozlabs.org>,
	"Radim Krčmář" <rkrcmar@redhat.com>
Cc: kvm@vger.kernel.org, David Gibson <david@gibson.dropbear.id.au>,
	kvm-ppc@vger.kernel.org
Subject: Re: [GIT PULL] Please pull my kvm-ppc-fixes branch
Date: Wed, 21 Jun 2017 10:30:51 +0000	[thread overview]
Message-ID: <7304ec7d-9eb3-0eec-706f-b7689e64560a@redhat.com> (raw)
In-Reply-To: <20170620233756.GA3644@fergus.ozlabs.ibm.com>



On 21/06/2017 01:37, Paul Mackerras wrote:
>> Right, and the arch doesn't even match ... let's forget I asked. :)
>>
>> Pushed into kvm/master, thanks.
> Thanks.
> 
> On a related note, we still have the warning in virt/kvm/kvm_main.c
> for CONFIG_SMP=n builds about the variable 'wait' being unused in
> kvm_make_all_cpus_request(), because smp_call_function_many() doesn't
> reference its 'wait' argument for uniprocessor configs.
> 
> This then causes the build to fail on powerpc because kvm_main.c
> actually gets compiled under arch/powerpc, and we use -Werror for
> arch/powerpc by default.
> 
> Paolo posted a sketch of a patch to make smp_call_function_many be a
> static inline instead of a macro on UP, but it wasn't quite right and
> no-one sent it anywhere.  Paolo, if you're OK with me cleaning it up
> and sending it on, I'll do that.

The problem is that it breaks MIPS, which uses an unused variable.  I'll
send an alternative patch that is confined in KVM.

Paolo

  reply	other threads:[~2017-06-21 10:30 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-20  4:30 [GIT PULL] Please pull my kvm-ppc-fixes branch Paul Mackerras
2017-06-20  4:30 ` Paul Mackerras
2017-06-20 12:39 ` Radim Krčmář
2017-06-20 12:39   ` Radim Krčmář
2017-06-20 12:55   ` Paolo Bonzini
2017-06-20 12:55     ` Paolo Bonzini
2017-06-20 15:17     ` Radim Krčmář
2017-06-20 15:17       ` Radim Krčmář
2017-06-20 23:37       ` Paul Mackerras
2017-06-20 23:37         ` Paul Mackerras
2017-06-21 10:30         ` Paolo Bonzini [this message]
2017-06-21 10:30           ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2017-10-19  4:20 Paul Mackerras
2017-10-19  4:20 ` Paul Mackerras
2017-10-19 13:11 ` Radim Krčmář
2017-10-19 13:11   ` Radim Krčmář
2017-09-14  4:06 Paul Mackerras
2017-09-14  4:06 ` Paul Mackerras
2017-08-30  6:21 Paul Mackerras
2017-08-30  6:21 ` Paul Mackerras
2017-09-08 14:37 ` Radim Krčmář
2017-09-08 14:37   ` Radim Krčmář
2017-09-09 13:38   ` Paolo Bonzini
2017-09-09 13:38     ` Paolo Bonzini
2017-09-12  4:01     ` Paul Mackerras
2017-09-12  4:01       ` Paul Mackerras
2017-08-25  1:38 Paul Mackerras
2017-08-25  1:38 ` Paul Mackerras
2017-08-25  7:02 ` Paolo Bonzini
2017-08-25  7:02   ` Paolo Bonzini
2017-08-25  9:06   ` Paul Mackerras
2017-08-25  9:06     ` Paul Mackerras
2017-07-26  4:43 Paul Mackerras
2017-07-26  4:43 ` Paul Mackerras
2017-07-01 10:11 [GIT PULL] Please pull my kvm-ppc-fixes branch again Paul Mackerras
2017-07-01 10:11 ` Paul Mackerras
2017-07-03  8:40 ` Paolo Bonzini
2017-07-03  8:40   ` Paolo Bonzini
2017-07-05  6:54   ` Paul Mackerras
2017-07-05  6:54     ` Paul Mackerras
2017-05-15  8:16 [GIT PULL] Please pull my kvm-ppc-fixes branch Paul Mackerras
2017-05-15  8:16 ` Paul Mackerras
2017-05-15  8:32 ` Christian Zigotzky
2017-05-15  8:32   ` Christian Zigotzky
2017-05-16 13:52 ` Radim Krčmář
2017-05-16 13:52   ` Radim Krčmář
2017-04-06  6:28 Paul Mackerras
2017-04-06  6:28 ` Paul Mackerras
2017-04-06 14:37 ` Radim Krčmář
2017-04-06 14:37   ` Radim Krčmář
2017-03-02  1:55 Paul Mackerras
2017-03-02  1:55 ` Paul Mackerras
2017-03-02 11:00 ` Paolo Bonzini
2017-03-02 11:00   ` Paolo Bonzini
2017-03-02 21:04 ` Radim Krčmář
2017-03-02 21:04   ` Radim Krčmář
2016-03-08 10:54 Paul Mackerras
2016-03-08 10:54 ` Paul Mackerras
2015-12-10  3:12 Paul Mackerras
2015-12-10  3:12 ` Paul Mackerras
2015-12-11 11:30 ` Paolo Bonzini
2015-12-11 11:30   ` Paolo Bonzini
2015-11-12  5:35 Paul Mackerras
2015-11-12  5:35 ` Paul Mackerras
2015-11-12  9:11 ` Paolo Bonzini
2015-11-12  9:11   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7304ec7d-9eb3-0eec-706f-b7689e64560a@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=paulus@ozlabs.org \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.