From: Georgi Djakov <georgi.djakov@linaro.org> To: Vincent Guittot <vincent.guittot@linaro.org> Cc: "open list:THERMAL" <linux-pm@vger.kernel.org>, "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Rob Herring <robh+dt@kernel.org>, mturquette <mturquette@baylibre.com>, Kevin Hilman <khilman@baylibre.com>, Saravana Kannan <skannan@codeaurora.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Amit Kucheria <amit.kucheria@linaro.org>, "Sweeney, Sean" <seansw@qti.qualcomm.com>, daidavid1@codeaurora.org, Evan Green <evgreen@chromium.org>, Mark Rutland <mark.rutland@arm.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, abailon@baylibre.com, linux-kernel <linux-kernel@vger.kernel.org>, LAK <linux-arm-kernel@lists.infradead.org>, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v5 1/8] interconnect: Add generic on-chip interconnect API Date: Sun, 1 Jul 2018 14:09:26 +0300 [thread overview] Message-ID: <730fac43-e99f-e4bd-bc40-eddeb8338e6e@linaro.org> (raw) In-Reply-To: <CAKfTPtBApjf9rhJm3paeXdgbVG50ALeun=zMUddc-f+RnrvkqQ@mail.gmail.com> Hi Vincent, On 27.06.18 г. 9:19, Vincent Guittot wrote: > Hi Georgi > > On Wed, 20 Jun 2018 at 14:11, Georgi Djakov <georgi.djakov@linaro.org> wrote: > > [snip] > >> + >> +static struct icc_path *path_allocate(struct icc_node *dst, ssize_t num_nodes) >> +{ >> + struct icc_node *node = dst; >> + struct icc_path *path; >> + size_t i; >> + >> + path = kzalloc(sizeof(*path) + num_nodes * sizeof(*path->reqs), > > Should be (num_nodes -1) * sizeof(*path->reqs) as there is already 1 > icc_req in icc_path struct reqs[] is a flexible array member and it's size is not included in sizeof(*path) Thanks, Georgi >> + GFP_KERNEL); >> + if (!path) >> + return ERR_PTR(-ENOMEM); >> + >> + path->num_nodes = num_nodes; >> + >> + for (i = 0; i < num_nodes; i++) { >> + hlist_add_head(&path->reqs[i].req_node, &node->req_list); >> + >> + path->reqs[i].node = node; >> + /* reference to previous node was saved during path traversal */ >> + node = node->reverse; >> + } >> + >> + return path; >> +} >> + > > [snip] >
WARNING: multiple messages have this Message-ID (diff)
From: georgi.djakov@linaro.org (Georgi Djakov) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 1/8] interconnect: Add generic on-chip interconnect API Date: Sun, 1 Jul 2018 14:09:26 +0300 [thread overview] Message-ID: <730fac43-e99f-e4bd-bc40-eddeb8338e6e@linaro.org> (raw) In-Reply-To: <CAKfTPtBApjf9rhJm3paeXdgbVG50ALeun=zMUddc-f+RnrvkqQ@mail.gmail.com> Hi Vincent, On 27.06.18 ?. 9:19, Vincent Guittot wrote: > Hi Georgi > > On Wed, 20 Jun 2018 at 14:11, Georgi Djakov <georgi.djakov@linaro.org> wrote: > > [snip] > >> + >> +static struct icc_path *path_allocate(struct icc_node *dst, ssize_t num_nodes) >> +{ >> + struct icc_node *node = dst; >> + struct icc_path *path; >> + size_t i; >> + >> + path = kzalloc(sizeof(*path) + num_nodes * sizeof(*path->reqs), > > Should be (num_nodes -1) * sizeof(*path->reqs) as there is already 1 > icc_req in icc_path struct reqs[] is a flexible array member and it's size is not included in sizeof(*path) Thanks, Georgi >> + GFP_KERNEL); >> + if (!path) >> + return ERR_PTR(-ENOMEM); >> + >> + path->num_nodes = num_nodes; >> + >> + for (i = 0; i < num_nodes; i++) { >> + hlist_add_head(&path->reqs[i].req_node, &node->req_list); >> + >> + path->reqs[i].node = node; >> + /* reference to previous node was saved during path traversal */ >> + node = node->reverse; >> + } >> + >> + return path; >> +} >> + > > [snip] >
next prev parent reply other threads:[~2018-07-01 11:09 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-20 12:11 [PATCH v5 0/8] Introduce on-chip interconnect API Georgi Djakov 2018-06-20 12:11 ` Georgi Djakov 2018-06-20 12:11 ` [PATCH v5 1/8] interconnect: Add generic " Georgi Djakov 2018-06-20 12:11 ` Georgi Djakov 2018-06-26 20:57 ` Evan Green 2018-06-26 20:57 ` Evan Green 2018-06-26 20:57 ` Evan Green 2018-06-26 21:58 ` Matthias Kaehlcke 2018-06-26 21:58 ` Matthias Kaehlcke 2018-06-27 0:54 ` Rob Clark 2018-06-27 0:54 ` Rob Clark 2018-07-01 11:03 ` Georgi Djakov 2018-07-01 11:03 ` Georgi Djakov 2018-07-01 11:03 ` Georgi Djakov 2018-06-26 23:34 ` Matthias Kaehlcke 2018-06-26 23:34 ` Matthias Kaehlcke 2018-07-01 11:06 ` Georgi Djakov 2018-07-01 11:06 ` Georgi Djakov 2018-06-27 6:19 ` Vincent Guittot 2018-06-27 6:19 ` Vincent Guittot 2018-07-01 11:09 ` Georgi Djakov [this message] 2018-07-01 11:09 ` Georgi Djakov 2018-07-02 7:23 ` Vincent Guittot 2018-07-02 7:23 ` Vincent Guittot 2018-06-20 12:11 ` [PATCH v5 2/8] dt-bindings: Introduce interconnect provider bindings Georgi Djakov 2018-06-20 12:11 ` Georgi Djakov 2018-06-20 12:11 ` [PATCH v5 3/8] interconnect: Add debugfs support Georgi Djakov 2018-06-20 12:11 ` Georgi Djakov 2018-06-20 12:11 ` [PATCH v5 4/8] interconnect: qcom: Add RPM communication Georgi Djakov 2018-06-20 12:11 ` Georgi Djakov 2018-06-26 20:47 ` Evan Green 2018-06-26 20:47 ` Evan Green 2018-07-01 11:16 ` Georgi Djakov 2018-07-01 11:16 ` Georgi Djakov 2018-06-27 0:55 ` Matthias Kaehlcke 2018-06-27 0:55 ` Matthias Kaehlcke 2018-07-01 11:18 ` Georgi Djakov 2018-07-01 11:18 ` Georgi Djakov 2018-06-20 12:11 ` [PATCH v5 5/8] dt-bindings: interconnect: Document qcom,msm8916 NoC bindings Georgi Djakov 2018-06-20 12:11 ` [PATCH v5 5/8] dt-bindings: interconnect: Document qcom, msm8916 " Georgi Djakov 2018-06-20 12:11 ` [PATCH v5 6/8] interconnect: qcom: Add msm8916 interconnect provider driver Georgi Djakov 2018-06-20 12:11 ` Georgi Djakov 2018-06-26 20:48 ` Evan Green 2018-06-26 20:48 ` Evan Green 2018-07-01 12:12 ` Georgi Djakov 2018-07-01 12:12 ` Georgi Djakov 2018-07-02 17:08 ` Evan Green 2018-07-02 17:08 ` Evan Green 2018-07-02 17:08 ` Evan Green 2018-06-20 12:11 ` [PATCH v5 7/8] dt-bindings: Introduce interconnect consumers bindings Georgi Djakov 2018-06-20 12:11 ` Georgi Djakov 2018-06-20 12:11 ` Georgi Djakov 2018-06-20 12:11 ` [PATCH v5 8/8] interconnect: Allow endpoints translation via DT Georgi Djakov 2018-06-20 12:11 ` Georgi Djakov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=730fac43-e99f-e4bd-bc40-eddeb8338e6e@linaro.org \ --to=georgi.djakov@linaro.org \ --cc=abailon@baylibre.com \ --cc=amit.kucheria@linaro.org \ --cc=bjorn.andersson@linaro.org \ --cc=daidavid1@codeaurora.org \ --cc=evgreen@chromium.org \ --cc=gregkh@linuxfoundation.org \ --cc=khilman@baylibre.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=mark.rutland@arm.com \ --cc=mturquette@baylibre.com \ --cc=rjw@rjwysocki.net \ --cc=robh+dt@kernel.org \ --cc=seansw@qti.qualcomm.com \ --cc=skannan@codeaurora.org \ --cc=vincent.guittot@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.