* [PATCH -next] media: imx-jpeg: Fix error return code in mxc_jpeg_probe()
@ 2021-03-23 11:28 ` 'w00385741
0 siblings, 0 replies; 4+ messages in thread
From: 'w00385741 @ 2021-03-23 11:28 UTC (permalink / raw)
To: weiyongjun1, Mirela Rabulea, Mauro Carvalho Chehab, Shawn Guo,
Sascha Hauer
Cc: linux-media, linux-arm-kernel, kernel-janitors, Hulk Robot
From: Wei Yongjun <weiyongjun1@huawei.com>
Fix to return negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 2db16c6ed72c ("media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/media/platform/imx-jpeg/mxc-jpeg.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/imx-jpeg/mxc-jpeg.c
index 2d29558f1864..70b9b61fbf88 100644
--- a/drivers/media/platform/imx-jpeg/mxc-jpeg.c
+++ b/drivers/media/platform/imx-jpeg/mxc-jpeg.c
@@ -2022,12 +2022,14 @@ static int mxc_jpeg_probe(struct platform_device *pdev)
jpeg->m2m_dev = v4l2_m2m_init(&mxc_jpeg_m2m_ops);
if (IS_ERR(jpeg->m2m_dev)) {
dev_err(dev, "failed to register v4l2 device\n");
+ ret = PTR_ERR(jpeg->m2m_dev);
goto err_m2m;
}
jpeg->dec_vdev = video_device_alloc();
if (!jpeg->dec_vdev) {
dev_err(dev, "failed to register v4l2 device\n");
+ ret = -ENOMEM;
goto err_vdev_alloc;
}
if (mode == MXC_JPEG_ENCODE)
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH -next] media: imx-jpeg: Fix error return code in mxc_jpeg_probe()
@ 2021-03-23 11:28 ` 'w00385741
0 siblings, 0 replies; 4+ messages in thread
From: 'w00385741 @ 2021-03-23 11:28 UTC (permalink / raw)
To: weiyongjun1, Mirela Rabulea, Mauro Carvalho Chehab, Shawn Guo,
Sascha Hauer
Cc: linux-media, linux-arm-kernel, kernel-janitors, Hulk Robot
From: Wei Yongjun <weiyongjun1@huawei.com>
Fix to return negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 2db16c6ed72c ("media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/media/platform/imx-jpeg/mxc-jpeg.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/imx-jpeg/mxc-jpeg.c
index 2d29558f1864..70b9b61fbf88 100644
--- a/drivers/media/platform/imx-jpeg/mxc-jpeg.c
+++ b/drivers/media/platform/imx-jpeg/mxc-jpeg.c
@@ -2022,12 +2022,14 @@ static int mxc_jpeg_probe(struct platform_device *pdev)
jpeg->m2m_dev = v4l2_m2m_init(&mxc_jpeg_m2m_ops);
if (IS_ERR(jpeg->m2m_dev)) {
dev_err(dev, "failed to register v4l2 device\n");
+ ret = PTR_ERR(jpeg->m2m_dev);
goto err_m2m;
}
jpeg->dec_vdev = video_device_alloc();
if (!jpeg->dec_vdev) {
dev_err(dev, "failed to register v4l2 device\n");
+ ret = -ENOMEM;
goto err_vdev_alloc;
}
if (mode == MXC_JPEG_ENCODE)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] media: imx-jpeg: Fix error return code in mxc_jpeg_probe()
2021-03-23 11:28 ` 'w00385741
@ 2021-03-27 14:36 ` Mirela Rabulea
-1 siblings, 0 replies; 4+ messages in thread
From: Mirela Rabulea @ 2021-03-27 14:36 UTC (permalink / raw)
To: s.hauer, mchehab, shawnguo, weiyongjun1
Cc: linux-arm-kernel, linux-media, hulkci, kernel-janitors
Hi,
On Tue, 2021-03-23 at 11:28 +0000, 'w00385741 wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 2db16c6ed72c ("media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG
> Encoder/Decoder")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/media/platform/imx-jpeg/mxc-jpeg.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/imx-jpeg/mxc-jpeg.c
> b/drivers/media/platform/imx-jpeg/mxc-jpeg.c
> index 2d29558f1864..70b9b61fbf88 100644
> --- a/drivers/media/platform/imx-jpeg/mxc-jpeg.c
> +++ b/drivers/media/platform/imx-jpeg/mxc-jpeg.c
> @@ -2022,12 +2022,14 @@ static int mxc_jpeg_probe(struct
> platform_device *pdev)
> jpeg->m2m_dev = v4l2_m2m_init(&mxc_jpeg_m2m_ops);
> if (IS_ERR(jpeg->m2m_dev)) {
> dev_err(dev, "failed to register v4l2 device\n");
> + ret = PTR_ERR(jpeg->m2m_dev);
> goto err_m2m;
> }
>
> jpeg->dec_vdev = video_device_alloc();
> if (!jpeg->dec_vdev) {
> dev_err(dev, "failed to register v4l2 device\n");
> + ret = -ENOMEM;
> goto err_vdev_alloc;
> }
> if (mode == MXC_JPEG_ENCODE)
>
Thanks for the patch.
Reviewed-by: Mirela Rabulea <mirela.rabulea@nxp.com>
Regards,
Mirela
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] media: imx-jpeg: Fix error return code in mxc_jpeg_probe()
@ 2021-03-27 14:36 ` Mirela Rabulea
0 siblings, 0 replies; 4+ messages in thread
From: Mirela Rabulea @ 2021-03-27 14:36 UTC (permalink / raw)
To: s.hauer, mchehab, shawnguo, weiyongjun1
Cc: linux-arm-kernel, linux-media, hulkci, kernel-janitors
Hi,
On Tue, 2021-03-23 at 11:28 +0000, 'w00385741 wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 2db16c6ed72c ("media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG
> Encoder/Decoder")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/media/platform/imx-jpeg/mxc-jpeg.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/imx-jpeg/mxc-jpeg.c
> b/drivers/media/platform/imx-jpeg/mxc-jpeg.c
> index 2d29558f1864..70b9b61fbf88 100644
> --- a/drivers/media/platform/imx-jpeg/mxc-jpeg.c
> +++ b/drivers/media/platform/imx-jpeg/mxc-jpeg.c
> @@ -2022,12 +2022,14 @@ static int mxc_jpeg_probe(struct
> platform_device *pdev)
> jpeg->m2m_dev = v4l2_m2m_init(&mxc_jpeg_m2m_ops);
> if (IS_ERR(jpeg->m2m_dev)) {
> dev_err(dev, "failed to register v4l2 device\n");
> + ret = PTR_ERR(jpeg->m2m_dev);
> goto err_m2m;
> }
>
> jpeg->dec_vdev = video_device_alloc();
> if (!jpeg->dec_vdev) {
> dev_err(dev, "failed to register v4l2 device\n");
> + ret = -ENOMEM;
> goto err_vdev_alloc;
> }
> if (mode == MXC_JPEG_ENCODE)
>
Thanks for the patch.
Reviewed-by: Mirela Rabulea <mirela.rabulea@nxp.com>
Regards,
Mirela
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-27 14:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 11:28 [PATCH -next] media: imx-jpeg: Fix error return code in mxc_jpeg_probe() 'w00385741
2021-03-23 11:28 ` 'w00385741
2021-03-27 14:36 ` Mirela Rabulea
2021-03-27 14:36 ` Mirela Rabulea
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.