All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: Adam Ford <aford173@gmail.com>, linux-arm-kernel@lists.infradead.org
Cc: aford@beaconembedded.com, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] soc: imx: imx8m-blk-ctrl: Fix IMX8MN_DISPBLK_PD_ISI hang
Date: Mon, 21 Mar 2022 11:58:15 +0100	[thread overview]
Message-ID: <73570ee11ddbbda96463e8fad3ad533c83716782.camel@pengutronix.de> (raw)
In-Reply-To: <20220320205212.701548-1-aford173@gmail.com>

Am Sonntag, dem 20.03.2022 um 15:52 -0500 schrieb Adam Ford:
> The imx8mn clock list for the ISI lists four clocks, but DOMAIN_MAX_CLKS
> was set to 3.  Because of this, attempts to enable the fourth clock failed,
> threw some splat, and ultimately hung.
> 
> Fixes: 7f511d514e8c ("soc: imx: imx8m-blk-ctrl: add i.MX8MN DISP blk-ctrl")
> Signed-off-by: Adam Ford <aford173@gmail.com>

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> 
> diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c
> index a0a0d2d7ca4a..7109f0d508e2 100644
> --- a/drivers/soc/imx/imx8m-blk-ctrl.c
> +++ b/drivers/soc/imx/imx8m-blk-ctrl.c
> @@ -50,7 +50,7 @@ struct imx8m_blk_ctrl_domain_data {
>  	u32 mipi_phy_rst_mask;
>  };
>  
> -#define DOMAIN_MAX_CLKS 3
> +#define DOMAIN_MAX_CLKS 4
>  
>  struct imx8m_blk_ctrl_domain {
>  	struct generic_pm_domain genpd;



WARNING: multiple messages have this Message-ID (diff)
From: Lucas Stach <l.stach@pengutronix.de>
To: Adam Ford <aford173@gmail.com>, linux-arm-kernel@lists.infradead.org
Cc: aford@beaconembedded.com, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	 Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] soc: imx: imx8m-blk-ctrl: Fix IMX8MN_DISPBLK_PD_ISI hang
Date: Mon, 21 Mar 2022 11:58:15 +0100	[thread overview]
Message-ID: <73570ee11ddbbda96463e8fad3ad533c83716782.camel@pengutronix.de> (raw)
In-Reply-To: <20220320205212.701548-1-aford173@gmail.com>

Am Sonntag, dem 20.03.2022 um 15:52 -0500 schrieb Adam Ford:
> The imx8mn clock list for the ISI lists four clocks, but DOMAIN_MAX_CLKS
> was set to 3.  Because of this, attempts to enable the fourth clock failed,
> threw some splat, and ultimately hung.
> 
> Fixes: 7f511d514e8c ("soc: imx: imx8m-blk-ctrl: add i.MX8MN DISP blk-ctrl")
> Signed-off-by: Adam Ford <aford173@gmail.com>

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> 
> diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c
> index a0a0d2d7ca4a..7109f0d508e2 100644
> --- a/drivers/soc/imx/imx8m-blk-ctrl.c
> +++ b/drivers/soc/imx/imx8m-blk-ctrl.c
> @@ -50,7 +50,7 @@ struct imx8m_blk_ctrl_domain_data {
>  	u32 mipi_phy_rst_mask;
>  };
>  
> -#define DOMAIN_MAX_CLKS 3
> +#define DOMAIN_MAX_CLKS 4
>  
>  struct imx8m_blk_ctrl_domain {
>  	struct generic_pm_domain genpd;



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-03-21 10:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-20 20:52 [PATCH V2] soc: imx: imx8m-blk-ctrl: Fix IMX8MN_DISPBLK_PD_ISI hang Adam Ford
2022-03-20 20:52 ` Adam Ford
2022-03-21 10:58 ` Lucas Stach [this message]
2022-03-21 10:58   ` Lucas Stach
2022-04-10  1:32 ` Shawn Guo
2022-04-10  1:32   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73570ee11ddbbda96463e8fad3ad533c83716782.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=aford173@gmail.com \
    --cc=aford@beaconembedded.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.