[PATCH 1/2] libpeas: this depends on gtk3+ add FEATURE CHECK

[PATCH 1/2] libpeas: this depends on gtk3+ add FEATURE CHECK

[akuster]

This has a dependancy on GTK3DISTROFEATURES so add the check

ERROR: Nothing PROVIDES 'gtk+3' (but /.../meta-openembedded/meta-oe/recipes-gnome/libpeas/libpeas_1.25.3.bb, /.../poky/meta/recipes-gnome/gnome/adwaita-icon-theme_3.36.1.bb DEPENDS on or otherwise requires it)
gtk+3 was skipped: one of 'wayland x11' needs to be in DISTRO_FEATURES

Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
 meta-oe/recipes-gnome/libpeas/libpeas_1.25.3.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-gnome/libpeas/libpeas_1.25.3.bb b/meta-oe/recipes-gnome/libpeas/libpeas_1.25.3.bb
index 57419a4275..78314007e3 100644
--- a/meta-oe/recipes-gnome/libpeas/libpeas_1.25.3.bb
+++ b/meta-oe/recipes-gnome/libpeas/libpeas_1.25.3.bb
@@ -8,7 +8,9 @@ DEPENDS = "gtk+3"
 GNOMEBASEBUILDCLASS = "meson"
 GTKDOC_MESON_OPTION = "gtk_doc"
 
-inherit gnomebase gobject-introspection gtk-doc gtk-icon-cache
+inherit gnomebase gobject-introspection gtk-doc gtk-icon-cache features_check
+
+ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
 
 SRC_URI[archive.md5sum] = "08bfff8f9688cf630dcb0f950617661f"
 SRC_URI[archive.sha256sum] = "1c9bbb29740c29cd6e1dd0c9964722ff08cd5e6f68f1b5c135bc391a6ce97639"
-- 
2.17.1

[PATCH 2/2] khronos: includes virtual/libgles2 , needs opengl

[akuster]

add FEATURE_CHECK on opengl.

Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
 meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc b/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
index bd75cdb1f4..1cd0a476aa 100644
--- a/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
+++ b/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
@@ -16,7 +16,9 @@ SRCREV_FORMAT = "vk-gl-cts"
 
 S = "${WORKDIR}/git"
 
-inherit pkgconfig cmake
+inherit pkgconfig cmake features_check
+
+REQUIRED_DISTRO_FEATURES = "opengl"
 
 DEPENDS += "libpng zlib virtual/libgles2 virtual/egl"
 
-- 
2.17.1

Re: [oe] [PATCH 2/2] khronos: includes virtual/libgles2 , needs opengl

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]

Hi,

I've already sent this one:
https://lists.openembedded.org/g/openembedded-devel/message/85932

On Sun, Jul 26, 2020 at 11:22 AM akuster <akuster808@gmail.com> wrote:

> add FEATURE_CHECK on opengl.
>
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
>  meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
> b/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
> index bd75cdb1f4..1cd0a476aa 100644
> --- a/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
> +++ b/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
> @@ -16,7 +16,9 @@ SRCREV_FORMAT = "vk-gl-cts"
>
>  S = "${WORKDIR}/git"
>
> -inherit pkgconfig cmake
> +inherit pkgconfig cmake features_check
> +
> +REQUIRED_DISTRO_FEATURES = "opengl"
>
>  DEPENDS += "libpng zlib virtual/libgles2 virtual/egl"
>
> --
> 2.17.1
>
> 
>

[-- Attachment #2: Type: text/html, Size: 1522 bytes --]

Re: [oe] [PATCH 2/2] khronos: includes virtual/libgles2 , needs opengl

[akuster]

[-- Attachment #1: Type: text/plain, Size: 1344 bytes --]



On 7/26/20 9:42 PM, Martin Jansa wrote:
> Hi,
>
> I've already sent this one:
> https://lists.openembedded.org/g/openembedded-devel/message/85932 

Cool. it was faster to fix it than look search the mailing list for a fix.

it ended up being a ping in the end

looks like its in the testing queue.

- armin
>
> On Sun, Jul 26, 2020 at 11:22 AM akuster <akuster808@gmail.com
> <mailto:akuster808@gmail.com>> wrote:
>
>     add FEATURE_CHECK on opengl.
>
>     Signed-off-by: Armin Kuster <akuster808@gmail.com
>     <mailto:akuster808@gmail.com>>
>     ---
>      meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc | 4 +++-
>      1 file changed, 3 insertions(+), 1 deletion(-)
>
>     diff --git a/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
>     b/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
>     index bd75cdb1f4..1cd0a476aa 100644
>     --- a/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
>     +++ b/meta-oe/recipes-graphics/vk-gl-cts/khronos-cts.inc
>     @@ -16,7 +16,9 @@ SRCREV_FORMAT = "vk-gl-cts"
>
>      S = "${WORKDIR}/git"
>
>     -inherit pkgconfig cmake
>     +inherit pkgconfig cmake features_check
>     +
>     +REQUIRED_DISTRO_FEATURES = "opengl"
>
>      DEPENDS += "libpng zlib virtual/libgles2 virtual/egl"
>
>     -- 
>     2.17.1
>
>     
>


[-- Attachment #2: Type: text/html, Size: 2866 bytes --]