* [PATCH] char: ipmi: constify bmc_dev_attr_group and bmc_device_type
@ 2017-06-23 5:13 Arvind Yadav
2017-06-29 1:55 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-06-23 5:13 UTC (permalink / raw)
To: minyard; +Cc: openipmi-developer, linux-kernel
File size before:
text data bss dec hex filename
25678 1024 92 26794 68aa drivers/char/ipmi/ipmi_msghandler.o
File size After adding 'const':
text data bss dec hex filename
25806 896 92 26794 68aa drivers/char/ipmi/ipmi_msghandler.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/char/ipmi/ipmi_msghandler.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index 9f69995..d60c05c 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -2397,7 +2397,7 @@ static umode_t bmc_dev_attr_is_visible(struct kobject *kobj,
return mode;
}
-static struct attribute_group bmc_dev_attr_group = {
+static const struct attribute_group bmc_dev_attr_group = {
.attrs = bmc_dev_attrs,
.is_visible = bmc_dev_attr_is_visible,
};
@@ -2407,7 +2407,7 @@ static umode_t bmc_dev_attr_is_visible(struct kobject *kobj,
NULL
};
-static struct device_type bmc_device_type = {
+static const struct device_type bmc_device_type = {
.groups = bmc_dev_attr_groups,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] char: ipmi: constify bmc_dev_attr_group and bmc_device_type
2017-06-23 5:13 [PATCH] char: ipmi: constify bmc_dev_attr_group and bmc_device_type Arvind Yadav
@ 2017-06-29 1:55 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2017-06-29 1:55 UTC (permalink / raw)
To: Arvind Yadav; +Cc: openipmi-developer, linux-kernel
Applied, thanks.
-corey
On 06/23/2017 12:13 AM, Arvind Yadav wrote:
> File size before:
> text data bss dec hex filename
> 25678 1024 92 26794 68aa drivers/char/ipmi/ipmi_msghandler.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 25806 896 92 26794 68aa drivers/char/ipmi/ipmi_msghandler.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/char/ipmi/ipmi_msghandler.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index 9f69995..d60c05c 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -2397,7 +2397,7 @@ static umode_t bmc_dev_attr_is_visible(struct kobject *kobj,
> return mode;
> }
>
> -static struct attribute_group bmc_dev_attr_group = {
> +static const struct attribute_group bmc_dev_attr_group = {
> .attrs = bmc_dev_attrs,
> .is_visible = bmc_dev_attr_is_visible,
> };
> @@ -2407,7 +2407,7 @@ static umode_t bmc_dev_attr_is_visible(struct kobject *kobj,
> NULL
> };
>
> -static struct device_type bmc_device_type = {
> +static const struct device_type bmc_device_type = {
> .groups = bmc_dev_attr_groups,
> };
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-29 1:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-23 5:13 [PATCH] char: ipmi: constify bmc_dev_attr_group and bmc_device_type Arvind Yadav
2017-06-29 1:55 ` Corey Minyard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.