* [PATCH] overlayfs: include linux/pagemap.h for PAGE_CACHE_SIZE
@ 2015-12-10 15:10 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2015-12-10 15:10 UTC (permalink / raw)
To: Miklos Szeredi; +Cc: linux-unionfs, linux-kernel, linux-arm-kernel
The overlayfs has started enforcing a maximum file size, but is missing
the header file that defines the PAGE_CACHE_SIZE constant in some
configurations.
fs/overlayfs/super.c: In function 'ovl_fill_super':
fs/overlayfs/super.c:939:29: error: 'PAGE_CACHE_SIZE' undeclared (first use in this function)
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 7b1746cac878 ("ovl: setattr: check permissions before copy-up")
Cc: <stable@vger.kernel.org>
---
The patch that introduced this was marked for stable, so I'm marking this
the same way.
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index ea94e50a3473..a4cbdf9824c7 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -9,6 +9,7 @@
#include <linux/fs.h>
#include <linux/namei.h>
+#include <linux/pagemap.h>
#include <linux/xattr.h>
#include <linux/security.h>
#include <linux/mount.h>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] overlayfs: include linux/pagemap.h for PAGE_CACHE_SIZE
@ 2015-12-10 15:10 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2015-12-10 15:10 UTC (permalink / raw)
To: linux-arm-kernel
The overlayfs has started enforcing a maximum file size, but is missing
the header file that defines the PAGE_CACHE_SIZE constant in some
configurations.
fs/overlayfs/super.c: In function 'ovl_fill_super':
fs/overlayfs/super.c:939:29: error: 'PAGE_CACHE_SIZE' undeclared (first use in this function)
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 7b1746cac878 ("ovl: setattr: check permissions before copy-up")
Cc: <stable@vger.kernel.org>
---
The patch that introduced this was marked for stable, so I'm marking this
the same way.
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index ea94e50a3473..a4cbdf9824c7 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -9,6 +9,7 @@
#include <linux/fs.h>
#include <linux/namei.h>
+#include <linux/pagemap.h>
#include <linux/xattr.h>
#include <linux/security.h>
#include <linux/mount.h>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] overlayfs: include linux/pagemap.h for PAGE_CACHE_SIZE
2015-12-10 15:10 ` Arnd Bergmann
@ 2015-12-10 15:26 ` Miklos Szeredi
-1 siblings, 0 replies; 4+ messages in thread
From: Miklos Szeredi @ 2015-12-10 15:26 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: linux-unionfs, Kernel Mailing List, linux-arm-kernel
On Thu, Dec 10, 2015 at 4:10 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The overlayfs has started enforcing a maximum file size, but is missing
> the header file that defines the PAGE_CACHE_SIZE constant in some
> configurations.
Hmm, it uses MAX_LFS_FILESIZE. MAX_LFS_FILESIZE is defined in
<linux/fs.h>, which doesn't include <linux/pagemap.h>.
<linux/pagemap.h> includes <linux/fs.h> however. So shouldn't
MAX_LFS_FILESIZE be defined in <linux/pagemap.h> instead?
Thanks,
Miklos
>
> fs/overlayfs/super.c: In function 'ovl_fill_super':
> fs/overlayfs/super.c:939:29: error: 'PAGE_CACHE_SIZE' undeclared (first use in this function)
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7b1746cac878 ("ovl: setattr: check permissions before copy-up")
> Cc: <stable@vger.kernel.org>
> ---
> The patch that introduced this was marked for stable, so I'm marking this
> the same way.
>
> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
> index ea94e50a3473..a4cbdf9824c7 100644
> --- a/fs/overlayfs/super.c
> +++ b/fs/overlayfs/super.c
> @@ -9,6 +9,7 @@
>
> #include <linux/fs.h>
> #include <linux/namei.h>
> +#include <linux/pagemap.h>
> #include <linux/xattr.h>
> #include <linux/security.h>
> #include <linux/mount.h>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] overlayfs: include linux/pagemap.h for PAGE_CACHE_SIZE
@ 2015-12-10 15:26 ` Miklos Szeredi
0 siblings, 0 replies; 4+ messages in thread
From: Miklos Szeredi @ 2015-12-10 15:26 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 10, 2015 at 4:10 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The overlayfs has started enforcing a maximum file size, but is missing
> the header file that defines the PAGE_CACHE_SIZE constant in some
> configurations.
Hmm, it uses MAX_LFS_FILESIZE. MAX_LFS_FILESIZE is defined in
<linux/fs.h>, which doesn't include <linux/pagemap.h>.
<linux/pagemap.h> includes <linux/fs.h> however. So shouldn't
MAX_LFS_FILESIZE be defined in <linux/pagemap.h> instead?
Thanks,
Miklos
>
> fs/overlayfs/super.c: In function 'ovl_fill_super':
> fs/overlayfs/super.c:939:29: error: 'PAGE_CACHE_SIZE' undeclared (first use in this function)
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7b1746cac878 ("ovl: setattr: check permissions before copy-up")
> Cc: <stable@vger.kernel.org>
> ---
> The patch that introduced this was marked for stable, so I'm marking this
> the same way.
>
> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
> index ea94e50a3473..a4cbdf9824c7 100644
> --- a/fs/overlayfs/super.c
> +++ b/fs/overlayfs/super.c
> @@ -9,6 +9,7 @@
>
> #include <linux/fs.h>
> #include <linux/namei.h>
> +#include <linux/pagemap.h>
> #include <linux/xattr.h>
> #include <linux/security.h>
> #include <linux/mount.h>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-10 15:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-10 15:10 [PATCH] overlayfs: include linux/pagemap.h for PAGE_CACHE_SIZE Arnd Bergmann
2015-12-10 15:10 ` Arnd Bergmann
2015-12-10 15:26 ` Miklos Szeredi
2015-12-10 15:26 ` Miklos Szeredi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.