* [PATCH v1 1/1] usb: typec: wcove: Drop wrong dependency to INTEL_SOC_PMIC
@ 2022-06-20 10:43 Andy Shevchenko
2022-06-20 13:25 ` Guenter Roeck
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andy Shevchenko @ 2022-06-20 10:43 UTC (permalink / raw)
To: Andy Shevchenko, linux-usb, linux-kernel
Cc: Guenter Roeck, Heikki Krogerus, Greg Kroah-Hartman, Hans de Goede
Intel SoC PMIC is a generic name for all PMICs that are used
on Intel platforms. In particular, INTEL_SOC_PMIC kernel configuration
option refers to Crystal Cove PMIC, which has never been a part
of any Intel Broxton hardware. Drop wrong dependency from Kconfig.
Note, the correct dependency is satisfied via ACPI PMIC OpRegion driver,
which the Type-C depends on.
Fixes: d2061f9cc32d ("usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY")
Reported-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/usb/typec/tcpm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig
index 557f392fe24d..073fd2ea5e0b 100644
--- a/drivers/usb/typec/tcpm/Kconfig
+++ b/drivers/usb/typec/tcpm/Kconfig
@@ -56,7 +56,6 @@ config TYPEC_WCOVE
tristate "Intel WhiskeyCove PMIC USB Type-C PHY driver"
depends on ACPI
depends on MFD_INTEL_PMC_BXT
- depends on INTEL_SOC_PMIC
depends on BXT_WC_PMIC_OPREGION
help
This driver adds support for USB Type-C on Intel Broxton platforms
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] usb: typec: wcove: Drop wrong dependency to INTEL_SOC_PMIC
2022-06-20 10:43 [PATCH v1 1/1] usb: typec: wcove: Drop wrong dependency to INTEL_SOC_PMIC Andy Shevchenko
@ 2022-06-20 13:25 ` Guenter Roeck
2022-06-20 14:35 ` Hans de Goede
2022-06-21 6:59 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2022-06-20 13:25 UTC (permalink / raw)
To: Andy Shevchenko, linux-usb, linux-kernel
Cc: Heikki Krogerus, Greg Kroah-Hartman, Hans de Goede
On 6/20/22 03:43, Andy Shevchenko wrote:
> Intel SoC PMIC is a generic name for all PMICs that are used
> on Intel platforms. In particular, INTEL_SOC_PMIC kernel configuration
> option refers to Crystal Cove PMIC, which has never been a part
> of any Intel Broxton hardware. Drop wrong dependency from Kconfig.
>
> Note, the correct dependency is satisfied via ACPI PMIC OpRegion driver,
> which the Type-C depends on.
>
> Fixes: d2061f9cc32d ("usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY")
> Reported-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/usb/typec/tcpm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig
> index 557f392fe24d..073fd2ea5e0b 100644
> --- a/drivers/usb/typec/tcpm/Kconfig
> +++ b/drivers/usb/typec/tcpm/Kconfig
> @@ -56,7 +56,6 @@ config TYPEC_WCOVE
> tristate "Intel WhiskeyCove PMIC USB Type-C PHY driver"
> depends on ACPI
> depends on MFD_INTEL_PMC_BXT
> - depends on INTEL_SOC_PMIC
> depends on BXT_WC_PMIC_OPREGION
> help
> This driver adds support for USB Type-C on Intel Broxton platforms
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] usb: typec: wcove: Drop wrong dependency to INTEL_SOC_PMIC
2022-06-20 10:43 [PATCH v1 1/1] usb: typec: wcove: Drop wrong dependency to INTEL_SOC_PMIC Andy Shevchenko
2022-06-20 13:25 ` Guenter Roeck
@ 2022-06-20 14:35 ` Hans de Goede
2022-06-21 6:59 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2022-06-20 14:35 UTC (permalink / raw)
To: Andy Shevchenko, linux-usb, linux-kernel
Cc: Guenter Roeck, Heikki Krogerus, Greg Kroah-Hartman
Hi,
On 6/20/22 12:43, Andy Shevchenko wrote:
> Intel SoC PMIC is a generic name for all PMICs that are used
> on Intel platforms. In particular, INTEL_SOC_PMIC kernel configuration
> option refers to Crystal Cove PMIC, which has never been a part
> of any Intel Broxton hardware. Drop wrong dependency from Kconfig.
>
> Note, the correct dependency is satisfied via ACPI PMIC OpRegion driver,
> which the Type-C depends on.
>
> Fixes: d2061f9cc32d ("usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY")
> Reported-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/usb/typec/tcpm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig
> index 557f392fe24d..073fd2ea5e0b 100644
> --- a/drivers/usb/typec/tcpm/Kconfig
> +++ b/drivers/usb/typec/tcpm/Kconfig
> @@ -56,7 +56,6 @@ config TYPEC_WCOVE
> tristate "Intel WhiskeyCove PMIC USB Type-C PHY driver"
> depends on ACPI
> depends on MFD_INTEL_PMC_BXT
> - depends on INTEL_SOC_PMIC
> depends on BXT_WC_PMIC_OPREGION
> help
> This driver adds support for USB Type-C on Intel Broxton platforms
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] usb: typec: wcove: Drop wrong dependency to INTEL_SOC_PMIC
2022-06-20 10:43 [PATCH v1 1/1] usb: typec: wcove: Drop wrong dependency to INTEL_SOC_PMIC Andy Shevchenko
2022-06-20 13:25 ` Guenter Roeck
2022-06-20 14:35 ` Hans de Goede
@ 2022-06-21 6:59 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Heikki Krogerus @ 2022-06-21 6:59 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-usb, linux-kernel, Guenter Roeck, Greg Kroah-Hartman,
Hans de Goede
On Mon, Jun 20, 2022 at 01:43:16PM +0300, Andy Shevchenko wrote:
> Intel SoC PMIC is a generic name for all PMICs that are used
> on Intel platforms. In particular, INTEL_SOC_PMIC kernel configuration
> option refers to Crystal Cove PMIC, which has never been a part
> of any Intel Broxton hardware. Drop wrong dependency from Kconfig.
>
> Note, the correct dependency is satisfied via ACPI PMIC OpRegion driver,
> which the Type-C depends on.
>
> Fixes: d2061f9cc32d ("usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY")
> Reported-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig
> index 557f392fe24d..073fd2ea5e0b 100644
> --- a/drivers/usb/typec/tcpm/Kconfig
> +++ b/drivers/usb/typec/tcpm/Kconfig
> @@ -56,7 +56,6 @@ config TYPEC_WCOVE
> tristate "Intel WhiskeyCove PMIC USB Type-C PHY driver"
> depends on ACPI
> depends on MFD_INTEL_PMC_BXT
> - depends on INTEL_SOC_PMIC
> depends on BXT_WC_PMIC_OPREGION
> help
> This driver adds support for USB Type-C on Intel Broxton platforms
> --
> 2.35.1
--
heikki
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-21 6:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-20 10:43 [PATCH v1 1/1] usb: typec: wcove: Drop wrong dependency to INTEL_SOC_PMIC Andy Shevchenko
2022-06-20 13:25 ` Guenter Roeck
2022-06-20 14:35 ` Hans de Goede
2022-06-21 6:59 ` Heikki Krogerus
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.