* [PATCH BlueZ] mesh: Add missing property interface to node objects
@ 2019-11-12 10:43 Michał Lowas-Rzechonek
2019-11-13 17:16 ` Gix, Brian
0 siblings, 1 reply; 3+ messages in thread
From: Michał Lowas-Rzechonek @ 2019-11-12 10:43 UTC (permalink / raw)
To: linux-bluetooth
---
mesh/node.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/mesh/node.c b/mesh/node.c
index e23f32dd1..d2dff3a51 100644
--- a/mesh/node.c
+++ b/mesh/node.c
@@ -294,6 +294,10 @@ static void free_node_dbus_resources(struct mesh_node *node)
l_dbus_object_remove_interface(dbus_get_bus(), node->obj_path,
MESH_MANAGEMENT_INTERFACE);
+
+ l_dbus_object_remove_interface(dbus_get_bus(), node->obj_path,
+ L_DBUS_INTERFACE_PROPERTIES);
+
l_free(node->obj_path);
node->obj_path = NULL;
}
@@ -1156,6 +1160,10 @@ static bool register_node_object(struct mesh_node *node)
MESH_MANAGEMENT_INTERFACE, node))
return false;
+ if (!l_dbus_object_add_interface(dbus_get_bus(), node->obj_path,
+ L_DBUS_INTERFACE_PROPERTIES, NULL))
+ return false;
+
return true;
}
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH BlueZ] mesh: Add missing property interface to node objects
2019-11-12 10:43 [PATCH BlueZ] mesh: Add missing property interface to node objects Michał Lowas-Rzechonek
@ 2019-11-13 17:16 ` Gix, Brian
2019-11-13 19:58 ` michal.lowas-rzechonek
0 siblings, 1 reply; 3+ messages in thread
From: Gix, Brian @ 2019-11-13 17:16 UTC (permalink / raw)
To: michal.lowas-rzechonek, linux-bluetooth
Applied with style-guide corrections:
Reduce max line length to <80 charactors
On Tue, 2019-11-12 at 11:43 +0100, Michał Lowas-Rzechonek wrote:
> ---
> mesh/node.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/mesh/node.c b/mesh/node.c
> index e23f32dd1..d2dff3a51 100644
> --- a/mesh/node.c
> +++ b/mesh/node.c
> @@ -294,6 +294,10 @@ static void free_node_dbus_resources(struct mesh_node *node)
>
> l_dbus_object_remove_interface(dbus_get_bus(), node->obj_path,
> MESH_MANAGEMENT_INTERFACE);
> +
> + l_dbus_object_remove_interface(dbus_get_bus(), node->obj_path,
> + L_DBUS_INTERFACE_PROPERTIES);
> +
> l_free(node->obj_path);
> node->obj_path = NULL;
> }
> @@ -1156,6 +1160,10 @@ static bool register_node_object(struct mesh_node *node)
> MESH_MANAGEMENT_INTERFACE, node))
> return false;
>
> + if (!l_dbus_object_add_interface(dbus_get_bus(), node->obj_path,
> + L_DBUS_INTERFACE_PROPERTIES, NULL))
> + return false;
> +
> return true;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH BlueZ] mesh: Add missing property interface to node objects
2019-11-13 17:16 ` Gix, Brian
@ 2019-11-13 19:58 ` michal.lowas-rzechonek
0 siblings, 0 replies; 3+ messages in thread
From: michal.lowas-rzechonek @ 2019-11-13 19:58 UTC (permalink / raw)
To: Gix, Brian; +Cc: linux-bluetooth
On 11/13, Gix, Brian wrote:
> Applied with style-guide corrections:
> Reduce max line length to <80 charactors
Thanks, and sorry about the formatting.
--
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-13 19:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-12 10:43 [PATCH BlueZ] mesh: Add missing property interface to node objects Michał Lowas-Rzechonek
2019-11-13 17:16 ` Gix, Brian
2019-11-13 19:58 ` michal.lowas-rzechonek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.