From: Wei Ni <wni@nvidia.com> To: Rob Herring <robh@kernel.org> Cc: thierry.reding@gmail.com, daniel.lezcano@linaro.org, edubezval@gmail.com, linux-tegra@vger.kernel.org, rui.zhang@intel.com, srikars@nvidia.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v1 04/12] of: Add bindings of gpu hw throttle for Tegra soctherm Date: Tue, 19 Feb 2019 14:34:49 +0800 [thread overview] Message-ID: <739a8c81-ee0a-999e-0508-6aa1fba768b7@nvidia.com> (raw) In-Reply-To: <20190218203314.GB12911@bogus> On 19/2/2019 4:33 AM, Rob Herring wrote: > On Tue, Dec 18, 2018 at 03:34:36PM +0800, Wei Ni wrote: >> Add "nvidia,gpu-throt-level" property to set gpu hw >> throttle level. >> >> Signed-off-by: Wei Ni <wni@nvidia.com> >> --- >> .../bindings/thermal/nvidia,tegra124-soctherm.txt | 17 +++++++++++++++-- >> include/dt-bindings/thermal/tegra124-soctherm.h | 22 ++++++++++++++++++---- >> 2 files changed, 33 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/thermal/nvidia,tegra124-soctherm.txt b/Documentation/devicetree/bindings/thermal/nvidia,tegra124-soctherm.txt >> index ab66d6feab4b..cf6d0be56b7a 100644 >> --- a/Documentation/devicetree/bindings/thermal/nvidia,tegra124-soctherm.txt >> +++ b/Documentation/devicetree/bindings/thermal/nvidia,tegra124-soctherm.txt >> @@ -52,6 +52,15 @@ Required properties : >> Must set as following values: >> TEGRA_SOCTHERM_THROT_LEVEL_LOW, TEGRA_SOCTHERM_THROT_LEVEL_MED >> TEGRA_SOCTHERM_THROT_LEVEL_HIGH, TEGRA_SOCTHERM_THROT_LEVEL_NONE >> + - nvidia,gpu-throt-level: This property is for Tegra124 and Tegra210. > > Also, why not just use percents like nvidia,cpu-throt-percent? Hi Rob, We have to use "-level" for gpu throttle, can't use percents. It's designed by hardware. BTW, for the cpu-throt, it use "-level" for t132, and use "-percent" for t124 and t210. Thanks. Wei. > >> + It is the level of pulse skippers, which used to throttle clock >> + frequencies. It indicates gpu clock throttling depth and can be >> + programmed to any of the following values which represent a throttling >> + percentage: >> + TEGRA_SOCTHERM_THROT_LEVEL_NONE (0%) >> + TEGRA_SOCTHERM_THROT_LEVEL_LOW (50%), >> + TEGRA_SOCTHERM_THROT_LEVEL_MED (75%), >> + TEGRA_SOCTHERM_THROT_LEVEL_HIGH (85%). >> - #cooling-cells: Should be 1. This cooling device only support on/off state. >> See ./thermal.txt for a description of this property.
WARNING: multiple messages have this Message-ID (diff)
From: Wei Ni <wni@nvidia.com> To: Rob Herring <robh@kernel.org> Cc: <thierry.reding@gmail.com>, <daniel.lezcano@linaro.org>, <edubezval@gmail.com>, <linux-tegra@vger.kernel.org>, <rui.zhang@intel.com>, <srikars@nvidia.com>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org> Subject: Re: [PATCH v1 04/12] of: Add bindings of gpu hw throttle for Tegra soctherm Date: Tue, 19 Feb 2019 14:34:49 +0800 [thread overview] Message-ID: <739a8c81-ee0a-999e-0508-6aa1fba768b7@nvidia.com> (raw) In-Reply-To: <20190218203314.GB12911@bogus> On 19/2/2019 4:33 AM, Rob Herring wrote: > On Tue, Dec 18, 2018 at 03:34:36PM +0800, Wei Ni wrote: >> Add "nvidia,gpu-throt-level" property to set gpu hw >> throttle level. >> >> Signed-off-by: Wei Ni <wni@nvidia.com> >> --- >> .../bindings/thermal/nvidia,tegra124-soctherm.txt | 17 +++++++++++++++-- >> include/dt-bindings/thermal/tegra124-soctherm.h | 22 ++++++++++++++++++---- >> 2 files changed, 33 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/thermal/nvidia,tegra124-soctherm.txt b/Documentation/devicetree/bindings/thermal/nvidia,tegra124-soctherm.txt >> index ab66d6feab4b..cf6d0be56b7a 100644 >> --- a/Documentation/devicetree/bindings/thermal/nvidia,tegra124-soctherm.txt >> +++ b/Documentation/devicetree/bindings/thermal/nvidia,tegra124-soctherm.txt >> @@ -52,6 +52,15 @@ Required properties : >> Must set as following values: >> TEGRA_SOCTHERM_THROT_LEVEL_LOW, TEGRA_SOCTHERM_THROT_LEVEL_MED >> TEGRA_SOCTHERM_THROT_LEVEL_HIGH, TEGRA_SOCTHERM_THROT_LEVEL_NONE >> + - nvidia,gpu-throt-level: This property is for Tegra124 and Tegra210. > > Also, why not just use percents like nvidia,cpu-throt-percent? Hi Rob, We have to use "-level" for gpu throttle, can't use percents. It's designed by hardware. BTW, for the cpu-throt, it use "-level" for t132, and use "-percent" for t124 and t210. Thanks. Wei. > >> + It is the level of pulse skippers, which used to throttle clock >> + frequencies. It indicates gpu clock throttling depth and can be >> + programmed to any of the following values which represent a throttling >> + percentage: >> + TEGRA_SOCTHERM_THROT_LEVEL_NONE (0%) >> + TEGRA_SOCTHERM_THROT_LEVEL_LOW (50%), >> + TEGRA_SOCTHERM_THROT_LEVEL_MED (75%), >> + TEGRA_SOCTHERM_THROT_LEVEL_HIGH (85%). >> - #cooling-cells: Should be 1. This cooling device only support on/off state. >> See ./thermal.txt for a description of this property.
next prev parent reply other threads:[~2019-02-19 6:34 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-18 7:34 [PATCH v1 00/12] Add some functionalities for Tegra soctherm Wei Ni 2018-12-18 7:34 ` Wei Ni 2018-12-18 7:34 ` Wei Ni 2018-12-18 7:34 ` Wei Ni 2019-01-21 9:26 ` Wei Ni 2019-01-21 9:26 ` Wei Ni 2018-12-18 7:34 ` [PATCH v1 01/12] of: Add bindings of thermtrip " Wei Ni 2018-12-18 7:34 ` Wei Ni 2018-12-27 23:06 ` Rob Herring 2018-12-28 3:28 ` Wei Ni 2018-12-28 3:28 ` Wei Ni 2019-02-20 1:22 ` Eduardo Valentin 2019-02-20 8:39 ` Wei Ni 2019-02-20 8:39 ` Wei Ni 2018-12-18 7:34 ` [PATCH v1 02/12] thermal: tegra: support hw and sw shutdown Wei Ni 2018-12-18 7:34 ` Wei Ni 2018-12-18 7:34 ` [PATCH v1 03/12] arm64: dts: tegra210: set thermtrip Wei Ni 2018-12-18 7:34 ` Wei Ni 2018-12-18 7:34 ` [PATCH v1 04/12] of: Add bindings of gpu hw throttle for Tegra soctherm Wei Ni 2018-12-18 7:34 ` Wei Ni 2019-02-18 20:29 ` Rob Herring 2019-02-19 6:08 ` Wei Ni 2019-02-19 6:08 ` Wei Ni 2019-02-18 20:33 ` Rob Herring 2019-02-19 6:34 ` Wei Ni [this message] 2019-02-19 6:34 ` Wei Ni 2018-12-18 7:34 ` [PATCH v1 05/12] thermal: tegra: add support for gpu hw-throttle Wei Ni 2018-12-18 7:34 ` Wei Ni 2018-12-18 7:34 ` [PATCH v1 06/12] arm64: dts: tegra210: set gpu hw throttle level Wei Ni 2018-12-18 7:34 ` Wei Ni 2018-12-18 7:34 ` [PATCH v1 07/12] thermal: tegra: add support for thermal IRQ Wei Ni 2018-12-18 7:34 ` Wei Ni 2018-12-18 7:34 ` [PATCH v1 08/12] thermal: tegra: add set_trips functionality Wei Ni 2018-12-18 7:34 ` Wei Ni 2018-12-18 7:34 ` [PATCH v1 09/12] thermal: tegra: add support for EDP IRQ Wei Ni 2018-12-18 7:34 ` Wei Ni 2018-12-18 7:34 ` [PATCH v1 10/12] arm64: dts: tegra210: set EDP interrupt line Wei Ni 2018-12-18 7:34 ` Wei Ni 2018-12-18 7:34 ` [PATCH v1 11/12] of: Add bindings of OC hw throttle for Tegra soctherm Wei Ni 2018-12-18 7:34 ` Wei Ni 2019-02-18 20:32 ` Rob Herring 2019-02-19 6:31 ` Wei Ni 2019-02-19 6:31 ` Wei Ni 2018-12-18 7:34 ` [PATCH v1 12/12] thermal: tegra: enable OC hw throttle Wei Ni 2018-12-18 7:34 ` Wei Ni 2018-12-18 7:50 ` [PATCH v1 00/12] Add some functionalities for Tegra soctherm Wei Ni 2018-12-18 7:50 ` Wei Ni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=739a8c81-ee0a-999e-0508-6aa1fba768b7@nvidia.com \ --to=wni@nvidia.com \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=edubezval@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=robh@kernel.org \ --cc=rui.zhang@intel.com \ --cc=srikars@nvidia.com \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.