All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	William Cohen <wcohen@redhat.com>
Cc: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<alexander.shishkin@linux.intel.com>, <jolsa@redhat.com>,
	<peterz@infradead.org>, <mingo@redhat.com>, <Will.Deacon@arm.com>,
	<mark.rutland@arm.com>, <jnair@caviumnetworks.com>,
	<Robert.Richter@cavium.com>, Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH] perf vendor events arm64: Enable JSON events for ThunderX2 B0
Date: Wed, 7 Mar 2018 15:25:28 +0000	[thread overview]
Message-ID: <73a51582-2faa-6a75-6c7e-8888b24a3442@huawei.com> (raw)
In-Reply-To: <20180307143832.GJ3701@kernel.org>

On 07/03/2018 14:38, Arnaldo Carvalho de Melo wrote:
> Em Wed, Mar 07, 2018 at 09:32:05AM -0500, William Cohen escreveu:
>> On 03/07/2018 06:08 AM, Ganapatrao Kulkarni wrote:
>>> There is MIDR change on ThunderX2 B0, adding an entry to mapfile
>>> to enable JSON events for B0.
>>>
>>> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
>
> Ganapatrao, can you please take this in consideration and if agreeing
> send a v2 patch?
>
> With that I can add an Acked-by: wcohen, Right?
>

JFYI, This patch conflicts with "[PATCH v2 00/11] perf events patches 
for improved ARM64 support". I was planning on sending a v3 quite soon.

> - Arnaldo
>>> ---
>>>  tools/perf/pmu-events/arch/arm64/mapfile.csv | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tools/perf/pmu-events/arch/arm64/mapfile.csv b/tools/perf/pmu-events/arch/arm64/mapfile.csv
>>> index e61c9ca..93c5d14 100644
>>> --- a/tools/perf/pmu-events/arch/arm64/mapfile.csv
>>> +++ b/tools/perf/pmu-events/arch/arm64/mapfile.csv
>>> @@ -13,4 +13,5 @@
>>>  #
>>>  #Family-model,Version,Filename,EventType
>>>  0x00000000420f5160,v1,cavium,core
>>> +0x00000000430f0af0,v1,cavium,core
>>>  0x00000000410fd03[[:xdigit:]],v1,cortex-a53,core
>>>
>>
>> Hi,
>> Like the cortex-a53 the last digit '0' of the match for the MIDR should be replaced with [[:xdigit:]] to allow for possible future revisions of chip:
>>
>> 0x00000000430f0af[[:xdigit:]],v1,cavium,core
>>
>>
>> -Will Cohen
>
> .

Thanks,
John

>

WARNING: multiple messages have this Message-ID (diff)
From: john.garry@huawei.com (John Garry)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] perf vendor events arm64: Enable JSON events for ThunderX2 B0
Date: Wed, 7 Mar 2018 15:25:28 +0000	[thread overview]
Message-ID: <73a51582-2faa-6a75-6c7e-8888b24a3442@huawei.com> (raw)
In-Reply-To: <20180307143832.GJ3701@kernel.org>

On 07/03/2018 14:38, Arnaldo Carvalho de Melo wrote:
> Em Wed, Mar 07, 2018 at 09:32:05AM -0500, William Cohen escreveu:
>> On 03/07/2018 06:08 AM, Ganapatrao Kulkarni wrote:
>>> There is MIDR change on ThunderX2 B0, adding an entry to mapfile
>>> to enable JSON events for B0.
>>>
>>> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
>
> Ganapatrao, can you please take this in consideration and if agreeing
> send a v2 patch?
>
> With that I can add an Acked-by: wcohen, Right?
>

JFYI, This patch conflicts with "[PATCH v2 00/11] perf events patches 
for improved ARM64 support". I was planning on sending a v3 quite soon.

> - Arnaldo
>>> ---
>>>  tools/perf/pmu-events/arch/arm64/mapfile.csv | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tools/perf/pmu-events/arch/arm64/mapfile.csv b/tools/perf/pmu-events/arch/arm64/mapfile.csv
>>> index e61c9ca..93c5d14 100644
>>> --- a/tools/perf/pmu-events/arch/arm64/mapfile.csv
>>> +++ b/tools/perf/pmu-events/arch/arm64/mapfile.csv
>>> @@ -13,4 +13,5 @@
>>>  #
>>>  #Family-model,Version,Filename,EventType
>>>  0x00000000420f5160,v1,cavium,core
>>> +0x00000000430f0af0,v1,cavium,core
>>>  0x00000000410fd03[[:xdigit:]],v1,cortex-a53,core
>>>
>>
>> Hi,
>> Like the cortex-a53 the last digit '0' of the match for the MIDR should be replaced with [[:xdigit:]] to allow for possible future revisions of chip:
>>
>> 0x00000000430f0af[[:xdigit:]],v1,cavium,core
>>
>>
>> -Will Cohen
>
> .

Thanks,
John

>

  reply	other threads:[~2018-03-07 15:26 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07 11:08 [PATCH] perf vendor events arm64: Enable JSON events for ThunderX2 B0 Ganapatrao Kulkarni
2018-03-07 11:08 ` Ganapatrao Kulkarni
2018-03-07 14:32 ` William Cohen
2018-03-07 14:32   ` William Cohen
2018-03-07 14:38   ` Arnaldo Carvalho de Melo
2018-03-07 14:38     ` Arnaldo Carvalho de Melo
2018-03-07 15:25     ` John Garry [this message]
2018-03-07 15:25       ` John Garry
2018-03-07 15:36       ` William Cohen
2018-03-07 15:36         ` William Cohen
2018-03-07 17:35     ` Ganapatrao Kulkarni
2018-03-07 17:35       ` Ganapatrao Kulkarni
2018-03-07 18:31       ` William Cohen
2018-03-07 18:31         ` William Cohen
2018-03-08  4:14         ` Ganapatrao Kulkarni
2018-03-08  4:14           ` Ganapatrao Kulkarni
2018-03-09 14:27           ` Ganapatrao Kulkarni
2018-03-09 14:27             ` Ganapatrao Kulkarni
2018-03-09 14:34             ` Arnaldo Carvalho de Melo
2018-03-09 14:34               ` Arnaldo Carvalho de Melo
2018-03-09 15:58               ` Will Deacon
2018-03-09 15:58                 ` Will Deacon
2018-03-09 17:28                 ` Arnaldo Carvalho de Melo
2018-03-09 17:28                   ` Arnaldo Carvalho de Melo
2018-03-09 17:33                 ` Arnaldo Carvalho de Melo
2018-03-09 17:33                   ` Arnaldo Carvalho de Melo
2018-03-09 17:45                   ` Ganapatrao Kulkarni
2018-03-09 17:45                     ` Ganapatrao Kulkarni
2018-03-09 18:00                     ` Arnaldo Carvalho de Melo
2018-03-09 18:00                       ` Arnaldo Carvalho de Melo
2018-03-09 18:02                       ` Arnaldo Carvalho de Melo
2018-03-09 18:02                         ` Arnaldo Carvalho de Melo
2018-03-09 18:07                         ` Ganapatrao Kulkarni
2018-03-09 18:07                           ` Ganapatrao Kulkarni
2018-03-15 15:53           ` William Cohen
2018-03-15 15:53             ` William Cohen
2018-03-15 16:47             ` John Garry
2018-03-15 16:47               ` John Garry
2018-03-21  2:37               ` William Cohen
2018-03-21  2:37                 ` William Cohen
2018-03-21 10:58                 ` John Garry
2018-03-21 10:58                   ` John Garry
2018-03-20  6:27 ` [tip:perf/core] " tip-bot for Ganapatrao Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73a51582-2faa-6a75-6c7e-8888b24a3442@huawei.com \
    --to=john.garry@huawei.com \
    --cc=Robert.Richter@cavium.com \
    --cc=Will.Deacon@arm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ganapatrao.kulkarni@cavium.com \
    --cc=jnair@caviumnetworks.com \
    --cc=jolsa@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=wcohen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.