* [igt-dev] [PATCH i-g-t] lib: Include the size in the error message for mlock
@ 2019-01-22 18:17 Chris Wilson
2019-01-22 18:48 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2019-01-22 18:17 UTC (permalink / raw)
To: igt-dev
Knowing how much we tried to allocate would be useful if one should need
to debug why it failed.
References: https://bugs.freedesktop.org/show_bug.cgi?id=109439
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
lib/igt_aux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/igt_aux.c b/lib/igt_aux.c
index 1250d5c5f..2e2d552b5 100644
--- a/lib/igt_aux.c
+++ b/lib/igt_aux.c
@@ -1080,14 +1080,14 @@ void igt_lock_mem(size_t size)
locked_mem = malloc(locked_size);
igt_require_f(locked_mem,
- "Could not allocate enough memory to lock.\n");
+ "Could not malloc %zdMiB for locking.\n", size);
/* write into each page to ensure it is allocated */
for (i = 0; i < locked_size; i += pagesize)
locked_mem[i] = i;
ret = mlock(locked_mem, locked_size);
- igt_assert_f(ret == 0, "Could not lock memory into RAM.\n");
+ igt_assert_f(ret == 0, "Could not mlock %zdMiB.\n", size);
}
/**
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib: Include the size in the error message for mlock
2019-01-22 18:17 [igt-dev] [PATCH i-g-t] lib: Include the size in the error message for mlock Chris Wilson
@ 2019-01-22 18:48 ` Patchwork
2019-01-22 18:55 ` [igt-dev] [PATCH i-g-t] " Antonio Argenziano
2019-01-22 20:32 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-01-22 18:48 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: lib: Include the size in the error message for mlock
URL : https://patchwork.freedesktop.org/series/55573/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5464 -> IGTPW_2273
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/55573/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2273 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-compute:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#108094]
* igt@amdgpu/amd_prime@amd-to-i915:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#107341]
#### Possible fixes ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: DMESG-WARN [fdo#108965] -> PASS
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107341]: https://bugs.freedesktop.org/show_bug.cgi?id=107341
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
Participating hosts (45 -> 38)
------------------------------
Additional (1): fi-skl-6770hq
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-glk-j4005 fi-pnv-d510 fi-icl-y fi-skl-6700hq
Build changes
-------------
* IGT: IGT_4782 -> IGTPW_2273
CI_DRM_5464: af90b519a670a3aec89045d9fcca8f2d174adeda @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2273: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2273/
IGT_4782: 96f3a1b876e0dd24706b85fb872f12031a436e84 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2273/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib: Include the size in the error message for mlock
2019-01-22 18:17 [igt-dev] [PATCH i-g-t] lib: Include the size in the error message for mlock Chris Wilson
2019-01-22 18:48 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-01-22 18:55 ` Antonio Argenziano
2019-01-22 20:32 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Antonio Argenziano @ 2019-01-22 18:55 UTC (permalink / raw)
To: Chris Wilson, igt-dev
On 22/01/19 10:17, Chris Wilson wrote:
> Knowing how much we tried to allocate would be useful if one should need
> to debug why it failed.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=109439
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
LGTM.
Reviewed-by: Antonio Argenziano <antonio.argenziano@intel.com>
> ---
> lib/igt_aux.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/igt_aux.c b/lib/igt_aux.c
> index 1250d5c5f..2e2d552b5 100644
> --- a/lib/igt_aux.c
> +++ b/lib/igt_aux.c
> @@ -1080,14 +1080,14 @@ void igt_lock_mem(size_t size)
>
> locked_mem = malloc(locked_size);
> igt_require_f(locked_mem,
> - "Could not allocate enough memory to lock.\n");
> + "Could not malloc %zdMiB for locking.\n", size);
>
> /* write into each page to ensure it is allocated */
> for (i = 0; i < locked_size; i += pagesize)
> locked_mem[i] = i;
>
> ret = mlock(locked_mem, locked_size);
> - igt_assert_f(ret == 0, "Could not lock memory into RAM.\n");
> + igt_assert_f(ret == 0, "Could not mlock %zdMiB.\n", size);
> }
>
> /**
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for lib: Include the size in the error message for mlock
2019-01-22 18:17 [igt-dev] [PATCH i-g-t] lib: Include the size in the error message for mlock Chris Wilson
2019-01-22 18:48 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-22 18:55 ` [igt-dev] [PATCH i-g-t] " Antonio Argenziano
@ 2019-01-22 20:32 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-01-22 20:32 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: lib: Include the size in the error message for mlock
URL : https://patchwork.freedesktop.org/series/55573/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5464_full -> IGTPW_2273_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/55573/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2273_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_cpu_reloc@full:
- shard-glk: PASS -> DMESG-WARN [fdo#105763] / [fdo#106538]
* igt@gem_exec_reuse@contexts:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: PASS -> FAIL [fdo#106641]
- shard-glk: PASS -> FAIL [fdo#106641]
- shard-kbl: PASS -> FAIL [fdo#106641]
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-glk: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-pageflip-hang-newfb-render-a:
- shard-glk: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145] +1
* igt@kms_color@pipe-a-ctm-max:
- shard-kbl: PASS -> FAIL [fdo#108147]
- shard-apl: PASS -> FAIL [fdo#108147]
* igt@kms_color@pipe-b-ctm-max:
- shard-apl: NOTRUN -> FAIL [fdo#108147]
* igt@kms_cursor_crc@cursor-128x128-dpms:
- shard-kbl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-glk: PASS -> FAIL [fdo#103232] +2
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
- shard-kbl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: PASS -> FAIL [fdo#103232] +5
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-apl: PASS -> FAIL [fdo#103167] +2
- shard-kbl: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: PASS -> FAIL [fdo#103167] +10
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: PASS -> FAIL [fdo#108948]
- shard-apl: PASS -> FAIL [fdo#108948]
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-glk: PASS -> FAIL [fdo#103166] +2
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb:
- shard-glk: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- shard-apl: PASS -> FAIL [fdo#103166] +1
- shard-kbl: PASS -> FAIL [fdo#103166] +1
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-apl: NOTRUN -> FAIL [fdo#103166]
* igt@pm_rps@min-max-config-loaded:
- shard-apl: PASS -> FAIL [fdo#102250]
* igt@pm_rps@reset:
- shard-glk: PASS -> FAIL [fdo#102250]
#### Possible fixes ####
* igt@gem_tiled_swapping@non-threaded:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@kms_cursor_crc@cursor-256x256-dpms:
- shard-glk: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: FAIL [fdo#103232] -> PASS
- shard-kbl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
- shard-snb: {SKIP} [fdo#109271] -> PASS +3
* igt@kms_cursor_legacy@pipe-c-torture-move:
- shard-hsw: DMESG-WARN [fdo#107122] -> PASS
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: FAIL [fdo#105363] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-apl: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-render:
- shard-glk: FAIL [fdo#103167] -> PASS +1
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
- shard-glk: FAIL [fdo#103166] -> PASS
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +1
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
* igt@prime_vgem@basic-fence-flip:
- shard-kbl: FAIL [fdo#104008] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102250]: https://bugs.freedesktop.org/show_bug.cgi?id=102250
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104008]: https://bugs.freedesktop.org/show_bug.cgi?id=104008
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#107122]: https://bugs.freedesktop.org/show_bug.cgi?id=107122
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4782 -> IGTPW_2273
* Piglit: piglit_4509 -> None
CI_DRM_5464: af90b519a670a3aec89045d9fcca8f2d174adeda @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2273: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2273/
IGT_4782: 96f3a1b876e0dd24706b85fb872f12031a436e84 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2273/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-22 20:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-22 18:17 [igt-dev] [PATCH i-g-t] lib: Include the size in the error message for mlock Chris Wilson
2019-01-22 18:48 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-22 18:55 ` [igt-dev] [PATCH i-g-t] " Antonio Argenziano
2019-01-22 20:32 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.