All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olivier MOYSAN <olivier.moysan@st.com>
To: Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Alexandre TORGUE <alexandre.torgue@st.com>,
	Arnaud POULIQUEN <arnaud.pouliquen@st.com>,
	"tiwai@suse.com" <tiwai@suse.com>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Benjamin GAIGNARD <benjamin.gaignard@st.com>
Subject: Re: [PATCH 1/2] dt-bindings: Document STM32 I2S bindings
Date: Tue, 11 Apr 2017 15:44:52 +0000	[thread overview]
Message-ID: <73caede5-ea6f-8b2b-2270-227f7ef31823@st.com> (raw)
In-Reply-To: <20170411143250.3r7ys3rjshtxgaee@sirena.org.uk>

Hello Rob, Mark

Thanks for your review.
Please find my comments below.

On 04/11/2017 04:32 PM, Mark Brown wrote:
> On Mon, Apr 10, 2017 at 02:48:32PM -0500, Rob Herring wrote:
>> On Thu, Apr 06, 2017 at 05:40:35PM +0200, olivier moysan wrote:
>
>>> +Required properties:
>>> +  - compatible: Must be "st,stm32h7-i2s"
>>> +  - #sound-dai-cells: Must be 1. (one parameter)
>>> +    This parameter allows to specify CPU DAI index in soundcard CPU dai link.
>>> +	index 0: playback DAI
>>> +	index 1: capture DAI
>>> +	index 2: full duplex DAI
>
>> Is this still needed for graph-card?
>
> The graph card is blocked on your review...  I'm also not clear how
> without something like this we'd be able to identify a specific DAI
> within a device if we don't have a way of identifying them.
>
Yes, it seems that audio graph card does not allow to select a specific 
DAI. This will probably be necessary.

However, regarding STM32 I2S driver, I'm wondering if selecting DAI
is the best way to configure interface as tx, rx or fd.
Maybe, it is more relevant to configure DAI according to DMA
configuration from I2S node.
This would moreover avoid to allocate 2 dmas channels when not
necessary (tx or rx only).
If you agree with this, I will implement this change in a v2.

BRs
olivier

WARNING: multiple messages have this Message-ID (diff)
From: olivier.moysan@st.com (Olivier MOYSAN)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] dt-bindings: Document STM32 I2S bindings
Date: Tue, 11 Apr 2017 15:44:52 +0000	[thread overview]
Message-ID: <73caede5-ea6f-8b2b-2270-227f7ef31823@st.com> (raw)
In-Reply-To: <20170411143250.3r7ys3rjshtxgaee@sirena.org.uk>

Hello Rob, Mark

Thanks for your review.
Please find my comments below.

On 04/11/2017 04:32 PM, Mark Brown wrote:
> On Mon, Apr 10, 2017 at 02:48:32PM -0500, Rob Herring wrote:
>> On Thu, Apr 06, 2017 at 05:40:35PM +0200, olivier moysan wrote:
>
>>> +Required properties:
>>> +  - compatible: Must be "st,stm32h7-i2s"
>>> +  - #sound-dai-cells: Must be 1. (one parameter)
>>> +    This parameter allows to specify CPU DAI index in soundcard CPU dai link.
>>> +	index 0: playback DAI
>>> +	index 1: capture DAI
>>> +	index 2: full duplex DAI
>
>> Is this still needed for graph-card?
>
> The graph card is blocked on your review...  I'm also not clear how
> without something like this we'd be able to identify a specific DAI
> within a device if we don't have a way of identifying them.
>
Yes, it seems that audio graph card does not allow to select a specific 
DAI. This will probably be necessary.

However, regarding STM32 I2S driver, I'm wondering if selecting DAI
is the best way to configure interface as tx, rx or fd.
Maybe, it is more relevant to configure DAI according to DMA
configuration from I2S node.
This would moreover avoid to allocate 2 dmas channels when not
necessary (tx or rx only).
If you agree with this, I will implement this change in a v2.

BRs
olivier

  reply	other threads:[~2017-04-11 15:44 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06 15:40 [PATCH 0/2] ASoC: stm32: Add I2S driver olivier moysan
2017-04-06 15:40 ` olivier moysan
2017-04-06 15:40 ` [PATCH 1/2] dt-bindings: Document STM32 I2S bindings olivier moysan
2017-04-06 15:40   ` olivier moysan
2017-04-10 19:48   ` Rob Herring
2017-04-10 19:48     ` Rob Herring
2017-04-11 14:32     ` Mark Brown
2017-04-11 14:32       ` Mark Brown
2017-04-11 15:44       ` Olivier MOYSAN [this message]
2017-04-11 15:44         ` Olivier MOYSAN
2017-04-11 21:10         ` Mark Brown
2017-04-11 21:10           ` Mark Brown
2017-04-12  8:30           ` Olivier MOYSAN
2017-04-12  8:30             ` Olivier MOYSAN
     [not found]             ` <86a179ad-7961-18f7-8050-25e0e584c77d-qxv4g6HH51o@public.gmane.org>
2017-04-12 11:32               ` Mark Brown
2017-04-12 11:32                 ` Mark Brown
2017-04-12 12:58                 ` Olivier MOYSAN
2017-04-12 12:58                   ` Olivier MOYSAN
     [not found]                   ` <d886a9c7-ca46-f37a-0e82-6ed8d7a4e052-qxv4g6HH51o@public.gmane.org>
2017-04-12 15:38                     ` Mark Brown
2017-04-12 15:38                       ` Mark Brown
2017-04-13  8:01                       ` Olivier MOYSAN
2017-04-13  8:01                         ` Olivier MOYSAN
2017-04-26 16:15                         ` Mark Brown
2017-04-26 16:15                           ` Mark Brown
2017-04-27 15:57                           ` Olivier MOYSAN
2017-04-27 15:57                             ` Olivier MOYSAN
     [not found]       ` <20170411143250.3r7ys3rjshtxgaee-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-04-11 16:02         ` Rob Herring
2017-04-11 16:02           ` Rob Herring
2017-04-11 20:19           ` Mark Brown
2017-04-11 20:19             ` Mark Brown
     [not found] ` <1491493236-2574-1-git-send-email-olivier.moysan-qxv4g6HH51o@public.gmane.org>
2017-04-06 15:40   ` [PATCH 2/2] ASoC: stm32: Add I2S driver olivier moysan
2017-04-06 15:40     ` olivier moysan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73caede5-ea6f-8b2b-2270-227f7ef31823@st.com \
    --to=olivier.moysan@st.com \
    --cc=alexandre.torgue@st.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnaud.pouliquen@st.com \
    --cc=benjamin.gaignard@st.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.