* [PATCH v2] arm64: defconfig: enable Intel's eASIC N5X SoCFPGA and Keem Bay SoC
@ 2021-03-08 17:48 Krzysztof Kozlowski
2021-03-08 19:07 ` Dinh Nguyen
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-03-08 17:48 UTC (permalink / raw)
To: Paul J. Murphy, Daniele Alessandrelli, Dinh Nguyen, Rob Herring,
devicetree, linux-kernel, arm, soc, Arnd Bergmann,
Olof Johansson
Cc: Krzysztof Kozlowski
From: Krzysztof Kozlowski <krzk@kernel.org>
Enable in defconfig two Intel ARM64 architectures: the eASIC N5X SoCFPGA
and Keem Bay SoC. This allows compile coverage when building default
config.
For the N5X (and Agilex) enable also DesignWare SPI controller in MMIO.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Hi Arnd,
You asked me to check if all drivers are enabled for these platforms.
In general the answer is yes. In particular:
1. Keem Bay is does not have much in upstream, but everything described
in DTS is there,
2. N5X shares a lot with Agilex SoCFPGA which already (mostly) is
supported.
Changes since v1:
1. Enable also SPI_DW_MMIO
---
arch/arm64/configs/defconfig | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index d612f633b771..9f9adcb8b0e9 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -29,6 +29,7 @@ CONFIG_KALLSYMS_ALL=y
CONFIG_PROFILING=y
CONFIG_ARCH_ACTIONS=y
CONFIG_ARCH_AGILEX=y
+CONFIG_ARCH_N5X=y
CONFIG_ARCH_SUNXI=y
CONFIG_ARCH_ALPINE=y
CONFIG_ARCH_BCM2835=y
@@ -41,6 +42,7 @@ CONFIG_ARCH_K3=y
CONFIG_ARCH_LAYERSCAPE=y
CONFIG_ARCH_LG1K=y
CONFIG_ARCH_HISI=y
+CONFIG_ARCH_KEEMBAY=y
CONFIG_ARCH_MEDIATEK=y
CONFIG_ARCH_MESON=y
CONFIG_ARCH_MVEBU=y
@@ -465,6 +467,9 @@ CONFIG_SPI=y
CONFIG_SPI_ARMADA_3700=y
CONFIG_SPI_BCM2835=m
CONFIG_SPI_BCM2835AUX=m
+CONFIG_SPI_DESIGNWARE=m
+CONFIG_SPI_DW_DMA=y
+CONFIG_SPI_DW_MMIO=m
CONFIG_SPI_FSL_LPSPI=y
CONFIG_SPI_FSL_QUADSPI=y
CONFIG_SPI_NXP_FLEXSPI=y
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: defconfig: enable Intel's eASIC N5X SoCFPGA and Keem Bay SoC
2021-03-08 17:48 [PATCH v2] arm64: defconfig: enable Intel's eASIC N5X SoCFPGA and Keem Bay SoC Krzysztof Kozlowski
@ 2021-03-08 19:07 ` Dinh Nguyen
2021-03-09 9:29 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Dinh Nguyen @ 2021-03-08 19:07 UTC (permalink / raw)
To: Krzysztof Kozlowski, Paul J. Murphy, Daniele Alessandrelli,
Rob Herring, devicetree, linux-kernel, arm, soc, Arnd Bergmann,
Olof Johansson
Cc: Krzysztof Kozlowski
Hi Krzysztof,
On 3/8/21 11:48 AM, Krzysztof Kozlowski wrote:
> From: Krzysztof Kozlowski <krzk@kernel.org>
>
> Enable in defconfig two Intel ARM64 architectures: the eASIC N5X SoCFPGA
> and Keem Bay SoC. This allows compile coverage when building default
> config.
>
> For the N5X (and Agilex) enable also DesignWare SPI controller in MMIO.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Hi Arnd,
>
> You asked me to check if all drivers are enabled for these platforms.
> In general the answer is yes. In particular:
> 1. Keem Bay is does not have much in upstream, but everything described
> in DTS is there,
> 2. N5X shares a lot with Agilex SoCFPGA which already (mostly) is
> supported.
>
> Changes since v1:
> 1. Enable also SPI_DW_MMIO
> ---
> arch/arm64/configs/defconfig | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index d612f633b771..9f9adcb8b0e9 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -29,6 +29,7 @@ CONFIG_KALLSYMS_ALL=y
> CONFIG_PROFILING=y
> CONFIG_ARCH_ACTIONS=y
> CONFIG_ARCH_AGILEX=y
> +CONFIG_ARCH_N5X=y
I just submitted a patch for this as well. From the looks of the
defconfig file, it looks like the platforms are in alphabetical order,
but then I see that ARCH_SUNXI is not in it's correct spot if there is a
rule for keeping things in alphabetical order.
I'll drop my patch.
Dinh
> CONFIG_ARCH_SUNXI=y
> CONFIG_ARCH_ALPINE=y
> CONFIG_ARCH_BCM2835=y
> @@ -41,6 +42,7 @@ CONFIG_ARCH_K3=y
> CONFIG_ARCH_LAYERSCAPE=y
> CONFIG_ARCH_LG1K=y
> CONFIG_ARCH_HISI=y
> +CONFIG_ARCH_KEEMBAY=y
> CONFIG_ARCH_MEDIATEK=y
> CONFIG_ARCH_MESON=y
> CONFIG_ARCH_MVEBU=y
> @@ -465,6 +467,9 @@ CONFIG_SPI=y
> CONFIG_SPI_ARMADA_3700=y
> CONFIG_SPI_BCM2835=m
> CONFIG_SPI_BCM2835AUX=m
> +CONFIG_SPI_DESIGNWARE=m
> +CONFIG_SPI_DW_DMA=y
> +CONFIG_SPI_DW_MMIO=m
> CONFIG_SPI_FSL_LPSPI=y
> CONFIG_SPI_FSL_QUADSPI=y
> CONFIG_SPI_NXP_FLEXSPI=y
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: defconfig: enable Intel's eASIC N5X SoCFPGA and Keem Bay SoC
2021-03-08 19:07 ` Dinh Nguyen
@ 2021-03-09 9:29 ` Krzysztof Kozlowski
2021-03-09 13:26 ` Dinh Nguyen
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-03-09 9:29 UTC (permalink / raw)
To: Dinh Nguyen, Paul J. Murphy, Daniele Alessandrelli, Rob Herring,
devicetree, linux-kernel, arm, soc, Arnd Bergmann,
Olof Johansson
Cc: Krzysztof Kozlowski
On 08/03/2021 20:07, Dinh Nguyen wrote:
> Hi Krzysztof,
>
> On 3/8/21 11:48 AM, Krzysztof Kozlowski wrote:
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>>
>> Enable in defconfig two Intel ARM64 architectures: the eASIC N5X SoCFPGA
>> and Keem Bay SoC. This allows compile coverage when building default
>> config.
>>
>> For the N5X (and Agilex) enable also DesignWare SPI controller in MMIO.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>
>> ---
>>
>> Hi Arnd,
>>
>> You asked me to check if all drivers are enabled for these platforms.
>> In general the answer is yes. In particular:
>> 1. Keem Bay is does not have much in upstream, but everything described
>> in DTS is there,
>> 2. N5X shares a lot with Agilex SoCFPGA which already (mostly) is
>> supported.
>>
>> Changes since v1:
>> 1. Enable also SPI_DW_MMIO
>> ---
>> arch/arm64/configs/defconfig | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index d612f633b771..9f9adcb8b0e9 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -29,6 +29,7 @@ CONFIG_KALLSYMS_ALL=y
>> CONFIG_PROFILING=y
>> CONFIG_ARCH_ACTIONS=y
>> CONFIG_ARCH_AGILEX=y
>> +CONFIG_ARCH_N5X=y
>
> I just submitted a patch for this as well. From the looks of the
> defconfig file, it looks like the platforms are in alphabetical order,
> but then I see that ARCH_SUNXI is not in it's correct spot if there is a
> rule for keeping things in alphabetical order.
>
The rule is that order comes from savedefconfig, not alphabetical. This
way you avoid reshuffling of symbols on any future savedefconfig.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: defconfig: enable Intel's eASIC N5X SoCFPGA and Keem Bay SoC
2021-03-09 9:29 ` Krzysztof Kozlowski
@ 2021-03-09 13:26 ` Dinh Nguyen
2021-03-09 15:19 ` Arnd Bergmann
0 siblings, 1 reply; 6+ messages in thread
From: Dinh Nguyen @ 2021-03-09 13:26 UTC (permalink / raw)
To: Krzysztof Kozlowski, Paul J. Murphy, Daniele Alessandrelli,
Rob Herring, devicetree, linux-kernel, arm, soc, Arnd Bergmann,
Olof Johansson
Cc: Krzysztof Kozlowski
On 3/9/21 3:29 AM, Krzysztof Kozlowski wrote:
> On 08/03/2021 20:07, Dinh Nguyen wrote:
>> Hi Krzysztof,
>>
>> On 3/8/21 11:48 AM, Krzysztof Kozlowski wrote:
>>> From: Krzysztof Kozlowski <krzk@kernel.org>
>>>
>>> Enable in defconfig two Intel ARM64 architectures: the eASIC N5X SoCFPGA
>>> and Keem Bay SoC. This allows compile coverage when building default
>>> config.
>>>
>>> For the N5X (and Agilex) enable also DesignWare SPI controller in MMIO.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>>
>>> ---
>>>
>>> Hi Arnd,
>>>
>>> You asked me to check if all drivers are enabled for these platforms.
>>> In general the answer is yes. In particular:
>>> 1. Keem Bay is does not have much in upstream, but everything described
>>> in DTS is there,
>>> 2. N5X shares a lot with Agilex SoCFPGA which already (mostly) is
>>> supported.
>>>
>>> Changes since v1:
>>> 1. Enable also SPI_DW_MMIO
>>> ---
>>> arch/arm64/configs/defconfig | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>> index d612f633b771..9f9adcb8b0e9 100644
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -29,6 +29,7 @@ CONFIG_KALLSYMS_ALL=y
>>> CONFIG_PROFILING=y
>>> CONFIG_ARCH_ACTIONS=y
>>> CONFIG_ARCH_AGILEX=y
>>> +CONFIG_ARCH_N5X=y
>>
>> I just submitted a patch for this as well. From the looks of the
>> defconfig file, it looks like the platforms are in alphabetical order,
>> but then I see that ARCH_SUNXI is not in it's correct spot if there is a
>> rule for keeping things in alphabetical order.
>>
>
> The rule is that order comes from savedefconfig, not alphabetical. This
> way you avoid reshuffling of symbols on any future savedefconfig.
>
Got it. But I've done savedefconfig in the past and Arnd adviced against
that because what if multiple patches come in with savedefconfig,
wouldn't that cause a messy merge?
Dinh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: defconfig: enable Intel's eASIC N5X SoCFPGA and Keem Bay SoC
2021-03-09 13:26 ` Dinh Nguyen
@ 2021-03-09 15:19 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2021-03-09 15:19 UTC (permalink / raw)
To: Dinh Nguyen
Cc: Krzysztof Kozlowski, Paul J. Murphy, Daniele Alessandrelli,
Rob Herring, DTML, linux-kernel, arm-soc, SoC Team,
Olof Johansson, Krzysztof Kozlowski
On Tue, Mar 9, 2021 at 2:26 PM Dinh Nguyen <dinguyen@kernel.org> wrote:
> On 3/9/21 3:29 AM, Krzysztof Kozlowski wrote:
> > On 08/03/2021 20:07, Dinh Nguyen wrote:
> >>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> >>> index d612f633b771..9f9adcb8b0e9 100644
> >>> --- a/arch/arm64/configs/defconfig
> >>> +++ b/arch/arm64/configs/defconfig
> >>> @@ -29,6 +29,7 @@ CONFIG_KALLSYMS_ALL=y
> >>> CONFIG_PROFILING=y
> >>> CONFIG_ARCH_ACTIONS=y
> >>> CONFIG_ARCH_AGILEX=y
> >>> +CONFIG_ARCH_N5X=y
> >>
> >> I just submitted a patch for this as well. From the looks of the
> >> defconfig file, it looks like the platforms are in alphabetical order,
> >> but then I see that ARCH_SUNXI is not in it's correct spot if there is a
> >> rule for keeping things in alphabetical order.
> >>
> >
> > The rule is that order comes from savedefconfig, not alphabetical. This
> > way you avoid reshuffling of symbols on any future savedefconfig.
> >
>
> Got it. But I've done savedefconfig in the past and Arnd adviced against
> that because what if multiple patches come in with savedefconfig,
> wouldn't that cause a messy merge?
To clarify: you should not send the result of 'make savedefconfig'
if it changes the contents of the file in another way, but Krzysztof's
recommendation of adding new lines where savedefconfig would
put them is best.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: defconfig: enable Intel's eASIC N5X SoCFPGA and Keem Bay SoC
@ 2021-03-09 15:19 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2021-03-09 15:19 UTC (permalink / raw)
To: Dinh Nguyen
Cc: Krzysztof Kozlowski, Paul J. Murphy, Daniele Alessandrelli,
Rob Herring, DTML, linux-kernel, arm-soc, SoC Team,
Olof Johansson, Krzysztof Kozlowski
On Tue, Mar 9, 2021 at 2:26 PM Dinh Nguyen <dinguyen@kernel.org> wrote:
> On 3/9/21 3:29 AM, Krzysztof Kozlowski wrote:
> > On 08/03/2021 20:07, Dinh Nguyen wrote:
> >>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> >>> index d612f633b771..9f9adcb8b0e9 100644
> >>> --- a/arch/arm64/configs/defconfig
> >>> +++ b/arch/arm64/configs/defconfig
> >>> @@ -29,6 +29,7 @@ CONFIG_KALLSYMS_ALL=y
> >>> CONFIG_PROFILING=y
> >>> CONFIG_ARCH_ACTIONS=y
> >>> CONFIG_ARCH_AGILEX=y
> >>> +CONFIG_ARCH_N5X=y
> >>
> >> I just submitted a patch for this as well. From the looks of the
> >> defconfig file, it looks like the platforms are in alphabetical order,
> >> but then I see that ARCH_SUNXI is not in it's correct spot if there is a
> >> rule for keeping things in alphabetical order.
> >>
> >
> > The rule is that order comes from savedefconfig, not alphabetical. This
> > way you avoid reshuffling of symbols on any future savedefconfig.
> >
>
> Got it. But I've done savedefconfig in the past and Arnd adviced against
> that because what if multiple patches come in with savedefconfig,
> wouldn't that cause a messy merge?
To clarify: you should not send the result of 'make savedefconfig'
if it changes the contents of the file in another way, but Krzysztof's
recommendation of adding new lines where savedefconfig would
put them is best.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-09 15:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-08 17:48 [PATCH v2] arm64: defconfig: enable Intel's eASIC N5X SoCFPGA and Keem Bay SoC Krzysztof Kozlowski
2021-03-08 19:07 ` Dinh Nguyen
2021-03-09 9:29 ` Krzysztof Kozlowski
2021-03-09 13:26 ` Dinh Nguyen
2021-03-09 15:19 ` Arnd Bergmann
2021-03-09 15:19 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.