From: Steffen Trumtrar <s.trumtrar@pengutronix.de> To: thor.thayer@linux.intel.com Cc: wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, dinguyen@kernel.org, davem@davemloft.net, gregkh@linuxfoundation.org, mchehab@kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv3 1/4] ARM: dts: socfpga: Add Altera I2C Controller to CycloneV Date: Tue, 06 Jun 2017 08:40:53 +0200 [thread overview] Message-ID: <73vao9vcsq.fsf@pengutronix.de> (raw) In-Reply-To: <1496447559-19782-2-git-send-email-thor.thayer@linux.intel.com> Hi! thor.thayer@linux.intel.com writes: > From: Thor Thayer <thor.thayer@linux.intel.com> > > Add the Altera I2C Controller to the CycloneV SoCFPGA device tree. > > Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com> > --- > v2 Remove altr, from fifo-size. > Rename compatible string to "altr,softip-i2c" > v3 Add version to commpatible string "altr,softip-i2c-v1.0" > --- > arch/arm/boot/dts/socfpga.dtsi | 13 ++++++++++--- > arch/arm/boot/dts/socfpga_cyclone5_socdk.dts | 28 +++++++++++++++++++++++++++- > 2 files changed, 37 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi > index b2674bd..d69c13d 100644 > --- a/arch/arm/boot/dts/socfpga.dtsi > +++ b/arch/arm/boot/dts/socfpga.dtsi > @@ -133,6 +133,13 @@ > #address-cells = <1>; > #size-cells = <0>; > > + clk_0: clk_0 { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <50000000>; > + clock-output-names = "clk_0-clk"; > + }; > + > osc1: osc1 { > #clock-cells = <0>; > compatible = "fixed-clock"; > @@ -529,11 +536,11 @@ > }; > }; > > - fpga_bridge0: fpga_bridge@ff400000 { > + fpga_bridge0: fpga_bridge@ff200000 { > compatible = "altr,socfpga-lwhps2fpga-bridge"; > - reg = <0xff400000 0x100000>; > + reg = <0xff200000 0x00200000>; > resets = <&rst LWHPS2FPGA_RESET>; > - clocks = <&l4_main_clk>; > + clocks = <&clk_0>; > }; > Why this change? This looks wrong and unrelated. The LWHPS2FPGA bridge is at 0xff400000, so it is correct the way it is or not? > fpga_bridge1: fpga_bridge@ff500000 { > diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts > index 155829f..f99576b 100644 > --- a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts > +++ b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts > @@ -68,6 +68,7 @@ > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > }; > + > }; ??? (...) Best regards, Steffen -- Pengutronix e.K. | Steffen Trumtrar | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: s.trumtrar@pengutronix.de (Steffen Trumtrar) To: linux-arm-kernel@lists.infradead.org Subject: [PATCHv3 1/4] ARM: dts: socfpga: Add Altera I2C Controller to CycloneV Date: Tue, 06 Jun 2017 08:40:53 +0200 [thread overview] Message-ID: <73vao9vcsq.fsf@pengutronix.de> (raw) In-Reply-To: <1496447559-19782-2-git-send-email-thor.thayer@linux.intel.com> Hi! thor.thayer at linux.intel.com writes: > From: Thor Thayer <thor.thayer@linux.intel.com> > > Add the Altera I2C Controller to the CycloneV SoCFPGA device tree. > > Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com> > --- > v2 Remove altr, from fifo-size. > Rename compatible string to "altr,softip-i2c" > v3 Add version to commpatible string "altr,softip-i2c-v1.0" > --- > arch/arm/boot/dts/socfpga.dtsi | 13 ++++++++++--- > arch/arm/boot/dts/socfpga_cyclone5_socdk.dts | 28 +++++++++++++++++++++++++++- > 2 files changed, 37 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi > index b2674bd..d69c13d 100644 > --- a/arch/arm/boot/dts/socfpga.dtsi > +++ b/arch/arm/boot/dts/socfpga.dtsi > @@ -133,6 +133,13 @@ > #address-cells = <1>; > #size-cells = <0>; > > + clk_0: clk_0 { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <50000000>; > + clock-output-names = "clk_0-clk"; > + }; > + > osc1: osc1 { > #clock-cells = <0>; > compatible = "fixed-clock"; > @@ -529,11 +536,11 @@ > }; > }; > > - fpga_bridge0: fpga_bridge at ff400000 { > + fpga_bridge0: fpga_bridge at ff200000 { > compatible = "altr,socfpga-lwhps2fpga-bridge"; > - reg = <0xff400000 0x100000>; > + reg = <0xff200000 0x00200000>; > resets = <&rst LWHPS2FPGA_RESET>; > - clocks = <&l4_main_clk>; > + clocks = <&clk_0>; > }; > Why this change? This looks wrong and unrelated. The LWHPS2FPGA bridge is at 0xff400000, so it is correct the way it is or not? > fpga_bridge1: fpga_bridge at ff500000 { > diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts > index 155829f..f99576b 100644 > --- a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts > +++ b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts > @@ -68,6 +68,7 @@ > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > }; > + > }; ??? (...) Best regards, Steffen -- Pengutronix e.K. | Steffen Trumtrar | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2017-06-06 6:41 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-02 23:52 [PATCHv3 0/4] Add Altera I2C Controller Driver thor.thayer 2017-06-02 23:52 ` thor.thayer at linux.intel.com 2017-06-02 23:52 ` thor.thayer-VuQAYsv1563Yd54FQh9/CA 2017-06-02 23:52 ` [PATCHv3 1/4] ARM: dts: socfpga: Add Altera I2C Controller to CycloneV thor.thayer 2017-06-02 23:52 ` thor.thayer at linux.intel.com 2017-06-02 23:52 ` thor.thayer 2017-06-06 6:40 ` Steffen Trumtrar [this message] 2017-06-06 6:40 ` Steffen Trumtrar 2017-06-07 20:45 ` Thor Thayer 2017-06-07 20:45 ` Thor Thayer 2017-06-07 20:45 ` Thor Thayer 2017-06-02 23:52 ` [PATCHv3 2/4] MAINTAINERS: Add Altera I2C Controller Driver thor.thayer 2017-06-02 23:52 ` thor.thayer at linux.intel.com 2017-06-02 23:52 ` [PATCHv3 3/4] dt-bindings: i2c: Add Altera I2C Controller thor.thayer 2017-06-02 23:52 ` thor.thayer at linux.intel.com 2017-06-08 22:21 ` Rob Herring 2017-06-08 22:21 ` Rob Herring 2017-06-02 23:52 ` [PATCHv3 4/4] i2c: altera: Add Altera I2C Controller driver thor.thayer 2017-06-02 23:52 ` thor.thayer at linux.intel.com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=73vao9vcsq.fsf@pengutronix.de \ --to=s.trumtrar@pengutronix.de \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=dinguyen@kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mchehab@kernel.org \ --cc=robh+dt@kernel.org \ --cc=thor.thayer@linux.intel.com \ --cc=wsa@the-dreams.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.