From: Markus Elfring <Markus.Elfring@web.de>
To: Muchun Song <songmuchun@bytedance.com>,
Xiongchun duan <duanxiongchun@bytedance.com>,
linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/ksm: Fix a null pointer dereference
Date: Tue, 14 Apr 2020 09:14:17 +0200 [thread overview]
Message-ID: <740ca6b2-d3c9-02a2-9d81-c212bf9772e2@web.de> (raw)
> The find_mergeable_vma can return NULL. In this case, it leads
> to crash when we access vma->vm_mm(which's offset is 0x40) in
I suggest to improve the commit message.
* Wording alternative:
to a crash when we access vma->vm_mm (its offset is 0x40) in
* Can a function name be nicer than the information “at 0000000000000040”
in the patch subject?
* Would you like to add the tag “Fixes” to the change description?
Regards,
Markus
next reply other threads:[~2020-04-14 7:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 7:14 Markus Elfring [this message]
2020-04-14 7:19 ` [External] Re: [PATCH] mm/ksm: Fix a null pointer dereference Muchun Song
2020-04-14 7:19 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=740ca6b2-d3c9-02a2-9d81-c212bf9772e2@web.de \
--to=markus.elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=duanxiongchun@bytedance.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.