All of lore.kernel.org
 help / color / mirror / Atom feed
From: Muchun Song <songmuchun@bytedance.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Xiongchun duan <duanxiongchun@bytedance.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [External] Re: [PATCH] mm/ksm: Fix a null pointer dereference
Date: Tue, 14 Apr 2020 15:19:17 +0800	[thread overview]
Message-ID: <CAMZfGtWEGuGCP1hNK7o82B_R_JQHFt7hfn+mRP+pOfUF7ygmZA@mail.gmail.com> (raw)
In-Reply-To: <740ca6b2-d3c9-02a2-9d81-c212bf9772e2@web.de>

On Tue, Apr 14, 2020 at 3:14 PM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > The find_mergeable_vma can return NULL. In this case, it leads
> > to crash when we access vma->vm_mm(which's offset is 0x40) in
>
> I suggest to improve the commit message.
>
> * Wording alternative:
>   to a crash when we access vma->vm_mm (its offset is 0x40) in
>
> * Can a function name be nicer than the information “at 0000000000000040”
>   in the patch subject?
>
> * Would you like to add the tag “Fixes” to the change description?
>

Thanks for your suggestion. I will send a v2 patch later.


-- 
Yours,
Muchun

  reply	other threads:[~2020-04-14  7:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14  7:14 [PATCH] mm/ksm: Fix a null pointer dereference Markus Elfring
2020-04-14  7:19 ` Muchun Song [this message]
2020-04-14  7:19   ` [External] " Muchun Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMZfGtWEGuGCP1hNK7o82B_R_JQHFt7hfn+mRP+pOfUF7ygmZA@mail.gmail.com \
    --to=songmuchun@bytedance.com \
    --cc=Markus.Elfring@web.de \
    --cc=akpm@linux-foundation.org \
    --cc=duanxiongchun@bytedance.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.