* [PATCH] tools: mkeficapsule: remove duplicated code
@ 2022-02-16 1:49 AKASHI Takahiro
2022-02-19 9:20 ` Heinrich Schuchardt
0 siblings, 1 reply; 2+ messages in thread
From: AKASHI Takahiro @ 2022-02-16 1:49 UTC (permalink / raw)
To: trini, xypron.glpk; +Cc: u-boot, AKASHI Takahiro
That code is mistakenly duplicated due to copy-and-paste error.
Just remove it.
Fixes: CID 348360
Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
tools/mkeficapsule.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/mkeficapsule.c b/tools/mkeficapsule.c
index f7590e482f10..c118335b93bd 100644
--- a/tools/mkeficapsule.c
+++ b/tools/mkeficapsule.c
@@ -210,8 +210,6 @@ static int create_auth_data(struct auth_context *ctx)
cert.size = file_size;
ret = read_bin_file(ctx->key_file, &key.data, &file_size);
- if (ret < 0)
- return -1;
if (ret < 0)
return -1;
if (file_size > UINT_MAX)
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tools: mkeficapsule: remove duplicated code
2022-02-16 1:49 [PATCH] tools: mkeficapsule: remove duplicated code AKASHI Takahiro
@ 2022-02-19 9:20 ` Heinrich Schuchardt
0 siblings, 0 replies; 2+ messages in thread
From: Heinrich Schuchardt @ 2022-02-19 9:20 UTC (permalink / raw)
To: AKASHI Takahiro, trini; +Cc: u-boot
On 2/16/22 02:49, AKASHI Takahiro wrote:
> That code is mistakenly duplicated due to copy-and-paste error.
> Just remove it.
>
> Fixes: CID 348360
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> tools/mkeficapsule.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/mkeficapsule.c b/tools/mkeficapsule.c
> index f7590e482f10..c118335b93bd 100644
> --- a/tools/mkeficapsule.c
> +++ b/tools/mkeficapsule.c
> @@ -210,8 +210,6 @@ static int create_auth_data(struct auth_context *ctx)
> cert.size = file_size;
>
> ret = read_bin_file(ctx->key_file, &key.data, &file_size);
> - if (ret < 0)
> - return -1;
> if (ret < 0)
> return -1;
> if (file_size > UINT_MAX)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-19 9:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-16 1:49 [PATCH] tools: mkeficapsule: remove duplicated code AKASHI Takahiro
2022-02-19 9:20 ` Heinrich Schuchardt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.