All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] arm64: dts: juno: Add dma-ranges property
@ 2017-01-18 12:12 ` Robin Murphy
  0 siblings, 0 replies; 10+ messages in thread
From: Robin Murphy @ 2017-01-18 12:12 UTC (permalink / raw)
  To: linux-arm-kernel, devicetree; +Cc: lorenzo.pieralisi, liviu.dudau, sudeep.holla

The interconnects around Juno have a 40-bit address width, and DMA
masters have no restrictions beyond their own individual limitations.
Describe this to ensure that DT-based DMA masks get set up correctly
for all devices capable of 40-bit addressing.

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---

These apply on top of Sudeep's for-next/updates/juno branch, which
supercedes the .dtsi cleanup I had locally to make this one work.

Robin.

 arch/arm64/boot/dts/arm/juno-base.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
index 44db27776b9d..5e7640d6ec69 100644
--- a/arch/arm64/boot/dts/arm/juno-base.dtsi
+++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
@@ -4,6 +4,7 @@
 	/*
 	 *  Devices shared by all Juno boards
 	 */
+	dma-ranges = <0 0 0 0 0x100 0>;
 
 	memtimer: timer@2a810000 {
 		compatible = "arm,armv7-timer-mem";
-- 
2.11.0.dirty

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 1/3] arm64: dts: juno: Add dma-ranges property
@ 2017-01-18 12:12 ` Robin Murphy
  0 siblings, 0 replies; 10+ messages in thread
From: Robin Murphy @ 2017-01-18 12:12 UTC (permalink / raw)
  To: linux-arm-kernel

The interconnects around Juno have a 40-bit address width, and DMA
masters have no restrictions beyond their own individual limitations.
Describe this to ensure that DT-based DMA masks get set up correctly
for all devices capable of 40-bit addressing.

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---

These apply on top of Sudeep's for-next/updates/juno branch, which
supercedes the .dtsi cleanup I had locally to make this one work.

Robin.

 arch/arm64/boot/dts/arm/juno-base.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
index 44db27776b9d..5e7640d6ec69 100644
--- a/arch/arm64/boot/dts/arm/juno-base.dtsi
+++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
@@ -4,6 +4,7 @@
 	/*
 	 *  Devices shared by all Juno boards
 	 */
+	dma-ranges = <0 0 0 0 0x100 0>;
 
 	memtimer: timer at 2a810000 {
 		compatible = "arm,armv7-timer-mem";
-- 
2.11.0.dirty

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/3] arm64: dts: juno: Add ETR SMMU power domain
  2017-01-18 12:12 ` Robin Murphy
@ 2017-01-18 12:12     ` Robin Murphy
  -1 siblings, 0 replies; 10+ messages in thread
From: Robin Murphy @ 2017-01-18 12:12 UTC (permalink / raw)
  To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA
  Cc: sudeep.holla-5wv7dgnIgG8, lorenzo.pieralisi-5wv7dgnIgG8,
	liviu.dudau-5wv7dgnIgG8

It is not at all clear from the documentation, but straightforward to
determine in practice, that the ETR SMMU is actually in the DEBUGSYS
power domain. Add that to the DT so that anyone brave enough to enable
said SMMU doesn't experience a system lockup on boot, especially a
sneaky one which goes away as soon as you connect an external debugger
to have a look at where it's stuck (thus powering up DEBUGSYS by other
means and allowing it to make progress again before actually halting...)

Signed-off-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
---
 arch/arm64/boot/dts/arm/juno-base.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
index 5e7640d6ec69..37225dfdc995 100644
--- a/arch/arm64/boot/dts/arm/juno-base.dtsi
+++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
@@ -52,6 +52,7 @@
 		#iommu-cells = <1>;
 		#global-interrupts = <1>;
 		dma-coherent;
+		power-domains = <&scpi_devpd 0>;
 		status = "disabled";
 	};
 
-- 
2.11.0.dirty

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/3] arm64: dts: juno: Add ETR SMMU power domain
@ 2017-01-18 12:12     ` Robin Murphy
  0 siblings, 0 replies; 10+ messages in thread
From: Robin Murphy @ 2017-01-18 12:12 UTC (permalink / raw)
  To: linux-arm-kernel

It is not at all clear from the documentation, but straightforward to
determine in practice, that the ETR SMMU is actually in the DEBUGSYS
power domain. Add that to the DT so that anyone brave enough to enable
said SMMU doesn't experience a system lockup on boot, especially a
sneaky one which goes away as soon as you connect an external debugger
to have a look at where it's stuck (thus powering up DEBUGSYS by other
means and allowing it to make progress again before actually halting...)

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
 arch/arm64/boot/dts/arm/juno-base.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
index 5e7640d6ec69..37225dfdc995 100644
--- a/arch/arm64/boot/dts/arm/juno-base.dtsi
+++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
@@ -52,6 +52,7 @@
 		#iommu-cells = <1>;
 		#global-interrupts = <1>;
 		dma-coherent;
+		power-domains = <&scpi_devpd 0>;
 		status = "disabled";
 	};
 
-- 
2.11.0.dirty

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 3/3] arm64: dts: juno: Remove Motherboard USB node
  2017-01-18 12:12 ` Robin Murphy
@ 2017-01-18 12:12     ` Robin Murphy
  -1 siblings, 0 replies; 10+ messages in thread
From: Robin Murphy @ 2017-01-18 12:12 UTC (permalink / raw)
  To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA
  Cc: sudeep.holla-5wv7dgnIgG8, lorenzo.pieralisi-5wv7dgnIgG8,
	liviu.dudau-5wv7dgnIgG8

The first batch of Juno boards included a discrete USB controller chip
as a contingency in case of issues with the USB 2.0 IP integrated into
the SoC. As it turned out, the latter was fine, and to the best of my
knowledge the motherboard USB was never even brought up and validated.

Since this also isn't present on later boards, and uses a compatible
string undocumented and unmatched by any driver in the kernel, let's
just tidy it away for ever to avoid any confusion.

Signed-off-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
---
 arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/arch/arm64/boot/dts/arm/juno-motherboard.dtsi b/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
index 3ad4c3000611..098601657f82 100644
--- a/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
+++ b/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
@@ -131,13 +131,6 @@
 				vddvario-supply = <&mb_fixed_3v3>;
 			};
 
-			usb@5,00000000 {
-				compatible = "nxp,usb-isp1763";
-				reg = <5 0x00000000 0x20000>;
-				bus-width = <16>;
-				interrupts = <4>;
-			};
-
 			iofpga@3,00000000 {
 				compatible = "simple-bus";
 				#address-cells = <1>;
-- 
2.11.0.dirty

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 3/3] arm64: dts: juno: Remove Motherboard USB node
@ 2017-01-18 12:12     ` Robin Murphy
  0 siblings, 0 replies; 10+ messages in thread
From: Robin Murphy @ 2017-01-18 12:12 UTC (permalink / raw)
  To: linux-arm-kernel

The first batch of Juno boards included a discrete USB controller chip
as a contingency in case of issues with the USB 2.0 IP integrated into
the SoC. As it turned out, the latter was fine, and to the best of my
knowledge the motherboard USB was never even brought up and validated.

Since this also isn't present on later boards, and uses a compatible
string undocumented and unmatched by any driver in the kernel, let's
just tidy it away for ever to avoid any confusion.

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
 arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/arch/arm64/boot/dts/arm/juno-motherboard.dtsi b/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
index 3ad4c3000611..098601657f82 100644
--- a/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
+++ b/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
@@ -131,13 +131,6 @@
 				vddvario-supply = <&mb_fixed_3v3>;
 			};
 
-			usb at 5,00000000 {
-				compatible = "nxp,usb-isp1763";
-				reg = <5 0x00000000 0x20000>;
-				bus-width = <16>;
-				interrupts = <4>;
-			};
-
 			iofpga at 3,00000000 {
 				compatible = "simple-bus";
 				#address-cells = <1>;
-- 
2.11.0.dirty

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/3] arm64: dts: juno: Remove Motherboard USB node
  2017-01-18 12:12     ` Robin Murphy
@ 2017-01-18 12:38       ` Local user for Liviu Dudau
  -1 siblings, 0 replies; 10+ messages in thread
From: Local user for Liviu Dudau @ 2017-01-18 12:38 UTC (permalink / raw)
  To: Robin Murphy
  Cc: devicetree, lorenzo.pieralisi, linux-arm-kernel, sudeep.holla

Hi Robin,

On Wed, Jan 18, 2017 at 12:12:52PM +0000, Robin Murphy wrote:
> The first batch of Juno boards included a discrete USB controller chip
> as a contingency in case of issues with the USB 2.0 IP integrated into
> the SoC. As it turned out, the latter was fine, and to the best of my
> knowledge the motherboard USB was never even brought up and validated.
> 
> Since this also isn't present on later boards, and uses a compatible
> string undocumented and unmatched by any driver in the kernel, let's
> just tidy it away for ever to avoid any confusion.
> 
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>

For all 3 patches:

Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>

Thanks,
Liviu

> ---
>  arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/arm/juno-motherboard.dtsi b/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
> index 3ad4c3000611..098601657f82 100644
> --- a/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
> +++ b/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
> @@ -131,13 +131,6 @@
>  				vddvario-supply = <&mb_fixed_3v3>;
>  			};
>  
> -			usb@5,00000000 {
> -				compatible = "nxp,usb-isp1763";
> -				reg = <5 0x00000000 0x20000>;
> -				bus-width = <16>;
> -				interrupts = <4>;
> -			};
> -
>  			iofpga@3,00000000 {
>  				compatible = "simple-bus";
>  				#address-cells = <1>;
> -- 
> 2.11.0.dirty
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 3/3] arm64: dts: juno: Remove Motherboard USB node
@ 2017-01-18 12:38       ` Local user for Liviu Dudau
  0 siblings, 0 replies; 10+ messages in thread
From: Local user for Liviu Dudau @ 2017-01-18 12:38 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Robin,

On Wed, Jan 18, 2017 at 12:12:52PM +0000, Robin Murphy wrote:
> The first batch of Juno boards included a discrete USB controller chip
> as a contingency in case of issues with the USB 2.0 IP integrated into
> the SoC. As it turned out, the latter was fine, and to the best of my
> knowledge the motherboard USB was never even brought up and validated.
> 
> Since this also isn't present on later boards, and uses a compatible
> string undocumented and unmatched by any driver in the kernel, let's
> just tidy it away for ever to avoid any confusion.
> 
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>

For all 3 patches:

Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>

Thanks,
Liviu

> ---
>  arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/arm/juno-motherboard.dtsi b/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
> index 3ad4c3000611..098601657f82 100644
> --- a/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
> +++ b/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
> @@ -131,13 +131,6 @@
>  				vddvario-supply = <&mb_fixed_3v3>;
>  			};
>  
> -			usb at 5,00000000 {
> -				compatible = "nxp,usb-isp1763";
> -				reg = <5 0x00000000 0x20000>;
> -				bus-width = <16>;
> -				interrupts = <4>;
> -			};
> -
>  			iofpga at 3,00000000 {
>  				compatible = "simple-bus";
>  				#address-cells = <1>;
> -- 
> 2.11.0.dirty
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/3] arm64: dts: juno: Remove Motherboard USB node
  2017-01-18 12:38       ` Local user for Liviu Dudau
@ 2017-01-18 14:18         ` Sudeep Holla
  -1 siblings, 0 replies; 10+ messages in thread
From: Sudeep Holla @ 2017-01-18 14:18 UTC (permalink / raw)
  To: Local user for Liviu Dudau, Robin Murphy
  Cc: devicetree, lorenzo.pieralisi, linux-arm-kernel, Sudeep Holla



On 18/01/17 12:38, Local user for Liviu Dudau wrote:
> Hi Robin,
> 
> On Wed, Jan 18, 2017 at 12:12:52PM +0000, Robin Murphy wrote:
>> The first batch of Juno boards included a discrete USB controller chip
>> as a contingency in case of issues with the USB 2.0 IP integrated into
>> the SoC. As it turned out, the latter was fine, and to the best of my
>> knowledge the motherboard USB was never even brought up and validated.
>>
>> Since this also isn't present on later boards, and uses a compatible
>> string undocumented and unmatched by any driver in the kernel, let's
>> just tidy it away for ever to avoid any confusion.
>>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> 
> For all 3 patches:
> 
> Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>
> 

Thanks Liviu (or/and Local user for Liviu Dudau :))

All 3 patches applied to [1]

-- 
Regards,
Sudeep

[1] git.kernel.org/sudeep.holla/linux/h/for-next/updates/juno

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 3/3] arm64: dts: juno: Remove Motherboard USB node
@ 2017-01-18 14:18         ` Sudeep Holla
  0 siblings, 0 replies; 10+ messages in thread
From: Sudeep Holla @ 2017-01-18 14:18 UTC (permalink / raw)
  To: linux-arm-kernel



On 18/01/17 12:38, Local user for Liviu Dudau wrote:
> Hi Robin,
> 
> On Wed, Jan 18, 2017 at 12:12:52PM +0000, Robin Murphy wrote:
>> The first batch of Juno boards included a discrete USB controller chip
>> as a contingency in case of issues with the USB 2.0 IP integrated into
>> the SoC. As it turned out, the latter was fine, and to the best of my
>> knowledge the motherboard USB was never even brought up and validated.
>>
>> Since this also isn't present on later boards, and uses a compatible
>> string undocumented and unmatched by any driver in the kernel, let's
>> just tidy it away for ever to avoid any confusion.
>>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> 
> For all 3 patches:
> 
> Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>
> 

Thanks Liviu (or/and Local user for Liviu Dudau :))

All 3 patches applied to [1]

-- 
Regards,
Sudeep

[1] git.kernel.org/sudeep.holla/linux/h/for-next/updates/juno

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2017-01-18 14:18 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-18 12:12 [PATCH 1/3] arm64: dts: juno: Add dma-ranges property Robin Murphy
2017-01-18 12:12 ` Robin Murphy
     [not found] ` <74595d6d866518db7cfabc39b4cf9b54d3be9bde.1484741104.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2017-01-18 12:12   ` [PATCH 2/3] arm64: dts: juno: Add ETR SMMU power domain Robin Murphy
2017-01-18 12:12     ` Robin Murphy
2017-01-18 12:12   ` [PATCH 3/3] arm64: dts: juno: Remove Motherboard USB node Robin Murphy
2017-01-18 12:12     ` Robin Murphy
2017-01-18 12:38     ` Local user for Liviu Dudau
2017-01-18 12:38       ` Local user for Liviu Dudau
2017-01-18 14:18       ` Sudeep Holla
2017-01-18 14:18         ` Sudeep Holla

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.