From: Florian Fainelli <f.fainelli@gmail.com> To: netdev@vger.kernel.org Cc: idosch@mellanox.com, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, bridge@lists.linux-foundation.org, jiri@mellanox.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: Re: [PATCH net-next v2 00/16] net: Remove switchdev_ops Date: Sun, 10 Feb 2019 12:44:47 -0800 [thread overview] Message-ID: <746bce08-5b5f-70c9-efb7-33b067929198@gmail.com> (raw) In-Reply-To: <20190210175105.31629-1-f.fainelli@gmail.com> Le 2/10/19 à 9:50 AM, Florian Fainelli a écrit : > Hi all, > > This patch series finishes by the removal of switchdev_ops. To get there > we need to do a few things: > > - get rid of the one and only call to switchdev_port_attr_get() which is > used to fetch the device's bridge port flags capabilities, instead we > can just check what flags are being programmed during the prepare > phase > > - once we get rid of getting switchdev port attributes we convert the > setting of such attributes using a blocking notifier > > And then remove switchdev_ops completely. > > Please review and let me know what you think! I am going to submit a v3 which moves the port_attr_{get,set} to a switchdev notifier, but does not yet get rid of switchdev_port_attr_get() entirely since there is not a clear path yet to split the setting between non-sleeping and sleeping context. > > Changes in v2: > - fixed bisectability issues in patch #15 > - added Acked-by from Jiri where necessary > - fixed a few minor issues according to Jiri's feedback: > - rename port_attr_event -> port_attr_set_event > - moved SWITCHDEV_PORT_ATTR_SET closer to other blocking events > > Florian Fainelli (16): > Documentation: networking: switchdev: Update port parent ID section > mlxsw: spectrum: Check bridge flags during prepare phase > staging: fsl-dpaa2: ethsw: Check bridge port flags during set > net: dsa: Add setter for SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS > rocker: Check bridge flags during prepare phase > net: bridge: Stop calling switchdev_port_attr_get() > net: Remove SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT > net: Get rid of switchdev_port_attr_get() > switchdev: Add SWITCHDEV_PORT_ATTR_SET > rocker: Handle SWITCHDEV_PORT_ATTR_SET > net: dsa: Handle SWITCHDEV_PORT_ATTR_SET > mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_SET > net: mscc: ocelot: Handle SWITCHDEV_PORT_ATTR_SET > staging: fsl-dpaa2: ethsw: Handle SWITCHDEV_PORT_ATTR_SET > net: switchdev: Replace port attr set SDO with a notification > net: Remove switchdev_ops > > Documentation/networking/switchdev.txt | 15 ++- > .../net/ethernet/mellanox/mlxsw/spectrum.c | 12 --- > .../net/ethernet/mellanox/mlxsw/spectrum.h | 2 - > .../mellanox/mlxsw/spectrum_switchdev.c | 69 ++++---------- > drivers/net/ethernet/mscc/ocelot.c | 21 +++- > drivers/net/ethernet/rocker/rocker_main.c | 95 ++++++++----------- > drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 48 ++++------ > include/linux/netdevice.h | 3 - > include/net/switchdev.h | 36 ++----- > net/bridge/br_switchdev.c | 20 +--- > net/dsa/dsa_priv.h | 3 + > net/dsa/port.c | 10 ++ > net/dsa/slave.c | 40 ++++---- > net/switchdev/switchdev.c | 92 +++++------------- > 14 files changed, 170 insertions(+), 296 deletions(-) > -- Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com> To: netdev@vger.kernel.org Cc: devel@driverdev.osuosl.org, andrew@lunn.ch, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, idosch@mellanox.com, jiri@mellanox.com, vivien.didelot@gmail.com Subject: Re: [Bridge] [PATCH net-next v2 00/16] net: Remove switchdev_ops Date: Sun, 10 Feb 2019 12:44:47 -0800 [thread overview] Message-ID: <746bce08-5b5f-70c9-efb7-33b067929198@gmail.com> (raw) In-Reply-To: <20190210175105.31629-1-f.fainelli@gmail.com> Le 2/10/19 à 9:50 AM, Florian Fainelli a écrit : > Hi all, > > This patch series finishes by the removal of switchdev_ops. To get there > we need to do a few things: > > - get rid of the one and only call to switchdev_port_attr_get() which is > used to fetch the device's bridge port flags capabilities, instead we > can just check what flags are being programmed during the prepare > phase > > - once we get rid of getting switchdev port attributes we convert the > setting of such attributes using a blocking notifier > > And then remove switchdev_ops completely. > > Please review and let me know what you think! I am going to submit a v3 which moves the port_attr_{get,set} to a switchdev notifier, but does not yet get rid of switchdev_port_attr_get() entirely since there is not a clear path yet to split the setting between non-sleeping and sleeping context. > > Changes in v2: > - fixed bisectability issues in patch #15 > - added Acked-by from Jiri where necessary > - fixed a few minor issues according to Jiri's feedback: > - rename port_attr_event -> port_attr_set_event > - moved SWITCHDEV_PORT_ATTR_SET closer to other blocking events > > Florian Fainelli (16): > Documentation: networking: switchdev: Update port parent ID section > mlxsw: spectrum: Check bridge flags during prepare phase > staging: fsl-dpaa2: ethsw: Check bridge port flags during set > net: dsa: Add setter for SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS > rocker: Check bridge flags during prepare phase > net: bridge: Stop calling switchdev_port_attr_get() > net: Remove SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT > net: Get rid of switchdev_port_attr_get() > switchdev: Add SWITCHDEV_PORT_ATTR_SET > rocker: Handle SWITCHDEV_PORT_ATTR_SET > net: dsa: Handle SWITCHDEV_PORT_ATTR_SET > mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_SET > net: mscc: ocelot: Handle SWITCHDEV_PORT_ATTR_SET > staging: fsl-dpaa2: ethsw: Handle SWITCHDEV_PORT_ATTR_SET > net: switchdev: Replace port attr set SDO with a notification > net: Remove switchdev_ops > > Documentation/networking/switchdev.txt | 15 ++- > .../net/ethernet/mellanox/mlxsw/spectrum.c | 12 --- > .../net/ethernet/mellanox/mlxsw/spectrum.h | 2 - > .../mellanox/mlxsw/spectrum_switchdev.c | 69 ++++---------- > drivers/net/ethernet/mscc/ocelot.c | 21 +++- > drivers/net/ethernet/rocker/rocker_main.c | 95 ++++++++----------- > drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 48 ++++------ > include/linux/netdevice.h | 3 - > include/net/switchdev.h | 36 ++----- > net/bridge/br_switchdev.c | 20 +--- > net/dsa/dsa_priv.h | 3 + > net/dsa/port.c | 10 ++ > net/dsa/slave.c | 40 ++++---- > net/switchdev/switchdev.c | 92 +++++------------- > 14 files changed, 170 insertions(+), 296 deletions(-) > -- Florian
next prev parent reply other threads:[~2019-02-10 20:44 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-10 17:50 [PATCH net-next v2 00/16] net: Remove switchdev_ops Florian Fainelli 2019-02-10 17:50 ` [Bridge] " Florian Fainelli 2019-02-10 17:50 ` [PATCH net-next v2 01/16] Documentation: networking: switchdev: Update port parent ID section Florian Fainelli 2019-02-10 17:50 ` [Bridge] " Florian Fainelli 2019-02-10 17:50 ` [PATCH net-next v2 02/16] mlxsw: spectrum: Check bridge flags during prepare phase Florian Fainelli 2019-02-10 17:50 ` [Bridge] " Florian Fainelli 2019-02-10 17:50 ` [PATCH net-next v2 03/16] staging: fsl-dpaa2: ethsw: Check bridge port flags during set Florian Fainelli 2019-02-10 17:50 ` [Bridge] " Florian Fainelli 2019-02-10 17:50 ` [PATCH net-next v2 04/16] net: dsa: Add setter for SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS Florian Fainelli 2019-02-10 17:50 ` [Bridge] " Florian Fainelli 2019-02-10 17:50 ` [PATCH net-next v2 05/16] rocker: Check bridge flags during prepare phase Florian Fainelli 2019-02-10 17:50 ` [Bridge] " Florian Fainelli 2019-02-10 17:50 ` [PATCH net-next v2 06/16] net: bridge: Stop calling switchdev_port_attr_get() Florian Fainelli 2019-02-10 17:50 ` [Bridge] " Florian Fainelli 2019-02-10 19:05 ` Ido Schimmel 2019-02-10 19:05 ` [Bridge] " Ido Schimmel 2019-02-10 19:34 ` Florian Fainelli 2019-02-10 19:34 ` [Bridge] " Florian Fainelli 2019-02-12 14:20 ` Ido Schimmel 2019-02-12 14:20 ` [Bridge] " Ido Schimmel 2019-02-10 17:50 ` [PATCH net-next v2 07/16] net: Remove SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT Florian Fainelli 2019-02-10 17:50 ` [Bridge] " Florian Fainelli 2019-02-10 17:50 ` [PATCH net-next v2 08/16] net: Get rid of switchdev_port_attr_get() Florian Fainelli 2019-02-10 17:50 ` [Bridge] " Florian Fainelli 2019-02-10 17:50 ` [PATCH net-next v2 09/16] switchdev: Add SWITCHDEV_PORT_ATTR_SET Florian Fainelli 2019-02-10 17:50 ` [Bridge] " Florian Fainelli 2019-02-10 17:50 ` [PATCH net-next v2 10/16] rocker: Handle SWITCHDEV_PORT_ATTR_SET Florian Fainelli 2019-02-10 17:50 ` [Bridge] " Florian Fainelli 2019-02-10 17:51 ` [PATCH net-next v2 11/16] net: dsa: " Florian Fainelli 2019-02-10 17:51 ` [Bridge] " Florian Fainelli 2019-02-10 17:51 ` [PATCH net-next v2 12/16] mlxsw: spectrum_switchdev: " Florian Fainelli 2019-02-10 17:51 ` [Bridge] " Florian Fainelli 2019-02-10 17:51 ` [PATCH net-next v2 13/16] net: mscc: ocelot: " Florian Fainelli 2019-02-10 17:51 ` [Bridge] " Florian Fainelli 2019-02-10 17:51 ` [PATCH net-next v2 14/16] staging: fsl-dpaa2: ethsw: " Florian Fainelli 2019-02-10 17:51 ` [Bridge] " Florian Fainelli 2019-02-10 17:51 ` [PATCH net-next v2 15/16] net: switchdev: Replace port attr set SDO with a notification Florian Fainelli 2019-02-10 17:51 ` [Bridge] " Florian Fainelli 2019-02-10 17:51 ` [PATCH net-next v2 16/16] net: Remove switchdev_ops Florian Fainelli 2019-02-10 17:51 ` [Bridge] " Florian Fainelli 2019-02-10 20:44 ` Florian Fainelli [this message] 2019-02-10 20:44 ` [Bridge] [PATCH net-next v2 00/16] " Florian Fainelli 2019-02-10 20:51 ` David Miller 2019-02-10 20:51 ` [Bridge] " David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=746bce08-5b5f-70c9-efb7-33b067929198@gmail.com \ --to=f.fainelli@gmail.com \ --cc=andrew@lunn.ch \ --cc=bridge@lists.linux-foundation.org \ --cc=devel@driverdev.osuosl.org \ --cc=idosch@mellanox.com \ --cc=jiri@mellanox.com \ --cc=linux-kernel@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=vivien.didelot@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.