* [U-Boot] What's wrong with this code?
@ 2010-03-26 8:40 Dennis Semakin
2010-03-26 9:30 ` Detlev Zundel
0 siblings, 1 reply; 5+ messages in thread
From: Dennis Semakin @ 2010-03-26 8:40 UTC (permalink / raw)
To: u-boot
Hello,
Months ago I had a problem with network on Colibri PXA320. A applied all patches from Marek's web
site http://openpxa.sourceforge.net/, but net didn't work at all in U-Boot and in Linux.
When I tried to read/write into/from ethernet chip I/O registers, that was mapped in the memory, system hung.
See http://lists.infradead.org/pipermail/linux-arm-kernel/2010-February/009279.html
Solution was prompted by Daniel Mack (Thanks Daniel).
Add this code to lowlevel_init function in U-Boot:
//begin
ldr r0, =CKENA
ldr r1, [r0]
orr r1, r1, #(CKENA_4_NAND | CKENA_9_SMC)
str r1, [r0]
ldr r1, [r0]
//end
After that network has worked in u-boot and in linux.
Also he said: "It did see this code, but it wasn't taken for upstream, for reasons I
cannot remember..."
What's wrong with this code?
Thanks,
Best Regards
Dennis Semakin
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] What's wrong with this code?
2010-03-26 8:40 [U-Boot] What's wrong with this code? Dennis Semakin
@ 2010-03-26 9:30 ` Detlev Zundel
2010-03-26 9:58 ` Dennis Semakin
2010-03-26 14:28 ` Dennis Semakin
0 siblings, 2 replies; 5+ messages in thread
From: Detlev Zundel @ 2010-03-26 9:30 UTC (permalink / raw)
To: u-boot
Hi Dennis,
> Hello,
> Months ago I had a problem with network on Colibri PXA320. A applied all patches from Marek's web
> site http://openpxa.sourceforge.net/, but net didn't work at all in U-Boot and in Linux.
> When I tried to read/write into/from ethernet chip I/O registers, that was mapped in the memory, system hung.
>
> See http://lists.infradead.org/pipermail/linux-arm-kernel/2010-February/009279.html
>
> Solution was prompted by Daniel Mack (Thanks Daniel).
>
> Add this code to lowlevel_init function in U-Boot:
> //begin
> ldr r0, =CKENA
> ldr r1, [r0]
> orr r1, r1, #(CKENA_4_NAND | CKENA_9_SMC)
> str r1, [r0]
> ldr r1, [r0]
> //end
>
> After that network has worked in u-boot and in linux.
> Also he said: "It did see this code, but it wasn't taken for upstream, for reasons I
> cannot remember..."
>
> What's wrong with this code?
Why don't you wrap this change into a patch and post it here[1] on the
mailing list. If there are reasons not to merge it, the respective
people will speak up.
Also note in the commit message that this fixes a real bug for you and
what hardware you tested it on.
Cheers
Detlev
[1] http://www.denx.de/wiki/U-Boot/Patches
--
If we knew what it was we were doing, we wouldn't call it research.
-- Einstein
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] What's wrong with this code?
2010-03-26 9:30 ` Detlev Zundel
@ 2010-03-26 9:58 ` Dennis Semakin
2010-03-26 10:09 ` Detlev Zundel
2010-03-26 14:28 ` Dennis Semakin
1 sibling, 1 reply; 5+ messages in thread
From: Dennis Semakin @ 2010-03-26 9:58 UTC (permalink / raw)
To: u-boot
Hi
>
> Why don't you wrap this change into a patch and post it here[1] on the
> mailing list. If there are reasons not to merge it, the respective
> people will speak up.
Because it's not my patch. I didn't write it. I did only copy and paste.
Best Regards,
Dennis
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] What's wrong with this code?
2010-03-26 9:58 ` Dennis Semakin
@ 2010-03-26 10:09 ` Detlev Zundel
0 siblings, 0 replies; 5+ messages in thread
From: Detlev Zundel @ 2010-03-26 10:09 UTC (permalink / raw)
To: u-boot
Hi Dennis,
> Hi
>>
>> Why don't you wrap this change into a patch and post it here[1] on the
>> mailing list. If there are reasons not to merge it, the respective
>> people will speak up.
>
> Because it's not my patch. I didn't write it. I did only copy and paste.
That's not a big problem. Depending on how correct you want to be, you
could either use "git commit --author <original author>" to commit tha
change into your tree and then use git-send-email to post the patch
here. The git toolchain will correctly keep the authors name even if
you post the patches. Note that patches regularly get (re-)posted by
people not being the original author. As long as it is correct from a
copyright point of view, this is not a problem.
On such a small change however, you may also simply put a short "code
originally by ..." in the commit message.
The _relevant_ part is that people here need a patch to do a proper
review of the change you propose.
Cheers
Detlev
--
You live and learn
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] What's wrong with this code?
2010-03-26 9:30 ` Detlev Zundel
2010-03-26 9:58 ` Dennis Semakin
@ 2010-03-26 14:28 ` Dennis Semakin
1 sibling, 0 replies; 5+ messages in thread
From: Dennis Semakin @ 2010-03-26 14:28 UTC (permalink / raw)
To: u-boot
Hi,
OK, thanks, I'll try
Best Regards,
Dennis Semakin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-03-26 14:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-26 8:40 [U-Boot] What's wrong with this code? Dennis Semakin
2010-03-26 9:30 ` Detlev Zundel
2010-03-26 9:58 ` Dennis Semakin
2010-03-26 10:09 ` Detlev Zundel
2010-03-26 14:28 ` Dennis Semakin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.