* [PATCH v2] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB
@ 2018-08-28 13:21 ` Liu Xiang
0 siblings, 0 replies; 5+ messages in thread
From: Liu Xiang @ 2018-08-28 13:21 UTC (permalink / raw)
To: linux-mtd
Cc: linux-kernel, stable, han.xu, marek.vasut, dwmw2,
computersforpeace, boris.brezillon, richard, liuxiang_1999,
Liu Xiang
If the size of spi-nor flash is larger than 16MB, the read_opcode
is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
cause read operation fail.
---
v2:
add Fixes tag and CC stable suggested by Boris.
---
Fixes: e46ecda764dc ("mtd: spi-nor: Add Freescale QuadSPI driver")
Cc: <stable@vger.kernel.org>
Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
---
drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
index 7d9620c..64304a3 100644
--- a/drivers/mtd/spi-nor/fsl-quadspi.c
+++ b/drivers/mtd/spi-nor/fsl-quadspi.c
@@ -478,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
{
switch (cmd) {
case SPINOR_OP_READ_1_1_4:
+ case SPINOR_OP_READ_1_1_4_4B:
return SEQID_READ;
case SPINOR_OP_WREN:
return SEQID_WREN;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB
@ 2018-08-28 13:21 ` Liu Xiang
0 siblings, 0 replies; 5+ messages in thread
From: Liu Xiang @ 2018-08-28 13:21 UTC (permalink / raw)
To: linux-mtd
Cc: linux-kernel, stable, han.xu, marek.vasut, dwmw2,
computersforpeace, boris.brezillon, richard, liuxiang_1999,
Liu Xiang
If the size of spi-nor flash is larger than 16MB, the read_opcode
is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
cause read operation fail.
---
v2:
add Fixes tag and CC stable suggested by Boris.
---
Fixes: e46ecda764dc ("mtd: spi-nor: Add Freescale QuadSPI driver")
Cc: <stable@vger.kernel.org>
Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
---
drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
index 7d9620c..64304a3 100644
--- a/drivers/mtd/spi-nor/fsl-quadspi.c
+++ b/drivers/mtd/spi-nor/fsl-quadspi.c
@@ -478,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
{
switch (cmd) {
case SPINOR_OP_READ_1_1_4:
+ case SPINOR_OP_READ_1_1_4_4B:
return SEQID_READ;
case SPINOR_OP_WREN:
return SEQID_WREN;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB
2018-08-28 13:21 ` Liu Xiang
(?)
@ 2018-08-28 13:23 ` Boris Brezillon
2018-08-28 14:16 ` Liu Xiang
-1 siblings, 1 reply; 5+ messages in thread
From: Boris Brezillon @ 2018-08-28 13:23 UTC (permalink / raw)
To: Liu Xiang
Cc: linux-mtd, linux-kernel, stable, han.xu, marek.vasut, dwmw2,
computersforpeace, richard, liuxiang_1999
On Tue, 28 Aug 2018 21:21:16 +0800
Liu Xiang <liu.xiang6@zte.com.cn> wrote:
> If the size of spi-nor flash is larger than 16MB, the read_opcode
> is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
> return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
> cause read operation fail.
>
> ---
> v2:
> add Fixes tag and CC stable suggested by Boris.
> ---
The above changelog
>
> Fixes: e46ecda764dc ("mtd: spi-nor: Add Freescale QuadSPI driver")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
> ---
should be placed here.
> drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index 7d9620c..64304a3 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -478,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
> {
> switch (cmd) {
> case SPINOR_OP_READ_1_1_4:
> + case SPINOR_OP_READ_1_1_4_4B:
> return SEQID_READ;
> case SPINOR_OP_WREN:
> return SEQID_WREN;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re:Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB
2018-08-28 13:23 ` Boris Brezillon
@ 2018-08-28 14:16 ` Liu Xiang
2018-08-28 14:17 ` Boris Brezillon
0 siblings, 1 reply; 5+ messages in thread
From: Liu Xiang @ 2018-08-28 14:16 UTC (permalink / raw)
To: Boris Brezillon
Cc: Liu Xiang, linux-mtd, linux-kernel, stable, han.xu, marek.vasut,
dwmw2, computersforpeace, richard
Thanks for your suggestion. Should I send another patch?
At 2018-08-28 21:23:05, "Boris Brezillon" <boris.brezillon@bootlin.com> wrote:
>On Tue, 28 Aug 2018 21:21:16 +0800
>Liu Xiang <liu.xiang6@zte.com.cn> wrote:
>
>> If the size of spi-nor flash is larger than 16MB, the read_opcode
>> is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
>> return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
>> cause read operation fail.
>>
>> ---
>> v2:
>> add Fixes tag and CC stable suggested by Boris.
>> ---
>
>The above changelog
>
>>
>> Fixes: e46ecda764dc ("mtd: spi-nor: Add Freescale QuadSPI driver")
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
>> ---
>
>should be placed here.
>
>> drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
>> index 7d9620c..64304a3 100644
>> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
>> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
>> @@ -478,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
>> {
>> switch (cmd) {
>> case SPINOR_OP_READ_1_1_4:
>> + case SPINOR_OP_READ_1_1_4_4B:
>> return SEQID_READ;
>> case SPINOR_OP_WREN:
>> return SEQID_WREN;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB
2018-08-28 14:16 ` Liu Xiang
@ 2018-08-28 14:17 ` Boris Brezillon
0 siblings, 0 replies; 5+ messages in thread
From: Boris Brezillon @ 2018-08-28 14:17 UTC (permalink / raw)
To: Liu Xiang
Cc: Liu Xiang, linux-mtd, linux-kernel, stable, han.xu, marek.vasut,
dwmw2, computersforpeace, richard
On Tue, 28 Aug 2018 22:16:08 +0800 (CST)
"Liu Xiang" <liuxiang_1999@126.com> wrote:
> Thanks for your suggestion. Should I send another patch?
Yes please.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-28 14:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-28 13:21 [PATCH v2] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB Liu Xiang
2018-08-28 13:21 ` Liu Xiang
2018-08-28 13:23 ` Boris Brezillon
2018-08-28 14:16 ` Liu Xiang
2018-08-28 14:17 ` Boris Brezillon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.