* Re: [PATCH] vfio/pci: Avoid a null pointer dereference in vfio_config_free()
@ 2020-05-22 9:42 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-05-22 9:42 UTC (permalink / raw)
To: Qian Cai, kvm
Cc: kernel-janitors, linux-kernel, Alex Williamson, Cornelia Huck
> It is possible vfio_config_init() does not call vfio_cap_len(), and then
> vdev->msi_perm == NULL. Later, in vfio_config_free(), it could trigger a
> null-ptr-deref.
I suggest to add an imperative wording to the commit message.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=051143e1602d90ea71887d92363edd539d411de5#n151
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] vfio/pci: Avoid a null pointer dereference in vfio_config_free()
@ 2020-05-22 9:42 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-05-22 9:42 UTC (permalink / raw)
To: Qian Cai, kvm
Cc: kernel-janitors, linux-kernel, Alex Williamson, Cornelia Huck
> It is possible vfio_config_init() does not call vfio_cap_len(), and then
> vdev->msi_perm = NULL. Later, in vfio_config_free(), it could trigger a
> null-ptr-deref.
I suggest to add an imperative wording to the commit message.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id\x051143e1602d90ea71887d92363edd539d411de5#n151
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-22 9:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-22 9:42 [PATCH] vfio/pci: Avoid a null pointer dereference in vfio_config_free() Markus Elfring
2020-05-22 9:42 ` Markus Elfring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.