From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Michal Simek <michal.simek@amd.com>, "Potthuri, Sai Krishna" <sai.krishna.potthuri@amd.com>, Ulf Hansson <ulf.hansson@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Michal Simek <michal.simek@xilinx.com>, Adrian Hunter <adrian.hunter@intel.com> Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "git (AMD-Xilinx)" <git@amd.com>, "saikrishna12468@gmail.com" <saikrishna12468@gmail.com> Subject: Re: [PATCH 1/2] dt-bindings: mmc: arasan,sdci: Add Xilinx Versal Net compatible Date: Tue, 28 Mar 2023 09:37:55 +0200 [thread overview] Message-ID: <74d62ddf-8257-3f67-c33d-b6e76314bc3b@linaro.org> (raw) In-Reply-To: <84d34a5a-c29b-f38d-2a71-6cf39447b03d@amd.com> On 28/03/2023 09:31, Michal Simek wrote: > > > On 3/28/23 09:14, Krzysztof Kozlowski wrote: >> On 27/03/2023 11:58, Potthuri, Sai Krishna wrote: >>> Hi Krzysztof, >>> >>>> -----Original Message----- >>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> Sent: Friday, March 24, 2023 5:14 PM >>>> To: Potthuri, Sai Krishna <sai.krishna.potthuri@amd.com>; Ulf Hansson >>>> <ulf.hansson@linaro.org>; Rob Herring <robh+dt@kernel.org>; Krzysztof >>>> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Michal Simek >>>> <michal.simek@xilinx.com>; Adrian Hunter <adrian.hunter@intel.com> >>>> Cc: linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org; >>>> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; git (AMD- >>>> Xilinx) <git@amd.com>; saikrishna12468@gmail.com >>>> Subject: Re: [PATCH 1/2] dt-bindings: mmc: arasan,sdci: Add Xilinx Versal Net >>>> compatible >>>> >>>> On 24/03/2023 08:36, Sai Krishna Potthuri wrote: >>>>> Add Xilinx Versal Net compatible to support eMMC 5.1 PHY. >>>>> >>>>> Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> >>>>> --- >>>>> Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 6 ++++++ >>>>> 1 file changed, 6 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml >>>>> b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml >>>>> index 8296c34cfa00..cf44a4b988a7 100644 >>>>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml >>>>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml >>>>> @@ -27,6 +27,7 @@ allOf: >>>>> enum: >>>>> - xlnx,zynqmp-8.9a >>>>> - xlnx,versal-8.9a >>>>> + - xlnx,versal-net-5.1-emmc >>>> >>>> v5.1 is eMMC standard or Versal block version? If the first, it's not suitable for >>>> compatibles. >>>> >>>> Also, what's the difference from xlnx,versal-8.9a? >>> V5.1 is an eMMC standard and this compatible is defined based on sdhci arasan >>> eMMC5.1 Host Controller(arasan,sdhci-5.1), where as in Versal, it’s a different >>> controller and it is based on 4.51 Host Controller(arasan,sdhci-8.9a). >> >> Mixing IP block versions and eMMC spec versions in one binding is a >> great way to confuse. > > What do you suggest then? Stick to IP block versions or code names. The eMMC spec version would only make sense if you had such possibility: xlnx,versal-net-emmc-5.0 xlnx,versal-net-emmc-5.1 xlnx,versal-net-emmc-x.y So exactly one device with different blocks inside. This is very uncommon, but there such SoC (SunPlus IIRC). > >> >>> Versal Net Compatible is defined it this way to make it inline with the other >>> existing SoC compatibles like "intel,keembay-sdhci-5.1-emmc". >>> Please suggest if the compatible need to be renamed to "xlnx,versal-net-emmc"? >> >> Is Versal Net uniquely identifying your SoC or IP block? > > Yes. versal-net is unique identifier for specific silicon with fixed set if IPs. Then I suggest xlnx,versal-net-emmc. > Can you please refresh my mind if we can introduce specific compatible strings > for this SOC or should we used existing one if functionality is the same with > previous SOC family? It's regular case and recommendation is always (for every SoC) the same: https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42 You should add new SoC specific compatible followed by existing one (fallback). > There could be currently unknown issues related to SOC wiring out of specific IP > version. Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Michal Simek <michal.simek@amd.com>, "Potthuri, Sai Krishna" <sai.krishna.potthuri@amd.com>, Ulf Hansson <ulf.hansson@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Michal Simek <michal.simek@xilinx.com>, Adrian Hunter <adrian.hunter@intel.com> Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "git (AMD-Xilinx)" <git@amd.com>, "saikrishna12468@gmail.com" <saikrishna12468@gmail.com> Subject: Re: [PATCH 1/2] dt-bindings: mmc: arasan,sdci: Add Xilinx Versal Net compatible Date: Tue, 28 Mar 2023 09:37:55 +0200 [thread overview] Message-ID: <74d62ddf-8257-3f67-c33d-b6e76314bc3b@linaro.org> (raw) In-Reply-To: <84d34a5a-c29b-f38d-2a71-6cf39447b03d@amd.com> On 28/03/2023 09:31, Michal Simek wrote: > > > On 3/28/23 09:14, Krzysztof Kozlowski wrote: >> On 27/03/2023 11:58, Potthuri, Sai Krishna wrote: >>> Hi Krzysztof, >>> >>>> -----Original Message----- >>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> Sent: Friday, March 24, 2023 5:14 PM >>>> To: Potthuri, Sai Krishna <sai.krishna.potthuri@amd.com>; Ulf Hansson >>>> <ulf.hansson@linaro.org>; Rob Herring <robh+dt@kernel.org>; Krzysztof >>>> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Michal Simek >>>> <michal.simek@xilinx.com>; Adrian Hunter <adrian.hunter@intel.com> >>>> Cc: linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org; >>>> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; git (AMD- >>>> Xilinx) <git@amd.com>; saikrishna12468@gmail.com >>>> Subject: Re: [PATCH 1/2] dt-bindings: mmc: arasan,sdci: Add Xilinx Versal Net >>>> compatible >>>> >>>> On 24/03/2023 08:36, Sai Krishna Potthuri wrote: >>>>> Add Xilinx Versal Net compatible to support eMMC 5.1 PHY. >>>>> >>>>> Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> >>>>> --- >>>>> Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 6 ++++++ >>>>> 1 file changed, 6 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml >>>>> b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml >>>>> index 8296c34cfa00..cf44a4b988a7 100644 >>>>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml >>>>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml >>>>> @@ -27,6 +27,7 @@ allOf: >>>>> enum: >>>>> - xlnx,zynqmp-8.9a >>>>> - xlnx,versal-8.9a >>>>> + - xlnx,versal-net-5.1-emmc >>>> >>>> v5.1 is eMMC standard or Versal block version? If the first, it's not suitable for >>>> compatibles. >>>> >>>> Also, what's the difference from xlnx,versal-8.9a? >>> V5.1 is an eMMC standard and this compatible is defined based on sdhci arasan >>> eMMC5.1 Host Controller(arasan,sdhci-5.1), where as in Versal, it’s a different >>> controller and it is based on 4.51 Host Controller(arasan,sdhci-8.9a). >> >> Mixing IP block versions and eMMC spec versions in one binding is a >> great way to confuse. > > What do you suggest then? Stick to IP block versions or code names. The eMMC spec version would only make sense if you had such possibility: xlnx,versal-net-emmc-5.0 xlnx,versal-net-emmc-5.1 xlnx,versal-net-emmc-x.y So exactly one device with different blocks inside. This is very uncommon, but there such SoC (SunPlus IIRC). > >> >>> Versal Net Compatible is defined it this way to make it inline with the other >>> existing SoC compatibles like "intel,keembay-sdhci-5.1-emmc". >>> Please suggest if the compatible need to be renamed to "xlnx,versal-net-emmc"? >> >> Is Versal Net uniquely identifying your SoC or IP block? > > Yes. versal-net is unique identifier for specific silicon with fixed set if IPs. Then I suggest xlnx,versal-net-emmc. > Can you please refresh my mind if we can introduce specific compatible strings > for this SOC or should we used existing one if functionality is the same with > previous SOC family? It's regular case and recommendation is always (for every SoC) the same: https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42 You should add new SoC specific compatible followed by existing one (fallback). > There could be currently unknown issues related to SOC wiring out of specific IP > version. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-28 7:38 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-24 7:36 [PATCH 0/2] mmc: sdhci-of-arasan: Add eMMC5.1 support for Xilinx Versal Net Sai Krishna Potthuri 2023-03-24 7:36 ` Sai Krishna Potthuri 2023-03-24 7:36 ` [PATCH 1/2] dt-bindings: mmc: arasan,sdci: Add Xilinx Versal Net compatible Sai Krishna Potthuri 2023-03-24 7:36 ` Sai Krishna Potthuri 2023-03-24 11:44 ` Krzysztof Kozlowski 2023-03-24 11:44 ` Krzysztof Kozlowski 2023-03-27 9:58 ` Potthuri, Sai Krishna 2023-03-27 9:58 ` Potthuri, Sai Krishna 2023-03-28 7:14 ` Krzysztof Kozlowski 2023-03-28 7:14 ` Krzysztof Kozlowski 2023-03-28 7:31 ` Michal Simek 2023-03-28 7:31 ` Michal Simek 2023-03-28 7:37 ` Krzysztof Kozlowski [this message] 2023-03-28 7:37 ` Krzysztof Kozlowski 2023-03-24 7:36 ` [PATCH 2/2] mmc: sdhci-of-arasan: Add support for eMMC5.1 on Xilinx Versal Net platform Sai Krishna Potthuri 2023-03-24 7:36 ` Sai Krishna Potthuri
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=74d62ddf-8257-3f67-c33d-b6e76314bc3b@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=adrian.hunter@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=git@amd.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=michal.simek@amd.com \ --cc=michal.simek@xilinx.com \ --cc=robh+dt@kernel.org \ --cc=sai.krishna.potthuri@amd.com \ --cc=saikrishna12468@gmail.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.