* [PATCH] cmd: eeprom: Staticize eeprom_i2c_bus
@ 2020-04-07 11:29 Marek Vasut
2020-04-08 4:14 ` Heiko Schocher
2020-04-21 5:52 ` Heiko Schocher
0 siblings, 2 replies; 3+ messages in thread
From: Marek Vasut @ 2020-04-07 11:29 UTC (permalink / raw)
To: u-boot
The eeprom_i2c_bus is not used outside of this file, make it static.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Heiko Schocher <hs@denx.de>
Cc: Tom Rini <trini@konsulko.com>
---
cmd/eeprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/eeprom.c b/cmd/eeprom.c
index 667149e2d4..792415ef93 100644
--- a/cmd/eeprom.c
+++ b/cmd/eeprom.c
@@ -61,7 +61,7 @@
#endif
#if defined(CONFIG_DM_I2C)
-int eeprom_i2c_bus;
+static int eeprom_i2c_bus;
#endif
__weak int eeprom_write_enable(unsigned dev_addr, int state)
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] cmd: eeprom: Staticize eeprom_i2c_bus
2020-04-07 11:29 [PATCH] cmd: eeprom: Staticize eeprom_i2c_bus Marek Vasut
@ 2020-04-08 4:14 ` Heiko Schocher
2020-04-21 5:52 ` Heiko Schocher
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Schocher @ 2020-04-08 4:14 UTC (permalink / raw)
To: u-boot
Hello Marek,
Am 07.04.2020 um 13:29 schrieb Marek Vasut:
> The eeprom_i2c_bus is not used outside of this file, make it static.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Tom Rini <trini@konsulko.com>
> ---
> cmd/eeprom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Heiko Schocher <hs@denx.de>
Good catch!
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs at denx.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] cmd: eeprom: Staticize eeprom_i2c_bus
2020-04-07 11:29 [PATCH] cmd: eeprom: Staticize eeprom_i2c_bus Marek Vasut
2020-04-08 4:14 ` Heiko Schocher
@ 2020-04-21 5:52 ` Heiko Schocher
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Schocher @ 2020-04-21 5:52 UTC (permalink / raw)
To: u-boot
Hello Marek,
Am 07.04.2020 um 13:29 schrieb Marek Vasut:
> The eeprom_i2c_bus is not used outside of this file, make it static.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Tom Rini <trini@konsulko.com>
> ---
> cmd/eeprom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to u-boot-i2c master, thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs at denx.de
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-21 5:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-07 11:29 [PATCH] cmd: eeprom: Staticize eeprom_i2c_bus Marek Vasut
2020-04-08 4:14 ` Heiko Schocher
2020-04-21 5:52 ` Heiko Schocher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.