From: Vladimir Murzin <vladimir.murzin@arm.com> To: Will Deacon <will.deacon@arm.com> Cc: linux-arm-kernel@lists.infradead.org, yamada.masahiro@socionext.com, linux-crypto@vger.kernel.org, linux-kbuild@vger.kernel.org, kbuild-all@01.org, Marc Zyngier <marc.zyngier@arm.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org> Subject: Re: [RFC PATCH 1/4] kconfig: add as-instr macro to scripts/Kconfig.include Date: Wed, 7 Nov 2018 16:50:20 +0000 [thread overview] Message-ID: <74f9cecb-4efa-718c-b147-f7adf956c7bd@arm.com> (raw) In-Reply-To: <20181107145552.GC2623@brain-police> On 07/11/18 14:55, Will Deacon wrote: > On Wed, Nov 07, 2018 at 09:40:05AM +0000, Vladimir Murzin wrote: >> There are cases where the whole feature, for instance arm64/lse or >> arm/crypto, can depend on assembler. Current practice is to report >> buildtime that selected feature is not supported, which can be quite >> annoying... > > Why is it annoying? You still end up with a working kernel. .config doesn't really represent if option was built or not, annoying part is digging build logs (if anyone's saved them at all!) or relevant parts of dmesg (if option throws anything in there and which not always part of reports). > >> It'd nicer if we can check assembler first and opt-in feature >> visibility in Kconfig. >> >> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> >> Cc: Will Deacon <will.deacon@arm.com> >> Cc: Marc Zyngier <marc.zyngier@arm.com> >> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com> >> --- >> scripts/Kconfig.include | 4 ++++ >> 1 file changed, 4 insertions(+) > > One issue I have with doing the check like this is that if somebody sends > you a .config with e.g. ARM64_LSE_ATOMICS=y and you try to build a kernel > using that .config and an old toolchain, the option is silently dropped. I see... at least we have some tools like ./scripts/diffconfig > > I think the diagnostic is actually useful in this case. Fully agree on diagnostic side, any suggestions how it can be improved? Cheers Vladimir > > Will >
WARNING: multiple messages have this Message-ID (diff)
From: vladimir.murzin@arm.com (Vladimir Murzin) To: linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH 1/4] kconfig: add as-instr macro to scripts/Kconfig.include Date: Wed, 7 Nov 2018 16:50:20 +0000 [thread overview] Message-ID: <74f9cecb-4efa-718c-b147-f7adf956c7bd@arm.com> (raw) In-Reply-To: <20181107145552.GC2623@brain-police> On 07/11/18 14:55, Will Deacon wrote: > On Wed, Nov 07, 2018 at 09:40:05AM +0000, Vladimir Murzin wrote: >> There are cases where the whole feature, for instance arm64/lse or >> arm/crypto, can depend on assembler. Current practice is to report >> buildtime that selected feature is not supported, which can be quite >> annoying... > > Why is it annoying? You still end up with a working kernel. .config doesn't really represent if option was built or not, annoying part is digging build logs (if anyone's saved them at all!) or relevant parts of dmesg (if option throws anything in there and which not always part of reports). > >> It'd nicer if we can check assembler first and opt-in feature >> visibility in Kconfig. >> >> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> >> Cc: Will Deacon <will.deacon@arm.com> >> Cc: Marc Zyngier <marc.zyngier@arm.com> >> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com> >> --- >> scripts/Kconfig.include | 4 ++++ >> 1 file changed, 4 insertions(+) > > One issue I have with doing the check like this is that if somebody sends > you a .config with e.g. ARM64_LSE_ATOMICS=y and you try to build a kernel > using that .config and an old toolchain, the option is silently dropped. I see... at least we have some tools like ./scripts/diffconfig > > I think the diagnostic is actually useful in this case. Fully agree on diagnostic side, any suggestions how it can be improved? Cheers Vladimir > > Will >
next prev parent reply other threads:[~2018-11-08 2:21 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-07 9:40 [RFC PATCH 0/4] Minor improvements over handling dependency on GAS Vladimir Murzin 2018-11-07 9:40 ` Vladimir Murzin 2018-11-07 9:40 ` [RFC PATCH 1/4] kconfig: add as-instr macro to scripts/Kconfig.include Vladimir Murzin 2018-11-07 9:40 ` Vladimir Murzin 2018-11-07 14:55 ` Will Deacon 2018-11-07 14:55 ` Will Deacon 2018-11-07 16:50 ` Vladimir Murzin [this message] 2018-11-07 16:50 ` Vladimir Murzin 2018-11-07 9:40 ` [RFC PATCH 2/4] arm64: lse: expose dependency on gas via Kconfig Vladimir Murzin 2018-11-07 9:40 ` Vladimir Murzin 2018-11-07 9:40 ` [RFC PATCH 3/4] arm64: turn "broken gas inst" into real config option Vladimir Murzin 2018-11-07 9:40 ` Vladimir Murzin 2018-11-07 9:40 ` [RFC PATCH 4/4] ARM: crypto: expose dependency on gas via Kconfig Vladimir Murzin 2018-11-07 9:40 ` Vladimir Murzin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=74f9cecb-4efa-718c-b147-f7adf956c7bd@arm.com \ --to=vladimir.murzin@arm.com \ --cc=ard.biesheuvel@linaro.org \ --cc=kbuild-all@01.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=will.deacon@arm.com \ --cc=yamada.masahiro@socionext.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.