[Xenomai] xeno-config --no-mode-check still has -lmodechk

[Xenomai] xeno-config --no-mode-check still has -lmodechk

[Giulio Moro]

 /usr/xenomai/bin/xeno-config --skin cobalt --ldflags --no-mode-check

returns
-Wl,--no-as-needed   /usr/xenomai/lib/xenomai/bootstrap.o -Wl,--wrap=main -Wl,--dynamic-list=/usr/xenomai/lib/dynlist.ld -L/usr/xenomai/lib -lcobalt -lmodechk -lpthread -lrt

which removes the modechk wrappers, but leaves -lmodechk in. Is this expected?

As I understand it, libmodechk provides implementations for __wrap_malloc, __wrap_free and __real_malloc, __real_free() are these needed even when the wrappers are disabled, or should -lmodechk not be included?

Re: [Xenomai] xeno-config --no-mode-check still has -lmodechk

[Philippe Gerum]

On 04/04/2018 09:58 PM, Giulio Moro wrote:
>  /usr/xenomai/bin/xeno-config --skin cobalt --ldflags --no-mode-check
> 
> returns
> -Wl,--no-as-needed   /usr/xenomai/lib/xenomai/bootstrap.o -Wl,--wrap=main -Wl,--dynamic-list=/usr/xenomai/lib/dynlist.ld -L/usr/xenomai/lib -lcobalt -lmodechk -lpthread -lrt
> 
> which removes the modechk wrappers, but leaves -lmodechk in. Is this expected?
> 
> As I understand it, libmodechk provides implementations for __wrap_malloc, __wrap_free and __real_malloc, __real_free() are these needed even when the wrappers are disabled, or should -lmodechk not be included?
> 
> 

The main exec may still depend on external libs built with mode checking
wrappers.

-- 
Philippe.

Re: [Xenomai] xeno-config --no-mode-check still has -lmodechk

[Giulio Moro]

so would it not be up to the external libs to specify in their docs that they should be linked with -lmodechk?
________________________________________
From: Philippe Gerum <rpm@xenomai.org>
Sent: 05 April 2018 07:43
To: Giulio Moro; xenomai@xenomai.org
Subject: Re: [Xenomai] xeno-config --no-mode-check still has -lmodechk

On 04/04/2018 09:58 PM, Giulio Moro wrote:
>  /usr/xenomai/bin/xeno-config --skin cobalt --ldflags --no-mode-check
>
> returns
> -Wl,--no-as-needed   /usr/xenomai/lib/xenomai/bootstrap.o -Wl,--wrap=main -Wl,--dynamic-list=/usr/xenomai/lib/dynlist.ld -L/usr/xenomai/lib -lcobalt -lmodechk -lpthread -lrt
>
> which removes the modechk wrappers, but leaves -lmodechk in. Is this expected?
>
> As I understand it, libmodechk provides implementations for __wrap_malloc, __wrap_free and __real_malloc, __real_free() are these needed even when the wrappers are disabled, or should -lmodechk not be included?
>
>

The main exec may still depend on external libs built with mode checking
wrappers.

--
Philippe.

[Xenomai] xeno-config --no-mode-check still has -lmodechk

[Philippe Gerum]

On 04/05/2018 01:15 PM, Giulio Moro wrote:
> so would it not be up to the external libs to specify in their docs that they should be linked with -lmodechk?

You likely mean mentioning such dependency in their LDFLAGS as DSOs when
linked, which is right.

Over time, I received several reports from users of 3rd party libs which
could not assume that unfortunately. So the question boils down to:
should we break those builds to remove a generally useless dependency on
libmodechk, or should we keep this dependency to please those users and
maintain backward compat.

Another question this raises is about calling __real_* symbols directly
from the application code - which would be ok as a way to bypass the
assertion checking in this case (likewise the other way around,
referring to __wrap* calls). Not depending on libmodechk would
invalidate such usage, ending up in undefined references.

Open question AFAIC.

-- 
Philippe.

Re: [Xenomai] xeno-config --no-mode-check still has -lmodechk

[Lange Norbert]

Ok, I believe that's my entirely the fault of my changes, ignore the previous mail

Norbert
________________________________

This message and any attachments are solely for the use of the intended recipients. They may contain privileged and/or confidential information or other information protected from disclosure. If you are not an intended recipient, you are hereby notified that you received this email in error and that any review, dissemination, distribution or copying of this email and any attachment is strictly prohibited. If you have received this email in error, please contact the sender and delete the message and any attachment from your system.

ANDRITZ HYDRO GmbH


Rechtsform/ Legal form: Gesellschaft mit beschränkter Haftung / Corporation

Firmensitz/ Registered seat: Wien

Firmenbuchgericht/ Court of registry: Handelsgericht Wien

Firmenbuchnummer/ Company registration: FN 61833 g

DVR: 0605077

UID-Nr.: ATU14756806


Thank You
________________________________

Re: [Xenomai] xeno-config --no-mode-check still has -lmodechk

[Lange Norbert]

Hello,

Since I just ran into this….
libcobalt seems to really need libmodechk to define __real_malloc and __real_free.
I believe this to be a bug?

$ nm /home/lano/buildroot/host/x86_64-buildroot-linux-gnu/sysroot/usr/xenomai/lib/libcobalt.so | grep malloc
00000000000199f0 T malloc_ex
                 U malloc@@GLIBC_2.2.5
000000000001aef0 T malloc_usable_size_ex
                 U __real_malloc
000000000001a430 T tlsf_malloc

Norbert
________________________________

This message and any attachments are solely for the use of the intended recipients. They may contain privileged and/or confidential information or other information protected from disclosure. If you are not an intended recipient, you are hereby notified that you received this email in error and that any review, dissemination, distribution or copying of this email and any attachment is strictly prohibited. If you have received this email in error, please contact the sender and delete the message and any attachment from your system.

ANDRITZ HYDRO GmbH


Rechtsform/ Legal form: Gesellschaft mit beschränkter Haftung / Corporation

Firmensitz/ Registered seat: Wien

Firmenbuchgericht/ Court of registry: Handelsgericht Wien

Firmenbuchnummer/ Company registration: FN 61833 g

DVR: 0605077

UID-Nr.: ATU14756806


Thank You
________________________________