All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] verdin-imx8mm, verdin-imx8mp: Fix default systemd console output
@ 2022-04-21  9:23 Philippe Schenker
  2022-04-21  9:51 ` Stefano Babic
  2022-04-21 10:56 ` Marcel Ziswiler
  0 siblings, 2 replies; 3+ messages in thread
From: Philippe Schenker @ 2022-04-21  9:23 UTC (permalink / raw)
  To: Marcel Ziswiler, Stefano Babic; +Cc: u-boot, Fabio Estevam, Philippe Schenker

From: Philippe Schenker <philippe.schenker@toradex.com>

systemd prints its messages on the last console= statement that it finds
in the kernel arguments. The current ordering sends the systemd messages
to tty1, by default this is the display.

Ensure that systemd sends its messages to the default UART, reorder the
console= statements accordingly.

Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>

---

 include/configs/verdin-imx8mm.h | 4 ++--
 include/configs/verdin-imx8mp.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/configs/verdin-imx8mm.h b/include/configs/verdin-imx8mm.h
index 6c5b190dd9..1c8f8f6358 100644
--- a/include/configs/verdin-imx8mm.h
+++ b/include/configs/verdin-imx8mm.h
@@ -63,8 +63,8 @@
 	"nfsboot=run netargs; dhcp ${loadaddr} ${boot_file}; " \
 		"tftp ${fdt_addr} verdin/${fdtfile}; " \
 		"booti ${loadaddr} - ${fdt_addr}\0" \
-	"setup=setenv setupargs console=${console},${baudrate} " \
-		"console=tty1 consoleblank=0 earlycon\0" \
+	"setup=setenv setupargs console=tty1 console=${console},${baudrate} " \
+		"consoleblank=0 earlycon\0" \
 	"update_uboot=askenv confirm Did you load flash.bin (y/N)?; " \
 		"if test \"$confirm\" = \"y\"; then " \
 		"setexpr blkcnt ${filesize} + 0x1ff && setexpr blkcnt " \
diff --git a/include/configs/verdin-imx8mp.h b/include/configs/verdin-imx8mp.h
index 9e29dc1903..076a70d2bf 100644
--- a/include/configs/verdin-imx8mp.h
+++ b/include/configs/verdin-imx8mp.h
@@ -82,7 +82,7 @@
 	"nfsboot=run netargs; dhcp ${loadaddr} ${boot_file}; " \
 		"tftp ${fdt_addr} verdin/${fdtfile}; " \
 		"booti ${loadaddr} - ${fdt_addr}\0" \
-	"setup=setenv setupargs console=${console},${baudrate} console=tty1 " \
+	"setup=setenv setupargs console=tty1 console=${console},${baudrate} " \
 		"consoleblank=0 earlycon\0" \
 	"update_uboot=askenv confirm Did you load flash.bin (y/N)?; " \
 		"if test \"$confirm\" = \"y\"; then " \
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] verdin-imx8mm, verdin-imx8mp: Fix default systemd console output
  2022-04-21  9:23 [PATCH] verdin-imx8mm, verdin-imx8mp: Fix default systemd console output Philippe Schenker
@ 2022-04-21  9:51 ` Stefano Babic
  2022-04-21 10:56 ` Marcel Ziswiler
  1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2022-04-21  9:51 UTC (permalink / raw)
  To: Philippe Schenker, Marcel Ziswiler, Stefano Babic
  Cc: u-boot, Fabio Estevam, Philippe Schenker

On 21.04.22 11:23, Philippe Schenker wrote:
> From: Philippe Schenker <philippe.schenker@toradex.com>
> 
> systemd prints its messages on the last console= statement that it finds
> in the kernel arguments. The current ordering sends the systemd messages
> to tty1, by default this is the display.
> 
> Ensure that systemd sends its messages to the default UART, reorder the
> console= statements accordingly.
> 
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> 
> ---
> 
>   include/configs/verdin-imx8mm.h | 4 ++--
>   include/configs/verdin-imx8mp.h | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/configs/verdin-imx8mm.h b/include/configs/verdin-imx8mm.h
> index 6c5b190dd9..1c8f8f6358 100644
> --- a/include/configs/verdin-imx8mm.h
> +++ b/include/configs/verdin-imx8mm.h
> @@ -63,8 +63,8 @@
>   	"nfsboot=run netargs; dhcp ${loadaddr} ${boot_file}; " \
>   		"tftp ${fdt_addr} verdin/${fdtfile}; " \
>   		"booti ${loadaddr} - ${fdt_addr}\0" \
> -	"setup=setenv setupargs console=${console},${baudrate} " \
> -		"console=tty1 consoleblank=0 earlycon\0" \
> +	"setup=setenv setupargs console=tty1 console=${console},${baudrate} " \
> +		"consoleblank=0 earlycon\0" \
>   	"update_uboot=askenv confirm Did you load flash.bin (y/N)?; " \
>   		"if test \"$confirm\" = \"y\"; then " \
>   		"setexpr blkcnt ${filesize} + 0x1ff && setexpr blkcnt " \
> diff --git a/include/configs/verdin-imx8mp.h b/include/configs/verdin-imx8mp.h
> index 9e29dc1903..076a70d2bf 100644
> --- a/include/configs/verdin-imx8mp.h
> +++ b/include/configs/verdin-imx8mp.h
> @@ -82,7 +82,7 @@
>   	"nfsboot=run netargs; dhcp ${loadaddr} ${boot_file}; " \
>   		"tftp ${fdt_addr} verdin/${fdtfile}; " \
>   		"booti ${loadaddr} - ${fdt_addr}\0" \
> -	"setup=setenv setupargs console=${console},${baudrate} console=tty1 " \
> +	"setup=setenv setupargs console=tty1 console=${console},${baudrate} " \
>   		"consoleblank=0 earlycon\0" \
>   	"update_uboot=askenv confirm Did you load flash.bin (y/N)?; " \
>   		"if test \"$confirm\" = \"y\"; then " \

Reviewed-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] verdin-imx8mm, verdin-imx8mp: Fix default systemd console output
  2022-04-21  9:23 [PATCH] verdin-imx8mm, verdin-imx8mp: Fix default systemd console output Philippe Schenker
  2022-04-21  9:51 ` Stefano Babic
@ 2022-04-21 10:56 ` Marcel Ziswiler
  1 sibling, 0 replies; 3+ messages in thread
From: Marcel Ziswiler @ 2022-04-21 10:56 UTC (permalink / raw)
  To: dev, sbabic; +Cc: festevam, u-boot, Philippe Schenker

On Thu, 2022-04-21 at 11:23 +0200, Philippe Schenker wrote:
> From: Philippe Schenker <philippe.schenker@toradex.com>
> 
> systemd prints its messages on the last console= statement that it finds
> in the kernel arguments. The current ordering sends the systemd messages
> to tty1, by default this is the display.
> 
> Ensure that systemd sends its messages to the default UART, reorder the
> console= statements accordingly.
> 
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>

Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

> ---
> 
>  include/configs/verdin-imx8mm.h | 4 ++--
>  include/configs/verdin-imx8mp.h | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/configs/verdin-imx8mm.h b/include/configs/verdin-imx8mm.h
> index 6c5b190dd9..1c8f8f6358 100644
> --- a/include/configs/verdin-imx8mm.h
> +++ b/include/configs/verdin-imx8mm.h
> @@ -63,8 +63,8 @@
>         "nfsboot=run netargs; dhcp ${loadaddr} ${boot_file}; " \
>                 "tftp ${fdt_addr} verdin/${fdtfile}; " \
>                 "booti ${loadaddr} - ${fdt_addr}\0" \
> -       "setup=setenv setupargs console=${console},${baudrate} " \
> -               "console=tty1 consoleblank=0 earlycon\0" \
> +       "setup=setenv setupargs console=tty1 console=${console},${baudrate} " \
> +               "consoleblank=0 earlycon\0" \
>         "update_uboot=askenv confirm Did you load flash.bin (y/N)?; " \
>                 "if test \"$confirm\" = \"y\"; then " \
>                 "setexpr blkcnt ${filesize} + 0x1ff && setexpr blkcnt " \
> diff --git a/include/configs/verdin-imx8mp.h b/include/configs/verdin-imx8mp.h
> index 9e29dc1903..076a70d2bf 100644
> --- a/include/configs/verdin-imx8mp.h
> +++ b/include/configs/verdin-imx8mp.h
> @@ -82,7 +82,7 @@
>         "nfsboot=run netargs; dhcp ${loadaddr} ${boot_file}; " \
>                 "tftp ${fdt_addr} verdin/${fdtfile}; " \
>                 "booti ${loadaddr} - ${fdt_addr}\0" \
> -       "setup=setenv setupargs console=${console},${baudrate} console=tty1 " \
> +       "setup=setenv setupargs console=tty1 console=${console},${baudrate} " \
>                 "consoleblank=0 earlycon\0" \
>         "update_uboot=askenv confirm Did you load flash.bin (y/N)?; " \
>                 "if test \"$confirm\" = \"y\"; then " \

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-04-21 13:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21  9:23 [PATCH] verdin-imx8mm, verdin-imx8mp: Fix default systemd console output Philippe Schenker
2022-04-21  9:51 ` Stefano Babic
2022-04-21 10:56 ` Marcel Ziswiler

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.