* [PATCH] KVM: let declaration of kvm_get_running_vcpus match implementation
@ 2020-02-28 8:49 Christian Borntraeger
2020-02-28 9:34 ` Paolo Bonzini
0 siblings, 1 reply; 4+ messages in thread
From: Christian Borntraeger @ 2020-02-28 8:49 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: KVM, arc Zyngier
Sparse notices that declaration and implementation do not match:
arch/s390/kvm/../../../virt/kvm/kvm_main.c:4435:17: warning: incorrect type in return expression (different address spaces)
arch/s390/kvm/../../../virt/kvm/kvm_main.c:4435:17: expected struct kvm_vcpu [noderef] <asn:3> **
arch/s390/kvm/../../../virt/kvm/kvm_main.c:4435:17: got struct kvm_vcpu *[noderef] <asn:3> *
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
include/linux/kvm_host.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 7944ad6ac10b..bcb9b2ac0791 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -1344,7 +1344,7 @@ static inline void kvm_vcpu_set_dy_eligible(struct kvm_vcpu *vcpu, bool val)
#endif /* CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT */
struct kvm_vcpu *kvm_get_running_vcpu(void);
-struct kvm_vcpu __percpu **kvm_get_running_vcpus(void);
+struct kvm_vcpu * __percpu *kvm_get_running_vcpus(void);
#ifdef CONFIG_HAVE_KVM_IRQ_BYPASS
bool kvm_arch_has_irq_bypass(void);
--
2.24.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] KVM: let declaration of kvm_get_running_vcpus match implementation
2020-02-28 8:49 [PATCH] KVM: let declaration of kvm_get_running_vcpus match implementation Christian Borntraeger
@ 2020-02-28 9:34 ` Paolo Bonzini
2020-03-20 14:29 ` Christian Borntraeger
0 siblings, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2020-02-28 9:34 UTC (permalink / raw)
To: Christian Borntraeger; +Cc: KVM, arc Zyngier
On 28/02/20 09:49, Christian Borntraeger wrote:
> Sparse notices that declaration and implementation do not match:
> arch/s390/kvm/../../../virt/kvm/kvm_main.c:4435:17: warning: incorrect type in return expression (different address spaces)
> arch/s390/kvm/../../../virt/kvm/kvm_main.c:4435:17: expected struct kvm_vcpu [noderef] <asn:3> **
> arch/s390/kvm/../../../virt/kvm/kvm_main.c:4435:17: got struct kvm_vcpu *[noderef] <asn:3> *
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> include/linux/kvm_host.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index 7944ad6ac10b..bcb9b2ac0791 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -1344,7 +1344,7 @@ static inline void kvm_vcpu_set_dy_eligible(struct kvm_vcpu *vcpu, bool val)
> #endif /* CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT */
>
> struct kvm_vcpu *kvm_get_running_vcpu(void);
> -struct kvm_vcpu __percpu **kvm_get_running_vcpus(void);
> +struct kvm_vcpu * __percpu *kvm_get_running_vcpus(void);
>
> #ifdef CONFIG_HAVE_KVM_IRQ_BYPASS
> bool kvm_arch_has_irq_bypass(void);
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] KVM: let declaration of kvm_get_running_vcpus match implementation
2020-02-28 9:34 ` Paolo Bonzini
@ 2020-03-20 14:29 ` Christian Borntraeger
2020-03-20 17:54 ` Paolo Bonzini
0 siblings, 1 reply; 4+ messages in thread
From: Christian Borntraeger @ 2020-03-20 14:29 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: KVM, arc Zyngier
On 28.02.20 10:34, Paolo Bonzini wrote:
> On 28/02/20 09:49, Christian Borntraeger wrote:
>> Sparse notices that declaration and implementation do not match:
>> arch/s390/kvm/../../../virt/kvm/kvm_main.c:4435:17: warning: incorrect type in return expression (different address spaces)
>> arch/s390/kvm/../../../virt/kvm/kvm_main.c:4435:17: expected struct kvm_vcpu [noderef] <asn:3> **
>> arch/s390/kvm/../../../virt/kvm/kvm_main.c:4435:17: got struct kvm_vcpu *[noderef] <asn:3> *
>>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>> include/linux/kvm_host.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
>> index 7944ad6ac10b..bcb9b2ac0791 100644
>> --- a/include/linux/kvm_host.h
>> +++ b/include/linux/kvm_host.h
>> @@ -1344,7 +1344,7 @@ static inline void kvm_vcpu_set_dy_eligible(struct kvm_vcpu *vcpu, bool val)
>> #endif /* CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT */
>>
>> struct kvm_vcpu *kvm_get_running_vcpu(void);
>> -struct kvm_vcpu __percpu **kvm_get_running_vcpus(void);
>> +struct kvm_vcpu * __percpu *kvm_get_running_vcpus(void);
>>
>> #ifdef CONFIG_HAVE_KVM_IRQ_BYPASS
>> bool kvm_arch_has_irq_bypass(void);
>>
>
> Queued, thanks.
Ping. I cant find this in kvm/next.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] KVM: let declaration of kvm_get_running_vcpus match implementation
2020-03-20 14:29 ` Christian Borntraeger
@ 2020-03-20 17:54 ` Paolo Bonzini
0 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2020-03-20 17:54 UTC (permalink / raw)
To: Christian Borntraeger; +Cc: KVM, arc Zyngier
On 20/03/20 15:29, Christian Borntraeger wrote:
>
>
> On 28.02.20 10:34, Paolo Bonzini wrote:
>> On 28/02/20 09:49, Christian Borntraeger wrote:
>>> Sparse notices that declaration and implementation do not match:
>>> arch/s390/kvm/../../../virt/kvm/kvm_main.c:4435:17: warning: incorrect type in return expression (different address spaces)
>>> arch/s390/kvm/../../../virt/kvm/kvm_main.c:4435:17: expected struct kvm_vcpu [noderef] <asn:3> **
>>> arch/s390/kvm/../../../virt/kvm/kvm_main.c:4435:17: got struct kvm_vcpu *[noderef] <asn:3> *
>>>
>>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>>> ---
>>> include/linux/kvm_host.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
>>> index 7944ad6ac10b..bcb9b2ac0791 100644
>>> --- a/include/linux/kvm_host.h
>>> +++ b/include/linux/kvm_host.h
>>> @@ -1344,7 +1344,7 @@ static inline void kvm_vcpu_set_dy_eligible(struct kvm_vcpu *vcpu, bool val)
>>> #endif /* CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT */
>>>
>>> struct kvm_vcpu *kvm_get_running_vcpu(void);
>>> -struct kvm_vcpu __percpu **kvm_get_running_vcpus(void);
>>> +struct kvm_vcpu * __percpu *kvm_get_running_vcpus(void);
>>>
>>> #ifdef CONFIG_HAVE_KVM_IRQ_BYPASS
>>> bool kvm_arch_has_irq_bypass(void);
>>>
>>
>> Queued, thanks.
>
> Ping. I cant find this in kvm/next.
>
It's in 5.6-rc4.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-20 17:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-28 8:49 [PATCH] KVM: let declaration of kvm_get_running_vcpus match implementation Christian Borntraeger
2020-02-28 9:34 ` Paolo Bonzini
2020-03-20 14:29 ` Christian Borntraeger
2020-03-20 17:54 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.