All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pu Wen <puwen@hygon.cn>
To: Jan Beulich <jbeulich@suse.com>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"wei.liu2@citrix.com" <wei.liu2@citrix.com>,
	"roger.pau@citrix.com" <roger.pau@citrix.com>
Subject: Re: [PATCH 13/15] x86/xstate: Add Hygon Dhyana support
Date: Wed, 30 Jan 2019 18:47:55 +0800	[thread overview]
Message-ID: <758ab9a9-e58a-b42e-d538-0682d28c35c7@hygon.cn> (raw)
In-Reply-To: <5C5035DC020000780014B869@prv1-mh.provo.novell.com>

On 2019/1/29 19:15, Jan Beulich wrote:
>>>> Pu Wen <puwen@hygon.cn> 12/20/18 2:16 PM >>>
>> --- a/xen/arch/x86/xstate.c
>> +++ b/xen/arch/x86/xstate.c
>> @@ -369,7 +369,7 @@ void xrstor(struct vcpu *v, uint64_t mask)
>> unsigned int faults, prev_faults;
>   >
>> /*
>> -     * AMD CPUs don't save/restore FDP/FIP/FOP unless an exception
>> +     * AMD or Hygon CPUs don't save/restore FDP/FIP/FOP unless an exception
>> * is pending. Clear the x87 state here by setting it to fixed
>> * values. The hypervisor data segment can be sometimes 0 and
>> * sometimes new user value. Both should be ok. Use the FPU saved
>> @@ -377,7 +377,8 @@ void xrstor(struct vcpu *v, uint64_t mask)
>> */
>> if ( (mask & ptr->xsave_hdr.xstate_bv & X86_XCR0_FP) &&
>> !(ptr->fpu_sse.fsw & ~ptr->fpu_sse.fcw & 0x003f) &&
>> -         boot_cpu_data.x86_vendor == X86_VENDOR_AMD )
>> +         (boot_cpu_data.x86_vendor == X86_VENDOR_AMD ||
>> +          boot_cpu_data.x86_vendor == X86_VENDOR_HYGON) )
>> asm volatile ( "fnclex\n\t"        /* clear exceptions */
>> "ffree %%st(7)\n\t" /* clear stack tag */
>> "fildl %0"          /* load to clear state */
> 
> A similar change then is needed to fpu_fxrstor() as well, in case people
> disable use of XSAVE via command line option. And then there was also

The same change to fpu_fxrstor() is fine.

> a recent change to this area by Andrew, which may affect you as well.
> (Sorry, I don't have a pointer at hand.)

If Andrew's change is accepted upstream, then these changes for Hygon
are no needed any more.

Right now I wonder how to develop the following version Hygon patch set.
Following the current change logic or waiting for Andrew's changes
settled down?

Andrew,
How about your patch series "x86: Improvements to handling of various
CPU bugs"?

-- 
Regards,
Pu Wen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-01-30 10:52 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-20 13:12 [PATCH 00/15] Add support for Hygon Dhyana Family 18h processor Pu Wen
2018-12-20 13:12 ` [PATCH 01/15] x86/cpu: Create Hygon Dhyana architecture support file Pu Wen
2018-12-21 10:19   ` Andrew Cooper
2018-12-26 11:42     ` Pu Wen
2018-12-27 17:03       ` Roger Pau Monné
2018-12-27 21:09       ` Andrew Cooper
2018-12-28 15:46         ` Pu Wen
2018-12-28 16:21           ` Andrew Cooper
2018-12-20 13:12 ` [PATCH 02/15] x86/cpu/mtrr: Add Hygon Dhyana support to get TOP_MEM2 Pu Wen
2018-12-20 13:12 ` [PATCH 03/15] x86/cpu/vpmu: Add Hygon Dhyana support for vPMU Pu Wen
2018-12-20 14:24   ` Boris Ostrovsky
2018-12-21 10:02     ` Pu Wen
2018-12-21 13:33       ` Boris Ostrovsky
2018-12-21 16:17         ` Pu Wen
2019-01-14 16:03   ` Jan Beulich
2019-01-15 12:49     ` Pu Wen
2019-01-15 13:01       ` Jan Beulich
2019-01-15 16:22         ` Pu Wen
2018-12-20 13:12 ` [PATCH 04/15] x86/cpu/mce: Add Hygon Dhyana support to the MCA infrastructure Pu Wen
2019-01-14 16:23   ` Jan Beulich
2019-01-15 12:52     ` Pu Wen
2019-01-15 13:08       ` Jan Beulich
2018-12-20 13:13 ` [PATCH 05/15] x86/spec_ctrl: Add Hygon Dhyana to the respective mitigation machinery Pu Wen
2018-12-20 13:14 ` [PATCH 06/15] x86/apic: Add Hygon Dhyana support Pu Wen
2018-12-20 13:14 ` [PATCH 07/15] x86/acpi: " Pu Wen
2019-01-14 16:28   ` Jan Beulich
2019-01-15 12:52     ` Pu Wen
2019-01-15 13:09       ` Jan Beulich
2018-12-20 13:14 ` [PATCH 08/15] x86/iommu: " Pu Wen
2018-12-20 13:14 ` [PATCH 09/15] x86/pv: Add Hygon Dhyana support to emulate MSRs access Pu Wen
2019-01-25 17:00   ` Jan Beulich
2019-01-30  9:52     ` Pu Wen
2019-01-30 10:08       ` Jan Beulich
2018-12-20 13:15 ` [PATCH 10/15] x86/domain: Add Hygon Dhyana support Pu Wen
2018-12-20 13:15 ` [PATCH 11/15] x86/domctl: " Pu Wen
2018-12-20 13:15 ` [PATCH 12/15] x86/traps: " Pu Wen
2019-01-29 11:10   ` Jan Beulich
2019-01-30  9:57     ` Pu Wen
2018-12-20 13:15 ` [PATCH 13/15] x86/xstate: " Pu Wen
2018-12-27 22:40   ` Andrew Cooper
2018-12-29  9:39     ` Pu Wen
2019-01-29 11:15   ` Jan Beulich
2019-01-30 10:47     ` Pu Wen [this message]
2018-12-20 13:15 ` [PATCH 14/15] x86/cpuid: " Pu Wen
2018-12-20 13:15 ` [PATCH 15/15] tools/libxc: " Pu Wen
2019-01-02 11:33   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=758ab9a9-e58a-b42e-d538-0682d28c35c7@hygon.cn \
    --to=puwen@hygon.cn \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.