All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pu Wen <puwen@hygon.cn>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 09/15] x86/pv: Add Hygon Dhyana support to emulate MSRs access
Date: Wed, 30 Jan 2019 17:52:21 +0800	[thread overview]
Message-ID: <fbb2d4f6-75d1-49ad-a037-a2f472ef1754@hygon.cn> (raw)
In-Reply-To: <5C4B40C602000078002113CA@prv1-mh.provo.novell.com>

On 2019/1/26 1:48, Jan Beulich wrote:
>>>> On 20.12.18 at 14:14, <puwen@hygon.cn> wrote:
>> The Hygon Dhyana CPU supports lots of MSRs(such as perf event select and
>> counter MSRs, hardware configuration MSR, MMIO configuration base address
>> MSR, MPERF/APERF MSRs) as AMD CPU does, so add Hygon Dhyana support to the
>> PV emulation infrastructure by using the code path of AMD.
>>
>> As hygon.c needs to write the load-store configuration(LS_CFG) MSR, so add
>> new case in write_msr to handle this situation.
> 
> Which hygon.c do you mean here? This addition, if valid at all, clearly

I mean hygon.c from the linux kernel. But in fact it's some other kernel
part will write LS_CFG MSR. So the description will be refined.

> needs its own patch and justification, the more that you permit access

This addition is needed, otherwise there will be warnings like:
"(XEN) emul-priv-op.c:1165:d0v12 Domain attempted WRMSR c0011020 from 0x0206800000000000 to 0x0206800000000400"

Your suggestion is fine, will develop its own patch and justification in
next version patch set.

> (even if only for Dom0) on AMD as well.

As there will be the same warnings on AMD platforms, so I permit access
for AMD as well. I don't know if is this OK? If not, I'll permit access
for Hygon only.

-- 
Regards,
Pu Wen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-01-30  9:57 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-20 13:12 [PATCH 00/15] Add support for Hygon Dhyana Family 18h processor Pu Wen
2018-12-20 13:12 ` [PATCH 01/15] x86/cpu: Create Hygon Dhyana architecture support file Pu Wen
2018-12-21 10:19   ` Andrew Cooper
2018-12-26 11:42     ` Pu Wen
2018-12-27 17:03       ` Roger Pau Monné
2018-12-27 21:09       ` Andrew Cooper
2018-12-28 15:46         ` Pu Wen
2018-12-28 16:21           ` Andrew Cooper
2018-12-20 13:12 ` [PATCH 02/15] x86/cpu/mtrr: Add Hygon Dhyana support to get TOP_MEM2 Pu Wen
2018-12-20 13:12 ` [PATCH 03/15] x86/cpu/vpmu: Add Hygon Dhyana support for vPMU Pu Wen
2018-12-20 14:24   ` Boris Ostrovsky
2018-12-21 10:02     ` Pu Wen
2018-12-21 13:33       ` Boris Ostrovsky
2018-12-21 16:17         ` Pu Wen
2019-01-14 16:03   ` Jan Beulich
2019-01-15 12:49     ` Pu Wen
2019-01-15 13:01       ` Jan Beulich
2019-01-15 16:22         ` Pu Wen
2018-12-20 13:12 ` [PATCH 04/15] x86/cpu/mce: Add Hygon Dhyana support to the MCA infrastructure Pu Wen
2019-01-14 16:23   ` Jan Beulich
2019-01-15 12:52     ` Pu Wen
2019-01-15 13:08       ` Jan Beulich
2018-12-20 13:13 ` [PATCH 05/15] x86/spec_ctrl: Add Hygon Dhyana to the respective mitigation machinery Pu Wen
2018-12-20 13:14 ` [PATCH 06/15] x86/apic: Add Hygon Dhyana support Pu Wen
2018-12-20 13:14 ` [PATCH 07/15] x86/acpi: " Pu Wen
2019-01-14 16:28   ` Jan Beulich
2019-01-15 12:52     ` Pu Wen
2019-01-15 13:09       ` Jan Beulich
2018-12-20 13:14 ` [PATCH 08/15] x86/iommu: " Pu Wen
2018-12-20 13:14 ` [PATCH 09/15] x86/pv: Add Hygon Dhyana support to emulate MSRs access Pu Wen
2019-01-25 17:00   ` Jan Beulich
2019-01-30  9:52     ` Pu Wen [this message]
2019-01-30 10:08       ` Jan Beulich
2018-12-20 13:15 ` [PATCH 10/15] x86/domain: Add Hygon Dhyana support Pu Wen
2018-12-20 13:15 ` [PATCH 11/15] x86/domctl: " Pu Wen
2018-12-20 13:15 ` [PATCH 12/15] x86/traps: " Pu Wen
2019-01-29 11:10   ` Jan Beulich
2019-01-30  9:57     ` Pu Wen
2018-12-20 13:15 ` [PATCH 13/15] x86/xstate: " Pu Wen
2018-12-27 22:40   ` Andrew Cooper
2018-12-29  9:39     ` Pu Wen
2019-01-29 11:15   ` Jan Beulich
2019-01-30 10:47     ` Pu Wen
2018-12-20 13:15 ` [PATCH 14/15] x86/cpuid: " Pu Wen
2018-12-20 13:15 ` [PATCH 15/15] tools/libxc: " Pu Wen
2019-01-02 11:33   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbb2d4f6-75d1-49ad-a037-a2f472ef1754@hygon.cn \
    --to=puwen@hygon.cn \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.