* [Qemu-devel] [PATCH] hw/input/adb.c: set device category of adb
@ 2019-01-27 10:02 kumar sourav
2019-01-27 13:27 ` David Gibson
2019-01-28 9:06 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
0 siblings, 2 replies; 4+ messages in thread
From: kumar sourav @ 2019-01-27 10:02 UTC (permalink / raw)
To: qemu-trivial; +Cc: david, qemu-ppc, qemu-devel
Sets the category of adb as DEVICE_CATEGORY_INPUT
Devices should be assigned to one of DEVICE_CATEGORY_XXXX
Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
---
hw/input/adb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/input/adb.c b/hw/input/adb.c
index bbb40aeef1..6ca7c5641c 100644
--- a/hw/input/adb.c
+++ b/hw/input/adb.c
@@ -126,6 +126,7 @@ static void adb_device_class_init(ObjectClass *oc, void *data)
dc->realize = adb_device_realizefn;
dc->props = adb_device_properties;
dc->bus_type = TYPE_ADB_BUS;
+ set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
}
static const TypeInfo adb_device_type_info = {
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/input/adb.c: set device category of adb
2019-01-27 10:02 [Qemu-devel] [PATCH] hw/input/adb.c: set device category of adb kumar sourav
@ 2019-01-27 13:27 ` David Gibson
2019-01-28 9:06 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
1 sibling, 0 replies; 4+ messages in thread
From: David Gibson @ 2019-01-27 13:27 UTC (permalink / raw)
To: kumar sourav; +Cc: qemu-trivial, qemu-ppc, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 990 bytes --]
On Sun, Jan 27, 2019 at 03:32:15PM +0530, kumar sourav wrote:
> Sets the category of adb as DEVICE_CATEGORY_INPUT
> Devices should be assigned to one of DEVICE_CATEGORY_XXXX
>
> Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
Applied, thanks.
> ---
> hw/input/adb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/input/adb.c b/hw/input/adb.c
> index bbb40aeef1..6ca7c5641c 100644
> --- a/hw/input/adb.c
> +++ b/hw/input/adb.c
> @@ -126,6 +126,7 @@ static void adb_device_class_init(ObjectClass *oc, void *data)
> dc->realize = adb_device_realizefn;
> dc->props = adb_device_properties;
> dc->bus_type = TYPE_ADB_BUS;
> + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> }
>
> static const TypeInfo adb_device_type_info = {
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/input/adb.c: set device category of adb
2019-01-27 10:02 [Qemu-devel] [PATCH] hw/input/adb.c: set device category of adb kumar sourav
2019-01-27 13:27 ` David Gibson
@ 2019-01-28 9:06 ` Thomas Huth
2019-01-28 9:17 ` David Gibson
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Huth @ 2019-01-28 9:06 UTC (permalink / raw)
To: kumar sourav, qemu-trivial; +Cc: qemu-ppc, qemu-devel, david
On 2019-01-27 11:02, kumar sourav wrote:
> Sets the category of adb as DEVICE_CATEGORY_INPUT
> Devices should be assigned to one of DEVICE_CATEGORY_XXXX
>
> Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
> ---
> hw/input/adb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/input/adb.c b/hw/input/adb.c
> index bbb40aeef1..6ca7c5641c 100644
> --- a/hw/input/adb.c
> +++ b/hw/input/adb.c
> @@ -126,6 +126,7 @@ static void adb_device_class_init(ObjectClass *oc, void *data)
> dc->realize = adb_device_realizefn;
> dc->props = adb_device_properties;
> dc->bus_type = TYPE_ADB_BUS;
> + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> }
This patch does not make too much sense in its current shape:
TYPE_ADB_DEVICE is an abstract device and does not show up in the output
of "-device help", so it is not necessary for this device itself.
Looking at the "child" devices adb-kdb and adb-mouse, they bother
already set DEVICE_CATEGORY_INPUT in their own, so they are already fine.
Thus please do one of the following:
1) Simply drop this patch.
2) Keep setting the category here in the abstract parent class, but then
also remove the DEVICE_CATEGORY_INPUT in the adb-kdb and adb-mouse child
classes.
Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/input/adb.c: set device category of adb
2019-01-28 9:06 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
@ 2019-01-28 9:17 ` David Gibson
0 siblings, 0 replies; 4+ messages in thread
From: David Gibson @ 2019-01-28 9:17 UTC (permalink / raw)
To: Thomas Huth; +Cc: kumar sourav, qemu-trivial, qemu-ppc, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]
On Mon, Jan 28, 2019 at 10:06:03AM +0100, Thomas Huth wrote:
> On 2019-01-27 11:02, kumar sourav wrote:
> > Sets the category of adb as DEVICE_CATEGORY_INPUT
> > Devices should be assigned to one of DEVICE_CATEGORY_XXXX
> >
> > Signed-off-by: kumar sourav <sourav.jb1988@gmail.com>
> > ---
> > hw/input/adb.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/hw/input/adb.c b/hw/input/adb.c
> > index bbb40aeef1..6ca7c5641c 100644
> > --- a/hw/input/adb.c
> > +++ b/hw/input/adb.c
> > @@ -126,6 +126,7 @@ static void adb_device_class_init(ObjectClass *oc, void *data)
> > dc->realize = adb_device_realizefn;
> > dc->props = adb_device_properties;
> > dc->bus_type = TYPE_ADB_BUS;
> > + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> > }
>
> This patch does not make too much sense in its current shape:
> TYPE_ADB_DEVICE is an abstract device and does not show up in the output
> of "-device help", so it is not necessary for this device itself.
>
> Looking at the "child" devices adb-kdb and adb-mouse, they bother
> already set DEVICE_CATEGORY_INPUT in their own, so they are already fine.
>
> Thus please do one of the following:
>
> 1) Simply drop this patch.
>
> 2) Keep setting the category here in the abstract parent class, but then
> also remove the DEVICE_CATEGORY_INPUT in the adb-kdb and adb-mouse child
> classes.
Ah, good point. Dropped from ppc-for-4.0.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-28 9:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-27 10:02 [Qemu-devel] [PATCH] hw/input/adb.c: set device category of adb kumar sourav
2019-01-27 13:27 ` David Gibson
2019-01-28 9:06 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2019-01-28 9:17 ` David Gibson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.