[PATCH v2] Add nbdkit to extend backend possibilities of nbd.

[PATCH v2] Add nbdkit to extend backend possibilities of nbd.

[Przemyslaw Czarnowski]

Nbdkit uses plugins to add more sources of data for nbd client.
Nbdkit can also spawn nbd-client, uses unix or network socket to
communicate with client, uses different plugins to serve data for nbd
device eg. curl, file, custom plugins in many languages (perl, python)
and some others.

Signed-off-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@intel.com>
---
 .../recipes-support/nbdkit/nbdkit_git.bb      | 41 +++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 meta-networking/recipes-support/nbdkit/nbdkit_git.bb

diff --git a/meta-networking/recipes-support/nbdkit/nbdkit_git.bb b/meta-networking/recipes-support/nbdkit/nbdkit_git.bb
new file mode 100644
index 000000000..5f03bf823
--- /dev/null
+++ b/meta-networking/recipes-support/nbdkit/nbdkit_git.bb
@@ -0,0 +1,41 @@
+SUMMARY = "nbdkit is a toolkit for creating NBD servers."
+DESCRIPTION = "NBD — Network Block Device — is a protocol \
+for accessing Block Devices (hard disks and disk-like things) \
+over a Network. \
+\
+nbdkit is a toolkit for creating NBD servers."
+
+HOMEPAGE = "https://github.com/libguestfs/nbdkit"
+LICENSE = "BSD"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=4332a97808994cf2133a65b6c6f33eaf"
+
+SRC_URI = "git://github.com/libguestfs/nbdkit.git;protocol=https"
+
+PV = "1.19.6+git${SRCPV}"
+SRCREV = "257561bc9f2f01eb9f21686bcec4b863d17a26c4"
+
+S = "${WORKDIR}/git"
+
+DEPENDS = "curl xz e2fsprogs zlib"
+
+inherit pkgconfig python3native perlnative autotools
+# needed as nbdkit does not support build in external directory
+inherit autotools-brokensep
+
+# Those are required to build standalone
+EXTRA_OECONF = " --without-libvirt --without-libguestfs --disable-perl"
+
+# Disable some extended support (not desired for small embedded systems)
+#EXTRA_OECONF += " --disable-python"
+#EXTRA_OECONF += " --disable-ocaml"
+#EXTRA_OECONF += " --disable-rust"
+#EXTRA_OECONF += " --disable-ruby"
+#EXTRA_OECONF += " --disable-tcl"
+#EXTRA_OECONF += " --disable-lua"
+#EXTRA_OECONF += " --disable-vddk"
+
+do_install_append() {
+    rm -f ${D}/usr/share/bash-completion/completions/nbdkit
+    rmdir ${D}/usr/share/bash-completion/completions
+    rmdir ${D}/usr/share/bash-completion
+}
-- 
2.20.1

Re: [oe] [PATCH v2] Add nbdkit to extend backend possibilities of nbd.

[Khem Raj]

clang find an interesting failure

22:42:57 | main.c:116:2: error: embedding a #include directive within
macro arguments is not supported
22:42:57 | #include "synopsis.c"
22:42:57 |  ^
22:42:57 | main.c:115:3: note: expansion of macro 'printf' requested here
22:42:57 |   printf (
22:42:57 |   ^
22:42:57 | main.c:115:3: error: expected expression
22:42:57 |   printf (
22:42:57 |   ^

On Wed, Apr 8, 2020 at 4:39 PM Przemyslaw Czarnowski
<przemyslaw.hawrylewicz.czarnowski@intel.com> wrote:
>
> Nbdkit uses plugins to add more sources of data for nbd client.
> Nbdkit can also spawn nbd-client, uses unix or network socket to
> communicate with client, uses different plugins to serve data for nbd
> device eg. curl, file, custom plugins in many languages (perl, python)
> and some others.
>
> Signed-off-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@intel.com>
> ---
>  .../recipes-support/nbdkit/nbdkit_git.bb      | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 meta-networking/recipes-support/nbdkit/nbdkit_git.bb
>
> diff --git a/meta-networking/recipes-support/nbdkit/nbdkit_git.bb b/meta-networking/recipes-support/nbdkit/nbdkit_git.bb
> new file mode 100644
> index 000000000..5f03bf823
> --- /dev/null
> +++ b/meta-networking/recipes-support/nbdkit/nbdkit_git.bb
> @@ -0,0 +1,41 @@
> +SUMMARY = "nbdkit is a toolkit for creating NBD servers."
> +DESCRIPTION = "NBD — Network Block Device — is a protocol \
> +for accessing Block Devices (hard disks and disk-like things) \
> +over a Network. \
> +\
> +nbdkit is a toolkit for creating NBD servers."
> +
> +HOMEPAGE = "https://github.com/libguestfs/nbdkit"
> +LICENSE = "BSD"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=4332a97808994cf2133a65b6c6f33eaf"
> +
> +SRC_URI = "git://github.com/libguestfs/nbdkit.git;protocol=https"
> +
> +PV = "1.19.6+git${SRCPV}"
> +SRCREV = "257561bc9f2f01eb9f21686bcec4b863d17a26c4"
> +
> +S = "${WORKDIR}/git"
> +
> +DEPENDS = "curl xz e2fsprogs zlib"
> +
> +inherit pkgconfig python3native perlnative autotools
> +# needed as nbdkit does not support build in external directory
> +inherit autotools-brokensep
> +
> +# Those are required to build standalone
> +EXTRA_OECONF = " --without-libvirt --without-libguestfs --disable-perl"
> +
> +# Disable some extended support (not desired for small embedded systems)
> +#EXTRA_OECONF += " --disable-python"
> +#EXTRA_OECONF += " --disable-ocaml"
> +#EXTRA_OECONF += " --disable-rust"
> +#EXTRA_OECONF += " --disable-ruby"
> +#EXTRA_OECONF += " --disable-tcl"
> +#EXTRA_OECONF += " --disable-lua"
> +#EXTRA_OECONF += " --disable-vddk"
> +
> +do_install_append() {
> +    rm -f ${D}/usr/share/bash-completion/completions/nbdkit
> +    rmdir ${D}/usr/share/bash-completion/completions
> +    rmdir ${D}/usr/share/bash-completion
> +}
> --
> 2.20.1
>
> 

Re: [PATCH v2] Add nbdkit to extend backend possibilities of nbd.

[przemyslaw.hawrylewicz.czarnowski]

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

On Thursday, April 9, 2020 8:53 AM Khem Raj <raj.khem@gmail.com> wrote:

> clang find an interesting failure

>

> 22:42:57 | main.c:116:2: error: embedding a #include directive within macro

> arguments is not supported

> 22:42:57 | #include "synopsis.c"

> 22:42:57 | ^

Interesting indeed. This is not my sode, I am just using it in openBMC.
Is this something what prevents integration?

--

Best regards,
Przemysław Czarnowski

[-- Attachment #2: Type: text/html, Size: 38045 bytes --]

Re: [oe] [PATCH v2] Add nbdkit to extend backend possibilities of nbd.

[Khem Raj]

On Fri, Apr 10, 2020 at 3:17 AM
<przemyslaw.hawrylewicz.czarnowski@linux.intel.com> wrote:
>
>  On Thursday, April 9, 2020 8:53 AM Khem Raj <raj.khem@gmail.com> wrote:
>
>
>
> > clang find an interesting failure
>
> >
>
> > 22:42:57 | main.c:116:2: error: embedding a #include directive within macro
>
> > arguments is not supported
>
> > 22:42:57 | #include "synopsis.c"
>
> > 22:42:57 |  ^
>
> Interesting indeed. This is not my sode, I am just using it in openBMC.
> Is this something what prevents integration?
>

I took a stab at it and fixed it with few more cleanups that I would
have asked for. Sent a v3 with those changes in

> --
>
> Best regards,
> Przemysław Czarnowski
>
>