All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Tomasz Dziendzielski <tomasz.dziendzielski@gmail.com>
Cc: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] devtool: Fix source extraction for gcc shared source
Date: Tue, 19 Jan 2021 18:11:37 +0000	[thread overview]
Message-ID: <75dd1f1859c454c2f3ddf14707292f5ab444a834.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAJkqNs2jU7FVs5zdeBto2CysdyDUBgyFsWe2gDQKKxLR9UEgQw@mail.gmail.com>

On Tue, 2021-01-19 at 19:05 +0100, Tomasz Dziendzielski wrote:
> > > diff --git a/meta/recipes-devtools/gcc/gcc-shared-source.inc
> > > b/meta/recipes-devtools/gcc/gcc-shared-source.inc
> > > index aac4b49313..9ef80f2074 100644
> > > --- a/meta/recipes-devtools/gcc/gcc-shared-source.inc
> > > +++ b/meta/recipes-devtools/gcc/gcc-shared-source.inc
> > > @@ -2,6 +2,7 @@ do_fetch() {
> > >       :
> > >  }
> > >  do_fetch[noexec] = "1"
> > > +do_patch[noexec] = "1"
> > >  deltask do_unpack
> > >  deltask do_patch
> 
> > This is in itself a little odd. The "deltask do_patch" line deletes
> > the
> > task, so there is no task to set as noexec?
> 
> This was added because from the devtool script I couldn't find
> another way to determine if the task is run or not. If I add
> "do_patch[noexec]" (which logically doesn't change anything) even if
> task is deleted, I can check "if 'noexec' in d.getVarFlags(task,
> False)" and tell devtool to execute do_configure task dependencies
> (to prepare gcc sources).

Try checking if the "task" flag is set for "do_patch"?

Cheers,

Richard



  reply	other threads:[~2021-01-19 18:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 15:53 [PATCH] devtool: Fix source extraction for gcc shared source Tomasz Dziendzielski
2021-01-19 15:54 ` [OE-core] " Paul Barker
2021-01-19 16:44   ` Tomasz Dziendzielski
2021-01-19 17:49 ` Richard Purdie
2021-01-19 18:05   ` Tomasz Dziendzielski
2021-01-19 18:11     ` Richard Purdie [this message]
2021-01-19 18:57       ` Tomasz Dziendzielski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75dd1f1859c454c2f3ddf14707292f5ab444a834.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=tomasz.dziendzielski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.