Re: [OE-core] [PATCH] devtool: Fix source extraction for gcc shared source

From: "Tomasz Dziendzielski" <tomasz.dziendzielski@gmail.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] devtool: Fix source extraction for gcc shared source
Date: Tue, 19 Jan 2021 19:05:42 +0100	[thread overview]
Message-ID: <CAJkqNs2jU7FVs5zdeBto2CysdyDUBgyFsWe2gDQKKxLR9UEgQw@mail.gmail.com> (raw)
In-Reply-To: <107314c0428cf791bc195dd27d3cfe11bb9a4c3e.camel@linuxfoundation.org>

[-- Attachment #1: Type: text/plain, Size: 944 bytes --]

>> diff --git a/meta/recipes-devtools/gcc/gcc-shared-source.inc
b/meta/recipes-devtools/gcc/gcc-shared-source.inc
>> index aac4b49313..9ef80f2074 100644
>> --- a/meta/recipes-devtools/gcc/gcc-shared-source.inc
>> +++ b/meta/recipes-devtools/gcc/gcc-shared-source.inc
>> @@ -2,6 +2,7 @@ do_fetch() {
>>       :
>>  }
>>  do_fetch[noexec] = "1"
>> +do_patch[noexec] = "1"
>>  deltask do_unpack
>>  deltask do_patch

>This is in itself a little odd. The "deltask do_patch" line deletes the
>task, so there is no task to set as noexec?

This was added because from the devtool script I couldn't find another way
to determine if the task is run or not. If I add "do_patch[noexec]" (which
logically doesn't change anything) even if task is deleted, I can check "if
'noexec' in d.getVarFlags(task, False)" and tell devtool to execute
do_configure task dependencies (to prepare gcc sources).

Best regards,
Tomasz Dziendzielski

[-- Attachment #2: Type: text/html, Size: 1267 bytes --]