From: Grygorii Strashko <grygorii.strashko@ti.com> To: Tony Lindgren <tony@atomide.com>, Kalle Valo <kvalo@codeaurora.org> Cc: Eyal Reizer <eyalr@ti.com>, Kishon Vijay Abraham I <kishon@ti.com>, Guy Mishol <guym@ti.com>, Luca Coelho <luciano.coelho@intel.com>, Maital Hahn <maitalm@ti.com>, Maxim Altshul <maxim.altshul@ti.com>, <linux-wireless@vger.kernel.org>, <linux-omap@vger.kernel.org>, Eyal Reizer <eyalreizer@gmail.com> Subject: Re: [RFT 6/6] wlcore: Use generic runtime pm calls for wowlan elp configuration Date: Tue, 29 May 2018 14:23:05 -0500 [thread overview] Message-ID: <75fb865b-dc84-2e7d-d879-581e65dc343d@ti.com> (raw) In-Reply-To: <20180529180605.73622-7-tony@atomide.com> On 05/29/2018 01:06 PM, Tony Lindgren wrote: > From: Eyal Reizer <eyalreizer@gmail.com> > > With runtime PM enabled, we can now use generic calls to > pm_generic_runtime_suspend and pm_generic_runtime_resume for enabling elp > during suspend when wowlan is enabled and waking the chip from elp > on resume. Sry, but not sure you can :( These functions are not used by drivers directly because system suspend are not synchronized with PM runtime, so if you call pm_generic_runtime_suspend() and, at the same time, there is pm_runtime_get_() in progress --> race ... The pm_runtime_force_() APIs have to be used, or PM runtime drivers functions can be called directly, but only if it possible to be sure no other PM runtime calls active which is usually true at suspend_noirq stage. > > Remove the custom API that was used to ensure that the command > that is used to allow ELP during suspend is completed before the system > suspend. > > Signed-off-by: Eyal Reizer <eyalr@ti.com> > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > drivers/net/wireless/ti/wlcore/main.c | 51 +++++++-------------------- > 1 file changed, 13 insertions(+), 38 deletions(-) > > diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c > --- a/drivers/net/wireless/ti/wlcore/main.c > +++ b/drivers/net/wireless/ti/wlcore/main.c > @@ -998,24 +998,6 @@ static int wlcore_fw_wakeup(struct wl1271 *wl) > return wlcore_raw_write32(wl, HW_ACCESS_ELP_CTRL_REG, ELPCTRL_WAKE_UP); > } > > -static int wlcore_fw_sleep(struct wl1271 *wl) [...] -- regards, -grygorii
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org> To: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>, Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Cc: Eyal Reizer <eyalr-l0cyMroinI0@public.gmane.org>, Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>, Guy Mishol <guym-l0cyMroinI0@public.gmane.org>, Luca Coelho <luciano.coelho-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Maital Hahn <maitalm-l0cyMroinI0@public.gmane.org>, Maxim Altshul <maxim.altshul-l0cyMroinI0@public.gmane.org>, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Eyal Reizer <eyalreizer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Subject: Re: [RFT 6/6] wlcore: Use generic runtime pm calls for wowlan elp configuration Date: Tue, 29 May 2018 14:23:05 -0500 [thread overview] Message-ID: <75fb865b-dc84-2e7d-d879-581e65dc343d@ti.com> (raw) In-Reply-To: <20180529180605.73622-7-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> On 05/29/2018 01:06 PM, Tony Lindgren wrote: > From: Eyal Reizer <eyalreizer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > With runtime PM enabled, we can now use generic calls to > pm_generic_runtime_suspend and pm_generic_runtime_resume for enabling elp > during suspend when wowlan is enabled and waking the chip from elp > on resume. Sry, but not sure you can :( These functions are not used by drivers directly because system suspend are not synchronized with PM runtime, so if you call pm_generic_runtime_suspend() and, at the same time, there is pm_runtime_get_() in progress --> race ... The pm_runtime_force_() APIs have to be used, or PM runtime drivers functions can be called directly, but only if it possible to be sure no other PM runtime calls active which is usually true at suspend_noirq stage. > > Remove the custom API that was used to ensure that the command > that is used to allow ELP during suspend is completed before the system > suspend. > > Signed-off-by: Eyal Reizer <eyalr-l0cyMroinI0@public.gmane.org> > Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> > --- > drivers/net/wireless/ti/wlcore/main.c | 51 +++++++-------------------- > 1 file changed, 13 insertions(+), 38 deletions(-) > > diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c > --- a/drivers/net/wireless/ti/wlcore/main.c > +++ b/drivers/net/wireless/ti/wlcore/main.c > @@ -998,24 +998,6 @@ static int wlcore_fw_wakeup(struct wl1271 *wl) > return wlcore_raw_write32(wl, HW_ACCESS_ELP_CTRL_REG, ELPCTRL_WAKE_UP); > } > > -static int wlcore_fw_sleep(struct wl1271 *wl) [...] -- regards, -grygorii
next prev parent reply other threads:[~2018-05-29 19:23 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-29 18:05 [RFTv3 0/6] Runtime PM support for wlcore Tony Lindgren 2018-05-29 18:05 ` Tony Lindgren 2018-05-29 18:06 ` [RFT 1/6] wlcore: Add missing PM call for wlcore_cmd_wait_for_event_or_timeout() Tony Lindgren 2018-05-29 18:06 ` Tony Lindgren 2018-05-31 17:17 ` [RFT 7/6] wlcore: Make sure firmware is initialized in wl1271_op_add_interface() Tony Lindgren 2018-05-31 17:17 ` Tony Lindgren 2018-05-29 18:06 ` [RFT 2/6] wlcore: Make sure PM calls are paired Tony Lindgren 2018-05-29 18:06 ` Tony Lindgren 2018-05-29 18:06 ` [RFT 3/6] wlcore: Add support for runtime PM Tony Lindgren 2018-05-29 18:06 ` Tony Lindgren 2018-05-31 17:14 ` Tony Lindgren 2018-05-31 17:14 ` Tony Lindgren 2018-06-03 6:04 ` [EXTERNAL] " Reizer, Eyal 2018-06-03 6:04 ` Reizer, Eyal 2018-06-05 4:20 ` Tony Lindgren 2018-06-05 4:20 ` Tony Lindgren 2018-06-05 10:44 ` Tony Lindgren 2018-06-05 10:44 ` Tony Lindgren 2018-06-05 10:49 ` Reizer, Eyal 2018-06-05 10:49 ` Reizer, Eyal 2018-06-06 12:20 ` Reizer, Eyal 2018-06-06 12:20 ` Reizer, Eyal 2018-06-13 6:42 ` Tony Lindgren 2018-06-13 6:42 ` Tony Lindgren 2018-06-14 8:36 ` Reizer, Eyal 2018-06-14 8:36 ` Reizer, Eyal 2018-06-14 11:29 ` Reizer, Eyal 2018-06-14 11:29 ` Reizer, Eyal 2018-06-15 5:04 ` Tony Lindgren 2018-06-15 5:04 ` Tony Lindgren 2018-05-29 18:06 ` [RFT 4/6] wlcore: Fix misplaced PM call for scan_complete_work() Tony Lindgren 2018-05-29 18:06 ` Tony Lindgren 2018-05-29 18:06 ` [RFT 5/6] wclore: Fix timout errors after recovery Tony Lindgren 2018-05-29 18:06 ` Tony Lindgren 2018-05-29 18:06 ` [RFT 6/6] wlcore: Use generic runtime pm calls for wowlan elp configuration Tony Lindgren 2018-05-29 18:06 ` Tony Lindgren 2018-05-29 19:23 ` Grygorii Strashko [this message] 2018-05-29 19:23 ` Grygorii Strashko 2018-05-29 21:40 ` Tony Lindgren 2018-05-29 21:40 ` Tony Lindgren 2018-05-31 17:56 ` [RFTv3 8/6] wlcore: Enable runtime PM autosuspend support Tony Lindgren 2018-05-31 17:56 ` Tony Lindgren 2018-05-30 6:34 [RFT 6/6] wlcore: Use generic runtime pm calls for wowlan elp configuration Reizer, Eyal 2018-05-30 6:34 ` Reizer, Eyal 2018-05-30 21:44 ` Tony Lindgren 2018-05-30 21:44 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=75fb865b-dc84-2e7d-d879-581e65dc343d@ti.com \ --to=grygorii.strashko@ti.com \ --cc=eyalr@ti.com \ --cc=eyalreizer@gmail.com \ --cc=guym@ti.com \ --cc=kishon@ti.com \ --cc=kvalo@codeaurora.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=luciano.coelho@intel.com \ --cc=maitalm@ti.com \ --cc=maxim.altshul@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.