* [PATCH] netxen: Fix Unlikely(x) > y
@ 2009-10-06 13:23 Roel Kluin
2009-10-07 5:34 ` Dhananjay Phadke
0 siblings, 1 reply; 3+ messages in thread
From: Roel Kluin @ 2009-10-06 13:23 UTC (permalink / raw)
To: Dhananjay Phadke, netdev, Andrew Morton
The closing parenthesis was not on the right location.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
This was intended, I think?
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index b5aa974..9b9eab1 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -1714,7 +1714,7 @@ netxen_nic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
/* 4 fragments per cmd des */
no_of_desc = (frag_count + 3) >> 2;
- if (unlikely(no_of_desc + 2) > netxen_tx_avail(tx_ring)) {
+ if (unlikely(no_of_desc + 2 > netxen_tx_avail(tx_ring))) {
netif_stop_queue(netdev);
return NETDEV_TX_BUSY;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] netxen: Fix Unlikely(x) > y
2009-10-06 13:23 [PATCH] netxen: Fix Unlikely(x) > y Roel Kluin
@ 2009-10-07 5:34 ` Dhananjay Phadke
2009-10-07 10:42 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Dhananjay Phadke @ 2009-10-07 5:34 UTC (permalink / raw)
To: Roel Kluin, netdev, Andrew Morton
Oh sure, that was a typo. Thanks for catching it.
Acked-by: Dhananjay Phadke <dhananjay@netxen.com>
-----Original Message-----
From: Roel Kluin [mailto:roel.kluin@gmail.com]
Sent: Tuesday, October 06, 2009 06:24
To: Dhananjay Phadke; netdev@vger.kernel.org; Andrew Morton
Subject: [PATCH] netxen: Fix Unlikely(x) > y
The closing parenthesis was not on the right location.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
This was intended, I think?
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index b5aa974..9b9eab1 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -1714,7 +1714,7 @@ netxen_nic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
/* 4 fragments per cmd des */
no_of_desc = (frag_count + 3) >> 2;
- if (unlikely(no_of_desc + 2) > netxen_tx_avail(tx_ring)) {
+ if (unlikely(no_of_desc + 2 > netxen_tx_avail(tx_ring))) {
netif_stop_queue(netdev);
return NETDEV_TX_BUSY;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] netxen: Fix Unlikely(x) > y
2009-10-07 5:34 ` Dhananjay Phadke
@ 2009-10-07 10:42 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-10-07 10:42 UTC (permalink / raw)
To: dhananjay.phadke; +Cc: roel.kluin, netdev, akpm
From: Dhananjay Phadke <dhananjay.phadke@qlogic.com>
Date: Tue, 6 Oct 2009 22:34:39 -0700
> Oh sure, that was a typo. Thanks for catching it.
>
> Acked-by: Dhananjay Phadke <dhananjay@netxen.com>
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-07 10:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-06 13:23 [PATCH] netxen: Fix Unlikely(x) > y Roel Kluin
2009-10-07 5:34 ` Dhananjay Phadke
2009-10-07 10:42 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.