i8k: fails to detect Dell XPS M1530, fails to get SMM BIOS version with force=1

i8k: fails to detect Dell XPS M1530, fails to get SMM BIOS version with force=1

[Andrew Paprocki]

I see two problems with the i8k module and the Dell XPS M1530. First,
the laptop is not detected. Second, even if it is detected, the module
prints that it is unable to get the SMM BIOS version even though the
module appears to be working:

# modprobe i8k force=1
# dmesg | grep i8k
[  547.007217] i8k: not running on a supported Dell system.
[  547.007234] i8k: vendor=Dell Inc., model=XPS M1530
     , version=A08
[  547.007629] i8k: unable to get SMM BIOS version
# cat /proc/i8k
1.0 A08 5D26YF1 53 0 0 0 0 -1 -22

Information from DMI:

BIOS Information
        Vendor: Dell Inc.
        Version: A08
        Release Date: 03/19/2008

System Information
        Manufacturer: Dell Inc.
        Product Name: XPS M1530

It seems straightforward to add a record for the auto-detection, but
I'm not sure how generic it should be. From looking online, it appears
the M1330, M1530, and M1730 all need to be detected. Perhaps it should
just be "Dell XPS M Series" and only match on "XPS M"? Does anyone
else on the list use these laptops?

Thanks,
-Andrew

--- a/drivers/char/i8k.c
+++ b/drivers/char/i8k.c
@@ -485,6 +485,13 @@ static struct dmi_system_id __initdata i8k_dmi_table[] = {
                        DMI_MATCH(DMI_PRODUCT_NAME, "MP061"),
                },
        },
+       {
+               .ident = "Dell XPS M1530",
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "XPS M1530"),
+               },
+       },
        { }
 };

Re: i8k: fails to detect Dell XPS M1530, fails to get SMM BIOS version with force=1

[Andrew Paprocki]

On Wed, Dec 17, 2008 at 7:34 PM, Andrew Paprocki <andrew@ishiboo.com> wrote:
> I see two problems with the i8k module and the Dell XPS M1530. First,
> the laptop is not detected. Second, even if it is detected, the module
> prints that it is unable to get the SMM BIOS version even though the
> module appears to be working:

It appears that the Dell Vostro & Precision series have the same issue
and the driver was never updated for those as well. Patches were
submitted back in 2007-11 and 2008-04 respectively:

http://marc.info/?l=linux-kernel&m=119401935026583&w=2
http://marc.info/?l=linux-kernel&m=120822526223412&w=2

The same message prints for (at least one of) those as well:

i8k: unable to get SMM BIOS version

-Andrew

Re: i8k: fails to detect Dell XPS M1530, fails to get SMM BIOS version with force=1

[Andrew Morton]

On Wed, 17 Dec 2008 20:07:02 -0500 "Andrew Paprocki" <andrew@ishiboo.com> wrote:

> On Wed, Dec 17, 2008 at 7:34 PM, Andrew Paprocki <andrew@ishiboo.com> wrote:
> > I see two problems with the i8k module and the Dell XPS M1530. First,
> > the laptop is not detected. Second, even if it is detected, the module
> > prints that it is unable to get the SMM BIOS version even though the
> > module appears to be working:
> 
> It appears that the Dell Vostro & Precision series have the same issue
> and the driver was never updated for those as well. Patches were
> submitted back in 2007-11 and 2008-04 respectively:
> 
> http://marc.info/?l=linux-kernel&m=119401935026583&w=2
> http://marc.info/?l=linux-kernel&m=120822526223412&w=2

Thanks, I picked up all three (much to various people's surprise, I expect).

> The same message prints for (at least one of) those as well:
> 
> i8k: unable to get SMM BIOS version

hm.  But the driver works OK anyway?

Re: i8k: fails to detect Dell XPS M1530, fails to get SMM BIOS version with force=1

[Andrew Paprocki]

On Thu, Dec 18, 2008 at 1:22 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
>> The same message prints for (at least one of) those as well:
>>
>> i8k: unable to get SMM BIOS version
>
> hm.  But the driver works OK anyway?

It appears to work.

I tried to figure out why the SMM message is printing out. I can't
find any reference for the #defined values in i8k.c. The only prior
source code I can find mentioning some of them appears to be from the
Windows fanio driver inside the i8kfangui source code
(i8kfangui31-src.zip). Those constants seem to have been reverse
engineered by disassembling the nbsvc.mdm (really an MS-DOS
executable) that Dell puts in the first partition of the laptop hard
drive.

Is there a valid reference for how this SMM mechanism works and what
the inputs/outputs are? There must be some other snippets of code
around because there are a few values in i8k.c which are not in
i8kfangui31-src.zip. I could help with this code if anyone has a
reliable source for this information. The i8kfangui31 source mentions
V1266, and if I strings my copy of nbsvc.mdm, I see V1323. I'm not
sure how this (incomplete) table was derived.

--- begin paste

  According to the module NBSVC.MDM the following SMM (System
Management Mode) functions are currently available (V1266):

  cmd     function
  0x00a3  get current speed indicator of a fan (args: fan)
  0x01a3  set speed of a fan (args: fan & speed)
  0x02a3  get RPM of a fan (args: fan)
  0x03a3  ??? (1 byte)
  0x04a3  get nominal fan speed (2 args)
  0x05a3  get fan tolerance speed (2 args)
  0x10a3  get sensor temperature (1 arg: sensor#)
  0x11a3  ???
  0x12a3  arg 0x0003=NBSVC-Query
          arg 0x0000=NBSVC-Clear
          arg 0x122=NBSVC-Start Trend
          arg 0x0100=NBSVC-Stop Trend
          arg 0x02??=NBSVC-Read
  0x21a3  ??? (2 args: 1 byte (oder 0x16) + 1 byte)
  0x22a3  get charger info (1 arg)
  0x23a3  ??? (4 args: 2x 1 byte, 1xword, 1xdword)
  0x24a3  get adaptor info status (1 arg oder 0x03)
  0x30a3  ??? (no args)
  0x31a3  ??? (no args)
  0x32a3  ??? (no args)
  0x33a3  ??? (no args)
  0x36a3  get hotkey scancode list (args see diags)
  0x37a3  ??? (no args)
  0x40a3  get docking state (no args)
  0xf0a3  ??? (2 args)
  0xfea3  check SMBIOS version (1 arg)
  0xffa3  check SMBIOS interface (returns:"DELLDIAG")

Re: i8k: fails to detect Dell XPS M1530, fails to get SMM BIOS version with force=1

[Alan Cox]

On Wed, 17 Dec 2008 20:07:02 -0500
"Andrew Paprocki" <andrew@ishiboo.com> wrote:

> On Wed, Dec 17, 2008 at 7:34 PM, Andrew Paprocki <andrew@ishiboo.com> wrote:
> > I see two problems with the i8k module and the Dell XPS M1530. First,
> > the laptop is not detected. Second, even if it is detected, the module
> > prints that it is unable to get the SMM BIOS version even though the
> > module appears to be working:
> 
> It appears that the Dell Vostro & Precision series have the same issue
> and the driver was never updated for those as well. Patches were
> submitted back in 2007-11 and 2008-04 respectively:
> 
> http://marc.info/?l=linux-kernel&m=119401935026583&w=2
> http://marc.info/?l=linux-kernel&m=120822526223412&w=2

I can find no copies of them with Signed-off-by: lines so they appear to
have escaped. If the authors of those changes would care to provided
Signed-off-by: lines I'll chase this up further.

Re: i8k: fails to detect Dell XPS M1530, fails to get SMM BIOS version with force=1

[Matthew Garrett]

My understanding is that the documented way of making SMM calls on any 
Dell system is using the interface in the dcdbas driver. dell-laptop 
uses this to export some of the information that i8k handles (and a 
bunch of other stuff) but not all of it. Asking about fan information on 
the libsmbios mailing list might get us the documented access method for 
that, and then dell-laptop can be extended to export that ia the hwmon 
interface.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: i8k: fails to detect Dell XPS M1530, fails to get SMM BIOS version with force=1

[Federico Heinz]

On 21/12/2008, Alan Cox wrote:
> I can find no copies of them with Signed-off-by: lines so they appear to
> have escaped. If the authors of those changes would care to provided
> Signed-off-by: lines I'll chase this up further.

This trivial patch adds support for i8k on the new Dell Vostro models.
I tested it on my Vostro 1400, and it works. It does print a warning
when loading the module:

	i8k: unable to get SMM BIOS version

But I couldn't figure out how to fix that. The module seems to work fine,
anyway...

Signed-off-by: Federico Heinz <fheinz@vialibre.org.ar>

--- drivers/char/i8k.c.orig     2007-07-08 20:32:17.000000000 -0300
+++ drivers/char/i8k.c  2007-09-27 03:06:08.000000000 -0300
@@ -439,6 +439,13 @@
                        DMI_MATCH(DMI_PRODUCT_NAME, "Latitude"),
                },
        },
+       {
+               .ident = "Dell Vostro",
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "Vostro"),
+               },
+       },
        { }
 };

Re: i8k: fails to detect Dell XPS M1530, fails to get SMM BIOS version with force=1

[Andy Spencer]

[-- Attachment #1: Type: text/plain, Size: 780 bytes --]

On Sun, Dec 21, 2008 at 09:41:09AM -0500, Alan Cox wrote:
> I can find no copies of them with Signed-off-by: lines so they appear
> to have escaped. If the authors of those changes would care to
> provided Signed-off-by: lines I'll chase this up further.

Patch to enable i8k on Dell Precisions.

Signed-off-by: Andy Spencer <spenceal@rose-hulman.edu>

diff --git a/drivers/char/i8k.c b/drivers/char/i8k.c
index b60d425..099fc89 100644
--- a/drivers/char/i8k.c
+++ b/drivers/char/i8k.c
@@ -485,6 +485,13 @@ static struct dmi_system_id __initdata i8k_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "MP061"),
 		},
 	},
+	{
+		.ident = "Dell Precision",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Precision"),
+		},
+	},
 	{ }
 };

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]