From: Richard Henderson <rth@twiddle.net>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>,
qemu-ppc@nongnu.org, david@gibson.dropbear.id.au
Cc: qemu-devel@nongnu.org, benh@kernel.crashing.org
Subject: Re: [Qemu-devel] [PATCH 3/6] target-ppc: add lxsi[bw]zx instruction
Date: Mon, 8 Aug 2016 10:38:14 +0530 [thread overview]
Message-ID: <76465f4d-6c9d-a90b-1efa-68bc7b7ac98c@twiddle.net> (raw)
In-Reply-To: <1470591415-3268-4-git-send-email-nikunj@linux.vnet.ibm.com>
On 08/07/2016 11:06 PM, Nikunj A Dadhania wrote:
> +#define GEN_QEMU_LOAD_64(ldop, ext) \
> +static void glue(gen_qemu_, glue(ldop, _i64))(DisasContext *ctx, \
> + TCGv_i64 val, \
> + TCGv addr) \
> +{ \
> + TCGv tmp = tcg_temp_new(); \
> + gen_qemu_##ldop(ctx, tmp, addr); \
> + tcg_gen_##ext##_tl_i64(val, tmp); \
> + tcg_temp_free(tmp); \
> }
>
> +GEN_QEMU_LOAD_64(ld8u, extu)
> +GEN_QEMU_LOAD_64(ld16u, extu)
> +GEN_QEMU_LOAD_64(ld32u, extu)
> +GEN_QEMU_LOAD_64(ld32s, ext)
This is a good opportunity to clean up a bit of the ppc translator and convert
to the newer tcg_gen_qemu_ld_i64 function. This will eliminate the need for
the extension that you're performing here.
r~
next prev parent reply other threads:[~2016-08-08 5:08 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-07 17:36 [Qemu-devel] [PATCH 0/6] POWER9 TCG enablements - part4 Nikunj A Dadhania
2016-08-07 17:36 ` [Qemu-devel] [PATCH 1/6] target-ppc: add xxspltib instruction Nikunj A Dadhania
2016-08-08 4:43 ` Richard Henderson
2016-08-08 6:19 ` Nikunj A Dadhania
2016-08-07 17:36 ` [Qemu-devel] [PATCH 2/6] target-ppc: Implement darn instruction Nikunj A Dadhania
2016-08-07 21:33 ` Benjamin Herrenschmidt
2016-08-08 1:52 ` Nikunj A Dadhania
2016-08-08 3:22 ` Benjamin Herrenschmidt
2016-08-08 3:32 ` Nikunj A Dadhania
2016-08-09 3:28 ` David Gibson
2016-08-09 4:54 ` Nikunj A Dadhania
2016-08-09 9:17 ` [Qemu-devel] [Qemu-ppc] " Nikunj A Dadhania
2016-08-12 6:29 ` David Gibson
2016-08-12 6:43 ` Nikunj A Dadhania
2016-08-12 6:56 ` David Gibson
2016-08-12 7:13 ` Nikunj A Dadhania
2016-08-12 7:29 ` Thomas Huth
2016-08-12 7:39 ` Nikunj A Dadhania
2016-08-12 7:55 ` Thomas Huth
2016-08-12 8:41 ` Nikunj A Dadhania
2016-08-12 9:29 ` Thomas Huth
2016-08-12 9:51 ` Nikunj A Dadhania
2016-08-12 13:26 ` Richard Henderson
2016-08-12 13:39 ` Nikunj A Dadhania
2016-08-15 10:28 ` David Gibson
2016-08-08 5:01 ` [Qemu-devel] " Richard Henderson
2016-08-08 6:20 ` Nikunj A Dadhania
2016-08-07 17:36 ` [Qemu-devel] [PATCH 3/6] target-ppc: add lxsi[bw]zx instruction Nikunj A Dadhania
2016-08-08 5:08 ` Richard Henderson [this message]
2016-08-08 6:21 ` Nikunj A Dadhania
2016-08-07 17:36 ` [Qemu-devel] [PATCH 4/6] target-ppc: add stxsi[bh]x instruction Nikunj A Dadhania
2016-08-08 5:08 ` Richard Henderson
2016-08-07 17:36 ` [Qemu-devel] [PATCH 5/6] target-ppc: add lxvb16x and lxvh8x Nikunj A Dadhania
2016-08-08 5:27 ` Richard Henderson
2016-08-08 6:35 ` Richard Henderson
2016-08-10 9:21 ` Nikunj A Dadhania
2016-08-10 10:12 ` Richard Henderson
2016-08-10 10:33 ` Nikunj A Dadhania
2016-08-10 15:21 ` Nikunj A Dadhania
2016-08-07 17:36 ` [Qemu-devel] [PATCH 6/6] target-ppc: add stxvb16x and stxvh8x Nikunj A Dadhania
2016-08-08 5:27 ` Richard Henderson
2016-08-09 3:30 ` [Qemu-devel] [PATCH 0/6] POWER9 TCG enablements - part4 David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76465f4d-6c9d-a90b-1efa-68bc7b7ac98c@twiddle.net \
--to=rth@twiddle.net \
--cc=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.