Re: [Qemu-devel] [PATCH 2/6] target-ppc: Implement darn instruction

From: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	qemu-ppc@nongnu.org, david@gibson.dropbear.id.au,
	rth@twiddle.net
Cc: qemu-devel@nongnu.org, Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 2/6] target-ppc: Implement darn instruction
Date: Mon, 08 Aug 2016 07:22:13 +0530	[thread overview]
Message-ID: <87fuqgxc1e.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <1470605617.12584.182.camel@kernel.crashing.org>

Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:

> On Sun, 2016-08-07 at 23:06 +0530, Nikunj A Dadhania wrote:
>> +target_ulong helper_darn(uint32_t l)
>> +{
>> +    target_ulong r = UINT64_MAX;
>> +
>> +    if (l <= 2) {
>> +        do {
>> +            r = random() * random();
>> +            r &= l ? UINT64_MAX : UINT32_MAX;
>> +        } while (r == UINT64_MAX);
>> +    }
>> +
>> +    return r;
>> +}
>>  #endif
>
> Isn't this a bit week ? Look at the implementation of H_RANDOM...

Sure, will have a look.

Regards,
Nikunj