Suggested commit orden for patchsets?

Suggested commit orden for patchsets?

[Javier Arias]

[-- Attachment #1.1: Type: text/plain, Size: 601 bytes --]

Hello everyone,

I have a question related to the commit order, as I received feedback about 
how a commit order makes more sense for patchsets, but when I start finding 
an specific issue the next commits in the patchset are usually just to fix 
warnings displayed by checkpatch after the first fix, so I don't feel like 
changing the commit order would be productive for me.

So my question are:
Is there a suggested commit order for patchsets even if this is the case?
is it enough if I describe the reason why I used certain commit order in 
the cover letter?

Thanks in advance for your answers.

[-- Attachment #1.2: Type: text/html, Size: 731 bytes --]

Re: [Outreachy kernel] Suggested commit orden for patchsets?

[Vaishali Thakkar]

On Mon, Oct 21, 2019 at 9:55 AM Javier Arias <jarias.linux@gmail.com> wrote:
>
> Hello everyone,

Hi Javier,

> I have a question related to the commit order, as I received feedback about how a commit order makes more sense for patchsets, but when I start finding an specific issue the next commits in the patchset are usually just to fix warnings displayed by checkpatch after the first fix, so I don't feel like changing the commit order would be productive for me.

I'm not sure if I understand your question correctly but your
first fix shouldn't introduce any new warnings. Every fix you
do or every commit you create should not have any
checkpatch warnings.

Also, can you possibly provide a link to which feedback
you're talking about here so that people can check it
and give you suggestions accordingly for your confusion.

> So my question are:
> Is there a suggested commit order for patchsets even if this is the case?
> is it enough if I describe the reason why I used certain commit order in the cover letter?
>
> Thanks in advance for your answers.
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/399e73f8-1ba5-4e5c-a4dc-9f19f6de8fb8%40googlegroups.com.

Re: [Outreachy kernel] Suggested commit orden for patchsets?

[Vaishali Thakkar]

On Mon, Oct 21, 2019 at 10:49 AM Vaishali Thakkar
<vthakkar@vaishalithakkar.in> wrote:
>
> On Mon, Oct 21, 2019 at 9:55 AM Javier Arias <jarias.linux@gmail.com> wrote:
> >
> > Hello everyone,
>
> Hi Javier,
>
> > I have a question related to the commit order, as I received feedback about how a commit order makes more sense for patchsets, but when I start finding an specific issue the next commits in the patchset are usually just to fix warnings displayed by checkpatch after the first fix, so I don't feel like changing the commit order would be productive for me.
>
> I'm not sure if I understand your question correctly but your
> first fix shouldn't introduce any new warnings. Every fix you
> do or every commit you create should not have any
> checkpatch warnings.
>
> Also, can you possibly provide a link to which feedback
> you're talking about here so that people can check it
> and give you suggestions accordingly for your confusion.

Also, if you're looking for a detailed document on the ordering
of commits based on the type of fix, you can find it here:

https://kernelnewbies.org/PatchPhilosophy#How_to_break_up_changes

> > So my question are:
> > Is there a suggested commit order for patchsets even if this is the case?
> > is it enough if I describe the reason why I used certain commit order in the cover letter?
> >
> > Thanks in advance for your answers.
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/399e73f8-1ba5-4e5c-a4dc-9f19f6de8fb8%40googlegroups.com.

Re: [Outreachy kernel] Suggested commit orden for patchsets?

[Javier Arias]

[-- Attachment #1.1: Type: text/plain, Size: 2184 bytes --]

Sorry for the late answer.

My fix didn't introduce new warnings, but there were more warnings in that 
line. For example, I would be looking for comparison with boolean and fix 
most, but many also has +80 columns and camelcase.

The feedback I received is this one: 
https://groups.google.com/d/msg/outreachy-kernel/9GgwTurOJ4w/k1O_Bv_jBwAJ

This is where I was a little confused, as I didn't get why would it make 
more sense to solve the 80 chars issue first, when the first issue I wanted 
to patch was the "Replace string with identifier".

On Monday, 21 October 2019 00:19:51 UTC-5, Vaishali Thakkar wrote:
>
> On Mon, Oct 21, 2019 at 9:55 AM Javier Arias <jaria...@gmail.com 
> <javascript:>> wrote: 
> > 
> > Hello everyone, 
>
> Hi Javier, 
>
> > I have a question related to the commit order, as I received feedback 
> about how a commit order makes more sense for patchsets, but when I start 
> finding an specific issue the next commits in the patchset are usually just 
> to fix warnings displayed by checkpatch after the first fix, so I don't 
> feel like changing the commit order would be productive for me. 
>
> I'm not sure if I understand your question correctly but your 
> first fix shouldn't introduce any new warnings. Every fix you 
> do or every commit you create should not have any 
> checkpatch warnings. 
>
> Also, can you possibly provide a link to which feedback 
> you're talking about here so that people can check it 
> and give you suggestions accordingly for your confusion. 
>
> > So my question are: 
> > Is there a suggested commit order for patchsets even if this is the 
> case? 
> > is it enough if I describe the reason why I used certain commit order in 
> the cover letter? 
> > 
> > Thanks in advance for your answers. 
> > 
> > -- 
> > You received this message because you are subscribed to the Google 
> Groups "outreachy-kernel" group. 
> > To unsubscribe from this group and stop receiving emails from it, send 
> an email to outreach...@googlegroups.com <javascript:>. 
> > To view this discussion on the web visit 
> https://groups.google.com/d/msgid/outreachy-kernel/399e73f8-1ba5-4e5c-a4dc-9f19f6de8fb8%40googlegroups.com. 
>
>

[-- Attachment #1.2: Type: text/html, Size: 3408 bytes --]