* [Intel-gfx] [PATCH] drm/i915/gt: prevent forcewake releases during BAR resize
@ 2023-03-08 11:23 Andrzej Hajda
2023-03-08 13:16 ` Rodrigo Vivi
` (3 more replies)
0 siblings, 4 replies; 14+ messages in thread
From: Andrzej Hajda @ 2023-03-08 11:23 UTC (permalink / raw)
To: intel-gfx
Cc: Andrzej Hajda, Matthew Auld, Rodrigo Vivi, chris.p.wilson, Nirmoy Das
Tests on DG2 machines show that releasing forcewakes during BAR resize
results later in forcewake ack timeouts. Since forcewakes can be realeased
asynchronously the simplest way to prevent it is to get all forcewakes
for duration of BAR resizing.
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
drivers/gpu/drm/i915/gt/intel_region_lmem.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
index 89fdfc67f8d1e0..5a01dc6ca08324 100644
--- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
+++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
@@ -54,6 +54,7 @@ static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t
struct resource *root_res;
resource_size_t rebar_size;
resource_size_t current_size;
+ intel_wakeref_t wakeref;
u32 pci_cmd;
int i;
@@ -102,6 +103,14 @@ static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t
return;
}
+ /*
+ * Releasing forcewake during BAR resizing results in later forcewake
+ * ack timeouts and former can happen any time - it is asynchronous.
+ * Grabbing all forcewakes prevents it.
+ */
+ with_intel_runtime_pm(i915->uncore.rpm, wakeref)
+ intel_uncore_forcewake_get(&i915->uncore, FORCEWAKE_ALL);
+
/* First disable PCI memory decoding references */
pci_read_config_dword(pdev, PCI_COMMAND, &pci_cmd);
pci_write_config_dword(pdev, PCI_COMMAND,
@@ -111,6 +120,9 @@ static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t
pci_assign_unassigned_bus_resources(pdev->bus);
pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd);
+
+ with_intel_runtime_pm(i915->uncore.rpm, wakeref)
+ intel_uncore_forcewake_put(&i915->uncore, FORCEWAKE_ALL);
}
#else
static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t lmem_size) {}
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: prevent forcewake releases during BAR resize
2023-03-08 11:23 [Intel-gfx] [PATCH] drm/i915/gt: prevent forcewake releases during BAR resize Andrzej Hajda
@ 2023-03-08 13:16 ` Rodrigo Vivi
2023-03-08 13:34 ` Andrzej Hajda
2023-03-08 13:36 ` [Intel-gfx] [PATCH v2] " Andrzej Hajda
2023-03-08 15:44 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: prevent forcewake releases during BAR resize (rev3) Patchwork
` (2 subsequent siblings)
3 siblings, 2 replies; 14+ messages in thread
From: Rodrigo Vivi @ 2023-03-08 13:16 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx, Matthew Auld, chris.p.wilson, Nirmoy Das
On Wed, Mar 08, 2023 at 12:23:49PM +0100, Andrzej Hajda wrote:
> Tests on DG2 machines show that releasing forcewakes during BAR resize
> results later in forcewake ack timeouts. Since forcewakes can be realeased
> asynchronously the simplest way to prevent it is to get all forcewakes
> for duration of BAR resizing.
>
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_region_lmem.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> index 89fdfc67f8d1e0..5a01dc6ca08324 100644
> --- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> +++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> @@ -54,6 +54,7 @@ static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t
> struct resource *root_res;
> resource_size_t rebar_size;
> resource_size_t current_size;
> + intel_wakeref_t wakeref;
> u32 pci_cmd;
> int i;
>
> @@ -102,6 +103,14 @@ static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t
> return;
> }
>
> + /*
> + * Releasing forcewake during BAR resizing results in later forcewake
> + * ack timeouts and former can happen any time - it is asynchronous.
> + * Grabbing all forcewakes prevents it.
> + */
> + with_intel_runtime_pm(i915->uncore.rpm, wakeref)
I believe that instead of the with_rpm you should probably get the rpm ref here
and return after returning the forcewake put. So you also ensure that we are
not going to suspend and allowing D3 during the resize.
> + intel_uncore_forcewake_get(&i915->uncore, FORCEWAKE_ALL);
> +
> /* First disable PCI memory decoding references */
> pci_read_config_dword(pdev, PCI_COMMAND, &pci_cmd);
> pci_write_config_dword(pdev, PCI_COMMAND,
> @@ -111,6 +120,9 @@ static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t
>
> pci_assign_unassigned_bus_resources(pdev->bus);
> pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd);
> +
> + with_intel_runtime_pm(i915->uncore.rpm, wakeref)
> + intel_uncore_forcewake_put(&i915->uncore, FORCEWAKE_ALL);
> }
> #else
> static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t lmem_size) {}
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/gt: prevent forcewake releases during BAR resize
2023-03-08 13:16 ` Rodrigo Vivi
@ 2023-03-08 13:34 ` Andrzej Hajda
2023-03-08 13:36 ` [Intel-gfx] [PATCH v2] " Andrzej Hajda
1 sibling, 0 replies; 14+ messages in thread
From: Andrzej Hajda @ 2023-03-08 13:34 UTC (permalink / raw)
To: intel-gfx
Cc: Andrzej Hajda, Matthew Auld, Rodrigo Vivi, chris.p.wilson, Nirmoy Das
Tests on DG2 machines show that releasing forcewakes during BAR resize
results later in forcewake ack timeouts. Since forcewakes can be realeased
asynchronously the simplest way to prevent it is to get all forcewakes
for duration of BAR resizing.
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
drivers/gpu/drm/i915/gt/intel_region_lmem.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
index 89fdfc67f8d1e0..5a01dc6ca08324 100644
--- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
+++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
@@ -54,6 +54,7 @@ static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t
struct resource *root_res;
resource_size_t rebar_size;
resource_size_t current_size;
+ intel_wakeref_t wakeref;
u32 pci_cmd;
int i;
@@ -102,6 +103,14 @@ static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t
return;
}
+ /*
+ * Releasing forcewake during BAR resizing results in later forcewake
+ * ack timeouts and former can happen any time - it is asynchronous.
+ * Grabbing all forcewakes prevents it.
+ */
+ with_intel_runtime_pm(i915->uncore.rpm, wakeref)
+ intel_uncore_forcewake_get(&i915->uncore, FORCEWAKE_ALL);
+
/* First disable PCI memory decoding references */
pci_read_config_dword(pdev, PCI_COMMAND, &pci_cmd);
pci_write_config_dword(pdev, PCI_COMMAND,
@@ -111,6 +120,9 @@ static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t
pci_assign_unassigned_bus_resources(pdev->bus);
pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd);
+
+ with_intel_runtime_pm(i915->uncore.rpm, wakeref)
+ intel_uncore_forcewake_put(&i915->uncore, FORCEWAKE_ALL);
}
#else
static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t lmem_size) {}
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH v2] drm/i915/gt: prevent forcewake releases during BAR resize
2023-03-08 13:16 ` Rodrigo Vivi
2023-03-08 13:34 ` Andrzej Hajda
@ 2023-03-08 13:36 ` Andrzej Hajda
2023-03-08 17:29 ` Das, Nirmoy
` (3 more replies)
1 sibling, 4 replies; 14+ messages in thread
From: Andrzej Hajda @ 2023-03-08 13:36 UTC (permalink / raw)
To: intel-gfx
Cc: Andrzej Hajda, Matthew Auld, Rodrigo Vivi, chris.p.wilson, Nirmoy Das
Tests on DG2 machines show that releasing forcewakes during BAR resize
results later in forcewake ack timeouts. Since forcewakes can be realeased
asynchronously the simplest way to prevent it is to get all forcewakes
for duration of BAR resizing.
v2: hold rpm as well during resizing (Rodrigo)
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
Please ignore resend of v1, my mistake.
Regards
Andrzej
---
drivers/gpu/drm/i915/gt/intel_region_lmem.c | 25 +++++++++++++++------
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
index 89fdfc67f8d1e0..2a3217e2890fc7 100644
--- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
+++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
@@ -54,6 +54,7 @@ static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t
struct resource *root_res;
resource_size_t rebar_size;
resource_size_t current_size;
+ intel_wakeref_t wakeref;
u32 pci_cmd;
int i;
@@ -102,15 +103,25 @@ static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t
return;
}
- /* First disable PCI memory decoding references */
- pci_read_config_dword(pdev, PCI_COMMAND, &pci_cmd);
- pci_write_config_dword(pdev, PCI_COMMAND,
- pci_cmd & ~PCI_COMMAND_MEMORY);
+ /*
+ * Releasing forcewake during BAR resizing results in later forcewake
+ * ack timeouts and former can happen any time - it is asynchronous.
+ * Grabbing all forcewakes prevents it.
+ */
+ with_intel_runtime_pm(i915->uncore.rpm, wakeref) {
+ intel_uncore_forcewake_get(&i915->uncore, FORCEWAKE_ALL);
- _resize_bar(i915, GEN12_LMEM_BAR, rebar_size);
+ /* First disable PCI memory decoding references */
+ pci_read_config_dword(pdev, PCI_COMMAND, &pci_cmd);
+ pci_write_config_dword(pdev, PCI_COMMAND,
+ pci_cmd & ~PCI_COMMAND_MEMORY);
- pci_assign_unassigned_bus_resources(pdev->bus);
- pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd);
+ _resize_bar(i915, GEN12_LMEM_BAR, rebar_size);
+
+ pci_assign_unassigned_bus_resources(pdev->bus);
+ pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd);
+ intel_uncore_forcewake_put(&i915->uncore, FORCEWAKE_ALL);
+ }
}
#else
static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t lmem_size) {}
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: prevent forcewake releases during BAR resize (rev3)
2023-03-08 11:23 [Intel-gfx] [PATCH] drm/i915/gt: prevent forcewake releases during BAR resize Andrzej Hajda
2023-03-08 13:16 ` Rodrigo Vivi
@ 2023-03-08 15:44 ` Patchwork
2023-03-08 16:08 ` Andrzej Hajda
2023-03-09 20:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: prevent forcewake releases during BAR resize (rev5) Patchwork
2023-03-11 19:06 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 1 reply; 14+ messages in thread
From: Patchwork @ 2023-03-08 15:44 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 9114 bytes --]
== Series Details ==
Series: drm/i915/gt: prevent forcewake releases during BAR resize (rev3)
URL : https://patchwork.freedesktop.org/series/114836/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12827 -> Patchwork_114836v3
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_114836v3 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_114836v3, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/index.html
Participating hosts (35 -> 34)
------------------------------
Additional (1): bat-dg1-6
Missing (2): bat-kbl-2 fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_114836v3:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@execlists:
- fi-glk-j4005: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12827/fi-glk-j4005/igt@i915_selftest@live@execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/fi-glk-j4005/igt@i915_selftest@live@execlists.html
Known issues
------------
Here are the changes found in Patchwork_114836v3 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap@basic:
- bat-dg1-6: NOTRUN -> [SKIP][3] ([i915#4083])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@gem_mmap@basic.html
* igt@gem_render_tiled_blits@basic:
- bat-dg1-6: NOTRUN -> [SKIP][4] ([i915#4079]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@gem_render_tiled_blits@basic.html
* igt@gem_tiled_fence_blits@basic:
- bat-dg1-6: NOTRUN -> [SKIP][5] ([i915#4077]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@gem_tiled_fence_blits@basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-dg1-6: NOTRUN -> [SKIP][6] ([i915#7561])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rps@basic-api:
- bat-dg1-6: NOTRUN -> [SKIP][7] ([i915#6621])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@slpc:
- bat-rpls-1: NOTRUN -> [DMESG-FAIL][8] ([i915#6367])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-6: NOTRUN -> [SKIP][9] ([i915#4215])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_addfb_basic@tile-pitch-mismatch:
- bat-dg1-6: NOTRUN -> [SKIP][10] ([i915#4212]) +7 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@kms_addfb_basic@tile-pitch-mismatch.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-dg1-6: NOTRUN -> [SKIP][11] ([i915#7828]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
- bat-rpls-1: NOTRUN -> [SKIP][12] ([i915#7828])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-rpls-1/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- bat-dg1-6: NOTRUN -> [SKIP][13] ([i915#4103] / [i915#4213]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-dg1-6: NOTRUN -> [SKIP][14] ([fdo#109285])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-rpls-1: NOTRUN -> [SKIP][15] ([i915#1845])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-rpls-1/igt@kms_pipe_crc_basic@suspend-read-crc.html
* igt@kms_psr@sprite_plane_onoff:
- bat-dg1-6: NOTRUN -> [SKIP][16] ([i915#1072] / [i915#4078]) +3 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-dg1-6: NOTRUN -> [SKIP][17] ([i915#3555])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-gtt:
- bat-dg1-6: NOTRUN -> [SKIP][18] ([i915#3708] / [i915#4077]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@prime_vgem@basic-gtt.html
* igt@prime_vgem@basic-read:
- bat-dg1-6: NOTRUN -> [SKIP][19] ([i915#3708]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-userptr:
- bat-dg1-6: NOTRUN -> [SKIP][20] ([i915#3708] / [i915#4873])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@prime_vgem@basic-userptr.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- fi-skl-guc: [DMESG-WARN][21] ([i915#8073]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12827/fi-skl-guc/igt@i915_selftest@live@hangcheck.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/fi-skl-guc/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- bat-rpls-1: [ABORT][23] ([i915#4983] / [i915#7694] / [i915#7911] / [i915#7981]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12827/bat-rpls-1/igt@i915_selftest@live@requests.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-rpls-1/igt@i915_selftest@live@requests.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-2:
- bat-dg1-5: [FAIL][25] ([fdo#103375]) -> [PASS][26] +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12827/bat-dg1-5/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-2.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-5/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-2.html
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7694]: https://gitlab.freedesktop.org/drm/intel/issues/7694
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
[i915#8073]: https://gitlab.freedesktop.org/drm/intel/issues/8073
Build changes
-------------
* Linux: CI_DRM_12827 -> Patchwork_114836v3
CI-20190529: 20190529
CI_DRM_12827: b794b8d84dc0470ee58467386f41870e81a86580 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7183: 3434cef8be4e487644a740039ad15123cd094526 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_114836v3: b794b8d84dc0470ee58467386f41870e81a86580 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
6eed413c855f drm/i915/gt: prevent forcewake releases during BAR resize
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/index.html
[-- Attachment #2: Type: text/html, Size: 10542 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: prevent forcewake releases during BAR resize (rev3)
2023-03-08 15:44 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: prevent forcewake releases during BAR resize (rev3) Patchwork
@ 2023-03-08 16:08 ` Andrzej Hajda
0 siblings, 0 replies; 14+ messages in thread
From: Andrzej Hajda @ 2023-03-08 16:08 UTC (permalink / raw)
To: intel-gfx, Patchwork
On 08.03.2023 16:44, Patchwork wrote:
> *Patch Details*
> *Series:* drm/i915/gt: prevent forcewake releases during BAR resize (rev3)
> *URL:* https://patchwork.freedesktop.org/series/114836/
> <https://patchwork.freedesktop.org/series/114836/>
> *State:* failure
> *Details:*
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/index.html
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/index.html>
>
>
> CI Bug Log - changes from CI_DRM_12827 -> Patchwork_114836v3
>
>
> Summary
>
> *FAILURE*
>
> Serious unknown changes coming with Patchwork_114836v3 absolutely need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_114836v3, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
>
> External URL:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/index.html
>
>
> Participating hosts (35 -> 34)
>
> Additional (1): bat-dg1-6
> Missing (2): bat-kbl-2 fi-snb-2520m
>
>
> Possible new issues
>
> Here are the unknown changes that may have been introduced in
> Patchwork_114836v3:
>
>
> IGT changes
>
>
> Possible regressions
>
> * igt@i915_selftest@live@execlists:
> o fi-glk-j4005: PASS
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12827/fi-glk-j4005/igt@i915_selftest@live@execlists.html> -> ABORT <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/fi-glk-j4005/igt@i915_selftest@live@execlists.html>
>
Unrelated, and already observed [1].
[1]:
http://gfx-ci.igk.intel.com/tree/drm-tip/IGT_7184/fi-bsw-nick/igt@i915_selftest@live@execlists.html
Regards
Andrzej
>
> Known issues
>
> Here are the changes found in Patchwork_114836v3 that come from known
> issues:
>
>
> IGT changes
>
>
> Issues hit
>
> *
>
> igt@gem_mmap@basic:
>
> o bat-dg1-6: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@gem_mmap@basic.html> (i915#4083 <https://gitlab.freedesktop.org/drm/intel/issues/4083>)
> *
>
> igt@gem_render_tiled_blits@basic:
>
> o bat-dg1-6: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@gem_render_tiled_blits@basic.html> (i915#4079 <https://gitlab.freedesktop.org/drm/intel/issues/4079>) +1 similar issue
> *
>
> igt@gem_tiled_fence_blits@basic:
>
> o bat-dg1-6: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@gem_tiled_fence_blits@basic.html> (i915#4077 <https://gitlab.freedesktop.org/drm/intel/issues/4077>) +2 similar issues
> *
>
> igt@i915_pm_backlight@basic-brightness:
>
> o bat-dg1-6: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@i915_pm_backlight@basic-brightness.html> (i915#7561 <https://gitlab.freedesktop.org/drm/intel/issues/7561>)
> *
>
> igt@i915_pm_rps@basic-api:
>
> o bat-dg1-6: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@i915_pm_rps@basic-api.html> (i915#6621 <https://gitlab.freedesktop.org/drm/intel/issues/6621>)
> *
>
> igt@i915_selftest@live@slpc:
>
> o bat-rpls-1: NOTRUN -> DMESG-FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-rpls-1/igt@i915_selftest@live@slpc.html> (i915#6367 <https://gitlab.freedesktop.org/drm/intel/issues/6367>)
> *
>
> igt@kms_addfb_basic@basic-y-tiled-legacy:
>
> o bat-dg1-6: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@kms_addfb_basic@basic-y-tiled-legacy.html> (i915#4215 <https://gitlab.freedesktop.org/drm/intel/issues/4215>)
> *
>
> igt@kms_addfb_basic@tile-pitch-mismatch:
>
> o bat-dg1-6: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@kms_addfb_basic@tile-pitch-mismatch.html> (i915#4212 <https://gitlab.freedesktop.org/drm/intel/issues/4212>) +7 similar issues
> *
>
> igt@kms_chamelium_hpd@common-hpd-after-suspend:
>
> o
>
> bat-dg1-6: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@kms_chamelium_hpd@common-hpd-after-suspend.html> (i915#7828 <https://gitlab.freedesktop.org/drm/intel/issues/7828>) +8 similar issues
>
> o
>
> bat-rpls-1: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-rpls-1/igt@kms_chamelium_hpd@common-hpd-after-suspend.html> (i915#7828 <https://gitlab.freedesktop.org/drm/intel/issues/7828>)
>
> *
>
> igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
>
> o bat-dg1-6: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html> (i915#4103 <https://gitlab.freedesktop.org/drm/intel/issues/4103> / i915#4213 <https://gitlab.freedesktop.org/drm/intel/issues/4213>) +1 similar issue
> *
>
> igt@kms_force_connector_basic@force-load-detect:
>
> o bat-dg1-6: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@kms_force_connector_basic@force-load-detect.html> (fdo#109285 <https://bugs.freedesktop.org/show_bug.cgi?id=109285>)
> *
>
> igt@kms_pipe_crc_basic@suspend-read-crc:
>
> o bat-rpls-1: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-rpls-1/igt@kms_pipe_crc_basic@suspend-read-crc.html> (i915#1845 <https://gitlab.freedesktop.org/drm/intel/issues/1845>)
> *
>
> igt@kms_psr@sprite_plane_onoff:
>
> o bat-dg1-6: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@kms_psr@sprite_plane_onoff.html> (i915#1072 <https://gitlab.freedesktop.org/drm/intel/issues/1072> / i915#4078 <https://gitlab.freedesktop.org/drm/intel/issues/4078>) +3 similar issues
> *
>
> igt@kms_setmode@basic-clone-single-crtc:
>
> o bat-dg1-6: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@kms_setmode@basic-clone-single-crtc.html> (i915#3555 <https://gitlab.freedesktop.org/drm/intel/issues/3555>)
> *
>
> igt@prime_vgem@basic-gtt:
>
> o bat-dg1-6: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@prime_vgem@basic-gtt.html> (i915#3708 <https://gitlab.freedesktop.org/drm/intel/issues/3708> / i915#4077 <https://gitlab.freedesktop.org/drm/intel/issues/4077>) +1 similar issue
> *
>
> igt@prime_vgem@basic-read:
>
> o bat-dg1-6: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@prime_vgem@basic-read.html> (i915#3708 <https://gitlab.freedesktop.org/drm/intel/issues/3708>) +3 similar issues
> *
>
> igt@prime_vgem@basic-userptr:
>
> o bat-dg1-6: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-6/igt@prime_vgem@basic-userptr.html> (i915#3708 <https://gitlab.freedesktop.org/drm/intel/issues/3708> / i915#4873 <https://gitlab.freedesktop.org/drm/intel/issues/4873>)
>
>
> Possible fixes
>
> *
>
> igt@i915_selftest@live@hangcheck:
>
> o fi-skl-guc: DMESG-WARN
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12827/fi-skl-guc/igt@i915_selftest@live@hangcheck.html> (i915#8073 <https://gitlab.freedesktop.org/drm/intel/issues/8073>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/fi-skl-guc/igt@i915_selftest@live@hangcheck.html>
> *
>
> igt@i915_selftest@live@requests:
>
> o bat-rpls-1: ABORT
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12827/bat-rpls-1/igt@i915_selftest@live@requests.html> (i915#4983 <https://gitlab.freedesktop.org/drm/intel/issues/4983> / i915#7694 <https://gitlab.freedesktop.org/drm/intel/issues/7694> / i915#7911 <https://gitlab.freedesktop.org/drm/intel/issues/7911> / i915#7981 <https://gitlab.freedesktop.org/drm/intel/issues/7981>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-rpls-1/igt@i915_selftest@live@requests.html>
> *
>
> igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-2:
>
> o bat-dg1-5: FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12827/bat-dg1-5/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-2.html> (fdo#103375 <https://bugs.freedesktop.org/show_bug.cgi?id=103375>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v3/bat-dg1-5/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-2.html> +3 similar issues
>
>
> Build changes
>
> * Linux: CI_DRM_12827 -> Patchwork_114836v3
>
> CI-20190529: 20190529
> CI_DRM_12827: b794b8d84dc0470ee58467386f41870e81a86580 @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7183: 3434cef8be4e487644a740039ad15123cd094526 @
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_114836v3: b794b8d84dc0470ee58467386f41870e81a86580 @
> git://anongit.freedesktop.org/gfx-ci/linux
>
>
> Linux commits
>
> 6eed413c855f drm/i915/gt: prevent forcewake releases during BAR resize
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/gt: prevent forcewake releases during BAR resize
2023-03-08 13:36 ` [Intel-gfx] [PATCH v2] " Andrzej Hajda
@ 2023-03-08 17:29 ` Das, Nirmoy
2023-03-09 7:54 ` Andrzej Hajda
2023-03-08 17:31 ` Rodrigo Vivi
` (2 subsequent siblings)
3 siblings, 1 reply; 14+ messages in thread
From: Das, Nirmoy @ 2023-03-08 17:29 UTC (permalink / raw)
To: Andrzej Hajda, intel-gfx
Cc: Nirmoy Das, chris.p.wilson, Matthew Auld, Rodrigo Vivi
On 3/8/2023 2:36 PM, Andrzej Hajda wrote:
> Tests on DG2 machines show that releasing forcewakes during BAR resize
> results later in forcewake ack timeouts.
Do we have a fdo/issues url for that? Having that as References would be
nice.
> Since forcewakes can be realeased
> asynchronously the simplest way to prevent it is to get all forcewakes
> for duration of BAR resizing.
>
> v2: hold rpm as well during resizing (Rodrigo)
>
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
Acked-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> Please ignore resend of v1, my mistake.
>
> Regards
> Andrzej
> ---
> drivers/gpu/drm/i915/gt/intel_region_lmem.c | 25 +++++++++++++++------
> 1 file changed, 18 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> index 89fdfc67f8d1e0..2a3217e2890fc7 100644
> --- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> +++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> @@ -54,6 +54,7 @@ static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t
> struct resource *root_res;
> resource_size_t rebar_size;
> resource_size_t current_size;
> + intel_wakeref_t wakeref;
> u32 pci_cmd;
> int i;
>
> @@ -102,15 +103,25 @@ static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t
> return;
> }
>
> - /* First disable PCI memory decoding references */
> - pci_read_config_dword(pdev, PCI_COMMAND, &pci_cmd);
> - pci_write_config_dword(pdev, PCI_COMMAND,
> - pci_cmd & ~PCI_COMMAND_MEMORY);
> + /*
> + * Releasing forcewake during BAR resizing results in later forcewake
> + * ack timeouts and former can happen any time - it is asynchronous.
> + * Grabbing all forcewakes prevents it.
> + */
> + with_intel_runtime_pm(i915->uncore.rpm, wakeref) {
> + intel_uncore_forcewake_get(&i915->uncore, FORCEWAKE_ALL);
>
> - _resize_bar(i915, GEN12_LMEM_BAR, rebar_size);
> + /* First disable PCI memory decoding references */
> + pci_read_config_dword(pdev, PCI_COMMAND, &pci_cmd);
> + pci_write_config_dword(pdev, PCI_COMMAND,
> + pci_cmd & ~PCI_COMMAND_MEMORY);
>
> - pci_assign_unassigned_bus_resources(pdev->bus);
> - pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd);
> + _resize_bar(i915, GEN12_LMEM_BAR, rebar_size);
> +
> + pci_assign_unassigned_bus_resources(pdev->bus);
> + pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd);
> + intel_uncore_forcewake_put(&i915->uncore, FORCEWAKE_ALL);
> + }
> }
> #else
> static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t lmem_size) {}
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/gt: prevent forcewake releases during BAR resize
2023-03-08 13:36 ` [Intel-gfx] [PATCH v2] " Andrzej Hajda
2023-03-08 17:29 ` Das, Nirmoy
@ 2023-03-08 17:31 ` Rodrigo Vivi
2023-03-09 0:11 ` Andi Shyti
2023-03-16 18:20 ` Andrzej Hajda
3 siblings, 0 replies; 14+ messages in thread
From: Rodrigo Vivi @ 2023-03-08 17:31 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx, Matthew Auld, chris.p.wilson, Nirmoy Das
On Wed, Mar 08, 2023 at 02:36:24PM +0100, Andrzej Hajda wrote:
> Tests on DG2 machines show that releasing forcewakes during BAR resize
> results later in forcewake ack timeouts. Since forcewakes can be realeased
> asynchronously the simplest way to prevent it is to get all forcewakes
> for duration of BAR resizing.
>
> v2: hold rpm as well during resizing (Rodrigo)
oh, I really dislike this with_rpm... a get and put directly would
end up with a much clear patch... :/
but anyway:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> ---
> Please ignore resend of v1, my mistake.
>
> Regards
> Andrzej
> ---
> drivers/gpu/drm/i915/gt/intel_region_lmem.c | 25 +++++++++++++++------
> 1 file changed, 18 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> index 89fdfc67f8d1e0..2a3217e2890fc7 100644
> --- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> +++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> @@ -54,6 +54,7 @@ static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t
> struct resource *root_res;
> resource_size_t rebar_size;
> resource_size_t current_size;
> + intel_wakeref_t wakeref;
> u32 pci_cmd;
> int i;
>
> @@ -102,15 +103,25 @@ static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t
> return;
> }
>
> - /* First disable PCI memory decoding references */
> - pci_read_config_dword(pdev, PCI_COMMAND, &pci_cmd);
> - pci_write_config_dword(pdev, PCI_COMMAND,
> - pci_cmd & ~PCI_COMMAND_MEMORY);
> + /*
> + * Releasing forcewake during BAR resizing results in later forcewake
> + * ack timeouts and former can happen any time - it is asynchronous.
> + * Grabbing all forcewakes prevents it.
> + */
> + with_intel_runtime_pm(i915->uncore.rpm, wakeref) {
> + intel_uncore_forcewake_get(&i915->uncore, FORCEWAKE_ALL);
>
> - _resize_bar(i915, GEN12_LMEM_BAR, rebar_size);
> + /* First disable PCI memory decoding references */
> + pci_read_config_dword(pdev, PCI_COMMAND, &pci_cmd);
> + pci_write_config_dword(pdev, PCI_COMMAND,
> + pci_cmd & ~PCI_COMMAND_MEMORY);
>
> - pci_assign_unassigned_bus_resources(pdev->bus);
> - pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd);
> + _resize_bar(i915, GEN12_LMEM_BAR, rebar_size);
> +
> + pci_assign_unassigned_bus_resources(pdev->bus);
> + pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd);
> + intel_uncore_forcewake_put(&i915->uncore, FORCEWAKE_ALL);
> + }
> }
> #else
> static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t lmem_size) {}
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/gt: prevent forcewake releases during BAR resize
2023-03-08 13:36 ` [Intel-gfx] [PATCH v2] " Andrzej Hajda
2023-03-08 17:29 ` Das, Nirmoy
2023-03-08 17:31 ` Rodrigo Vivi
@ 2023-03-09 0:11 ` Andi Shyti
2023-03-16 18:20 ` Andrzej Hajda
3 siblings, 0 replies; 14+ messages in thread
From: Andi Shyti @ 2023-03-09 0:11 UTC (permalink / raw)
To: Andrzej Hajda
Cc: intel-gfx, Matthew Auld, Rodrigo Vivi, chris.p.wilson, Nirmoy Das
Hi Andrzej,
On Wed, Mar 08, 2023 at 02:36:24PM +0100, Andrzej Hajda wrote:
> Tests on DG2 machines show that releasing forcewakes during BAR resize
> results later in forcewake ack timeouts. Since forcewakes can be realeased
> asynchronously the simplest way to prevent it is to get all forcewakes
> for duration of BAR resizing.
>
> v2: hold rpm as well during resizing (Rodrigo)
>
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks,
Andi
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/gt: prevent forcewake releases during BAR resize
2023-03-08 17:29 ` Das, Nirmoy
@ 2023-03-09 7:54 ` Andrzej Hajda
2023-03-09 8:31 ` Das, Nirmoy
0 siblings, 1 reply; 14+ messages in thread
From: Andrzej Hajda @ 2023-03-09 7:54 UTC (permalink / raw)
To: Das, Nirmoy, intel-gfx
Cc: Rodrigo Vivi, chris.p.wilson, Matthew Auld, Nirmoy Das
On 08.03.2023 18:29, Das, Nirmoy wrote:
>
> On 3/8/2023 2:36 PM, Andrzej Hajda wrote:
>> Tests on DG2 machines show that releasing forcewakes during BAR resize
>> results later in forcewake ack timeouts.
> Do we have a fdo/issues url for that? Having that as References would be
> nice.
The patch is result of issue reported internally, but...grepping
bugtracker I've found potential candidates:
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6530
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/7853
Maybe it would be good to add them on merge.
Anyway thx for a-b.
Regards
Andrzej
>> Since forcewakes can be realeased
>> asynchronously the simplest way to prevent it is to get all forcewakes
>> for duration of BAR resizing.
>>
>> v2: hold rpm as well during resizing (Rodrigo)
>>
>> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
>
>
> Acked-by: Nirmoy Das <nirmoy.das@intel.com>
>
>
>> ---
>> Please ignore resend of v1, my mistake.
>>
>> Regards
>> Andrzej
>> ---
>> drivers/gpu/drm/i915/gt/intel_region_lmem.c | 25 +++++++++++++++------
>> 1 file changed, 18 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
>> b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
>> index 89fdfc67f8d1e0..2a3217e2890fc7 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
>> @@ -54,6 +54,7 @@ static void i915_resize_lmem_bar(struct
>> drm_i915_private *i915, resource_size_t
>> struct resource *root_res;
>> resource_size_t rebar_size;
>> resource_size_t current_size;
>> + intel_wakeref_t wakeref;
>> u32 pci_cmd;
>> int i;
>> @@ -102,15 +103,25 @@ static void i915_resize_lmem_bar(struct
>> drm_i915_private *i915, resource_size_t
>> return;
>> }
>> - /* First disable PCI memory decoding references */
>> - pci_read_config_dword(pdev, PCI_COMMAND, &pci_cmd);
>> - pci_write_config_dword(pdev, PCI_COMMAND,
>> - pci_cmd & ~PCI_COMMAND_MEMORY);
>> + /*
>> + * Releasing forcewake during BAR resizing results in later
>> forcewake
>> + * ack timeouts and former can happen any time - it is asynchronous.
>> + * Grabbing all forcewakes prevents it.
>> + */
>> + with_intel_runtime_pm(i915->uncore.rpm, wakeref) {
>> + intel_uncore_forcewake_get(&i915->uncore, FORCEWAKE_ALL);
>> - _resize_bar(i915, GEN12_LMEM_BAR, rebar_size);
>> + /* First disable PCI memory decoding references */
>> + pci_read_config_dword(pdev, PCI_COMMAND, &pci_cmd);
>> + pci_write_config_dword(pdev, PCI_COMMAND,
>> + pci_cmd & ~PCI_COMMAND_MEMORY);
>> - pci_assign_unassigned_bus_resources(pdev->bus);
>> - pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd);
>> + _resize_bar(i915, GEN12_LMEM_BAR, rebar_size);
>> +
>> + pci_assign_unassigned_bus_resources(pdev->bus);
>> + pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd);
>> + intel_uncore_forcewake_put(&i915->uncore, FORCEWAKE_ALL);
>> + }
>> }
>> #else
>> static void i915_resize_lmem_bar(struct drm_i915_private *i915,
>> resource_size_t lmem_size) {}
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/gt: prevent forcewake releases during BAR resize
2023-03-09 7:54 ` Andrzej Hajda
@ 2023-03-09 8:31 ` Das, Nirmoy
0 siblings, 0 replies; 14+ messages in thread
From: Das, Nirmoy @ 2023-03-09 8:31 UTC (permalink / raw)
To: Andrzej Hajda, Das, Nirmoy, intel-gfx
Cc: chris.p.wilson, Matthew Auld, Rodrigo Vivi
On 3/9/2023 8:54 AM, Andrzej Hajda wrote:
> On 08.03.2023 18:29, Das, Nirmoy wrote:
>>
>> On 3/8/2023 2:36 PM, Andrzej Hajda wrote:
>>> Tests on DG2 machines show that releasing forcewakes during BAR resize
>>> results later in forcewake ack timeouts.
>> Do we have a fdo/issues url for that? Having that as References would
>> be nice.
>
> The patch is result of issue reported internally, but...grepping
> bugtracker I've found potential candidates:
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6530
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/7853
>
> Maybe it would be good to add them on merge.
Works for me.
Thanks,
Nirmoy
> Anyway thx for a-b.
>
> Regards
> Andrzej
>
>>> Since forcewakes can be realeased
>>> asynchronously the simplest way to prevent it is to get all forcewakes
>>> for duration of BAR resizing.
>>>
>>> v2: hold rpm as well during resizing (Rodrigo)
>>>
>>> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
>>
>>
>> Acked-by: Nirmoy Das <nirmoy.das@intel.com>
>>
>>
>>> ---
>>> Please ignore resend of v1, my mistake.
>>>
>>> Regards
>>> Andrzej
>>> ---
>>> drivers/gpu/drm/i915/gt/intel_region_lmem.c | 25
>>> +++++++++++++++------
>>> 1 file changed, 18 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
>>> b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
>>> index 89fdfc67f8d1e0..2a3217e2890fc7 100644
>>> --- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
>>> +++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
>>> @@ -54,6 +54,7 @@ static void i915_resize_lmem_bar(struct
>>> drm_i915_private *i915, resource_size_t
>>> struct resource *root_res;
>>> resource_size_t rebar_size;
>>> resource_size_t current_size;
>>> + intel_wakeref_t wakeref;
>>> u32 pci_cmd;
>>> int i;
>>> @@ -102,15 +103,25 @@ static void i915_resize_lmem_bar(struct
>>> drm_i915_private *i915, resource_size_t
>>> return;
>>> }
>>> - /* First disable PCI memory decoding references */
>>> - pci_read_config_dword(pdev, PCI_COMMAND, &pci_cmd);
>>> - pci_write_config_dword(pdev, PCI_COMMAND,
>>> - pci_cmd & ~PCI_COMMAND_MEMORY);
>>> + /*
>>> + * Releasing forcewake during BAR resizing results in later
>>> forcewake
>>> + * ack timeouts and former can happen any time - it is
>>> asynchronous.
>>> + * Grabbing all forcewakes prevents it.
>>> + */
>>> + with_intel_runtime_pm(i915->uncore.rpm, wakeref) {
>>> + intel_uncore_forcewake_get(&i915->uncore, FORCEWAKE_ALL);
>>> - _resize_bar(i915, GEN12_LMEM_BAR, rebar_size);
>>> + /* First disable PCI memory decoding references */
>>> + pci_read_config_dword(pdev, PCI_COMMAND, &pci_cmd);
>>> + pci_write_config_dword(pdev, PCI_COMMAND,
>>> + pci_cmd & ~PCI_COMMAND_MEMORY);
>>> - pci_assign_unassigned_bus_resources(pdev->bus);
>>> - pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd);
>>> + _resize_bar(i915, GEN12_LMEM_BAR, rebar_size);
>>> +
>>> + pci_assign_unassigned_bus_resources(pdev->bus);
>>> + pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd);
>>> + intel_uncore_forcewake_put(&i915->uncore, FORCEWAKE_ALL);
>>> + }
>>> }
>>> #else
>>> static void i915_resize_lmem_bar(struct drm_i915_private *i915,
>>> resource_size_t lmem_size) {}
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: prevent forcewake releases during BAR resize (rev5)
2023-03-08 11:23 [Intel-gfx] [PATCH] drm/i915/gt: prevent forcewake releases during BAR resize Andrzej Hajda
2023-03-08 13:16 ` Rodrigo Vivi
2023-03-08 15:44 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: prevent forcewake releases during BAR resize (rev3) Patchwork
@ 2023-03-09 20:15 ` Patchwork
2023-03-11 19:06 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2023-03-09 20:15 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4109 bytes --]
== Series Details ==
Series: drm/i915/gt: prevent forcewake releases during BAR resize (rev5)
URL : https://patchwork.freedesktop.org/series/114836/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12832 -> Patchwork_114836v5
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/index.html
Participating hosts (36 -> 35)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_114836v5 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@migrate:
- bat-dg2-11: [PASS][1] -> [DMESG-WARN][2] ([i915#7699])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/bat-dg2-11/igt@i915_selftest@live@migrate.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/bat-dg2-11/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@requests:
- bat-rpls-1: [PASS][3] -> [ABORT][4] ([i915#4983] / [i915#7694] / [i915#7911] / [i915#7981])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/bat-rpls-1/igt@i915_selftest@live@requests.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/bat-rpls-1/igt@i915_selftest@live@requests.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-2:
- bat-dg1-5: [PASS][5] -> [FAIL][6] ([fdo#103375]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/bat-dg1-5/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-2.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/bat-dg1-5/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-2.html
#### Possible fixes ####
* igt@i915_selftest@live@dmabuf:
- bat-rplp-1: [DMESG-WARN][7] ([i915#2867]) -> [PASS][8] +29 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/bat-rplp-1/igt@i915_selftest@live@dmabuf.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/bat-rplp-1/igt@i915_selftest@live@dmabuf.html
#### Warnings ####
* igt@i915_selftest@live@slpc:
- bat-rpls-2: [DMESG-FAIL][9] ([i915#6997] / [i915#7913]) -> [DMESG-FAIL][10] ([i915#6367] / [i915#7913] / [i915#7996])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/bat-rpls-2/igt@i915_selftest@live@slpc.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/bat-rpls-2/igt@i915_selftest@live@slpc.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7694]: https://gitlab.freedesktop.org/drm/intel/issues/7694
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
[i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996
Build changes
-------------
* Linux: CI_DRM_12832 -> Patchwork_114836v5
CI-20190529: 20190529
CI_DRM_12832: 40eaf607cfcc6f514cd3ea652525704137bcea15 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7188: b35bfa32fe672d67ced8555557e3e707ace211ad @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_114836v5: 40eaf607cfcc6f514cd3ea652525704137bcea15 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
bc42d855a8b7 drm/i915/gt: prevent forcewake releases during BAR resize
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/index.html
[-- Attachment #2: Type: text/html, Size: 4877 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: prevent forcewake releases during BAR resize (rev5)
2023-03-08 11:23 [Intel-gfx] [PATCH] drm/i915/gt: prevent forcewake releases during BAR resize Andrzej Hajda
` (2 preceding siblings ...)
2023-03-09 20:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: prevent forcewake releases during BAR resize (rev5) Patchwork
@ 2023-03-11 19:06 ` Patchwork
3 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2023-03-11 19:06 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 23284 bytes --]
== Series Details ==
Series: drm/i915/gt: prevent forcewake releases during BAR resize (rev5)
URL : https://patchwork.freedesktop.org/series/114836/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12832_full -> Patchwork_114836v5_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (9 -> 10)
------------------------------
Additional (1): shard-rkl0
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_114836v5_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@xe/xe_guc_pc@rc6_on_idle}:
- {shard-dg1}: NOTRUN -> [SKIP][1] +125 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-dg1-16/igt@xe/xe_guc_pc@rc6_on_idle.html
Known issues
------------
Here are the changes found in Patchwork_114836v5_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: [PASS][2] -> [FAIL][3] ([i915#2842]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-glk4/igt@gem_exec_fair@basic-none@rcs0.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-glk1/igt@gem_exec_fair@basic-none@rcs0.html
* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-apl: NOTRUN -> [SKIP][4] ([fdo#109271]) +22 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-apl4/igt@gem_render_copy@x-tiled-to-vebox-yf-tiled.html
* igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#3886]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-apl4/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][6] -> [FAIL][7] ([i915#79])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][8] -> [FAIL][9] ([i915#2122])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-suspend@b-dp1:
- shard-apl: [PASS][10] -> [ABORT][11] ([i915#180])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-apl6/igt@kms_flip@flip-vs-suspend@b-dp1.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-apl1/igt@kms_flip@flip-vs-suspend@b-dp1.html
#### Possible fixes ####
* igt@device_reset@unbind-reset-rebind:
- {shard-rkl}: [FAIL][12] ([i915#4778]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-rkl-5/igt@device_reset@unbind-reset-rebind.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-rkl-1/igt@device_reset@unbind-reset-rebind.html
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][14] ([i915#6268]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-rkl-2/igt@gem_ctx_exec@basic-nohangcheck.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-rkl-3/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_ctx_isolation@preservation-s3@rcs0:
- shard-apl: [ABORT][16] ([i915#180]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-apl3/igt@gem_ctx_isolation@preservation-s3@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-apl4/igt@gem_ctx_isolation@preservation-s3@rcs0.html
* igt@gem_ctx_persistence@legacy-engines-hang@blt:
- {shard-rkl}: [SKIP][18] ([i915#6252]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-rkl-5/igt@gem_ctx_persistence@legacy-engines-hang@blt.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-rkl-1/igt@gem_ctx_persistence@legacy-engines-hang@blt.html
* igt@gem_ctx_persistence@saturated-hostile-nopreempt@rcs0:
- {shard-tglu}: [FAIL][20] -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-tglu-1/igt@gem_ctx_persistence@saturated-hostile-nopreempt@rcs0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-tglu-8/igt@gem_ctx_persistence@saturated-hostile-nopreempt@rcs0.html
* igt@gem_exec_capture@pi@rcs0:
- {shard-rkl}: [ABORT][22] ([i915#3371]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-rkl-1/igt@gem_exec_capture@pi@rcs0.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-rkl-5/igt@gem_exec_capture@pi@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-tglu}: [FAIL][24] ([i915#2842]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-tglu-2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-tglu-2/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [FAIL][26] ([i915#2842]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-glk1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-glk7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- {shard-rkl}: [FAIL][28] ([i915#2842]) -> [PASS][29] +2 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-rkl-1/igt@gem_exec_fair@basic-pace@rcs0.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-rkl-5/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_reloc@basic-gtt-read:
- {shard-rkl}: [SKIP][30] ([i915#3281]) -> [PASS][31] +5 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-rkl-6/igt@gem_exec_reloc@basic-gtt-read.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-read.html
* igt@gem_readwrite@read-bad-handle:
- {shard-rkl}: [SKIP][32] ([i915#3282]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-rkl-6/igt@gem_readwrite@read-bad-handle.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-rkl-5/igt@gem_readwrite@read-bad-handle.html
* igt@gen9_exec_parse@allowed-single:
- {shard-rkl}: [ABORT][34] ([i915#5566]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-rkl-5/igt@gen9_exec_parse@allowed-single.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-rkl-5/igt@gen9_exec_parse@allowed-single.html
- shard-apl: [ABORT][36] ([i915#5566]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-apl7/igt@gen9_exec_parse@allowed-single.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-apl4/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@bb-start-out:
- {shard-rkl}: [SKIP][38] ([i915#2527]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-rkl-1/igt@gen9_exec_parse@bb-start-out.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-rkl-5/igt@gen9_exec_parse@bb-start-out.html
* igt@i915_pm_rpm@fences:
- {shard-rkl}: [SKIP][40] ([i915#1849]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-rkl-5/igt@i915_pm_rpm@fences.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-rkl-6/igt@i915_pm_rpm@fences.html
* igt@kms_big_fb@x-tiled-8bpp-rotate-180:
- {shard-tglu}: [SKIP][42] ([i915#1845] / [i915#7651]) -> [PASS][43] +21 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-tglu-6/igt@kms_big_fb@x-tiled-8bpp-rotate-180.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-tglu-8/igt@kms_big_fb@x-tiled-8bpp-rotate-180.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:
- {shard-rkl}: [SKIP][44] ([i915#1845] / [i915#4098]) -> [PASS][45] +9 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-rkl-5/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-rkl-6/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
* igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions:
- {shard-tglu}: [SKIP][46] ([i915#1845]) -> [PASS][47] +4 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-tglu-6/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-tglu-1/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions.html
* igt@kms_fence_pin_leak:
- {shard-tglu}: [SKIP][48] ([fdo#109274] / [i915#1845]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-tglu-6/igt@kms_fence_pin_leak.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-tglu-1/igt@kms_fence_pin_leak.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-gtt:
- {shard-tglu}: [SKIP][50] ([i915#1849]) -> [PASS][51] +10 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-gtt.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-tglu-8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-gtt:
- {shard-rkl}: [SKIP][52] ([i915#1849] / [i915#4098]) -> [PASS][53] +4 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-rkl-5/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-gtt.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-gtt.html
* igt@kms_plane@plane-position-hole-dpms@pipe-a-planes:
- {shard-tglu}: [SKIP][54] ([i915#1849] / [i915#3558]) -> [PASS][55] +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-tglu-6/igt@kms_plane@plane-position-hole-dpms@pipe-a-planes.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-tglu-8/igt@kms_plane@plane-position-hole-dpms@pipe-a-planes.html
* igt@kms_universal_plane@universal-plane-pipe-c-sanity:
- {shard-tglu}: [SKIP][56] ([fdo#109274]) -> [PASS][57] +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-tglu-6/igt@kms_universal_plane@universal-plane-pipe-c-sanity.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-tglu-1/igt@kms_universal_plane@universal-plane-pipe-c-sanity.html
* igt@perf@gen12-unprivileged-single-ctx-counters:
- {shard-rkl}: [SKIP][58] ([fdo#109289]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12832/shard-rkl-5/igt@perf@gen12-unprivileged-single-ctx-counters.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/shard-rkl-4/igt@perf@gen12-unprivileged-single-ctx-counters.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2876]: https://gitlab.freedesktop.org/drm/intel/issues/2876
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3371]: https://gitlab.freedesktop.org/drm/intel/issues/3371
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3639]: https://gitlab.freedesktop.org/drm/intel/issues/3639
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4778]: https://gitlab.freedesktop.org/drm/intel/issues/4778
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#5115]: https://gitlab.freedesktop.org/drm/intel/issues/5115
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5431]: https://gitlab.freedesktop.org/drm/intel/issues/5431
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#7276]: https://gitlab.freedesktop.org/drm/intel/issues/7276
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7756]: https://gitlab.freedesktop.org/drm/intel/issues/7756
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
[i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
[i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
Build changes
-------------
* Linux: CI_DRM_12832 -> Patchwork_114836v5
CI-20190529: 20190529
CI_DRM_12832: 40eaf607cfcc6f514cd3ea652525704137bcea15 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7188: b35bfa32fe672d67ced8555557e3e707ace211ad @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_114836v5: 40eaf607cfcc6f514cd3ea652525704137bcea15 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114836v5/index.html
[-- Attachment #2: Type: text/html, Size: 16694 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/gt: prevent forcewake releases during BAR resize
2023-03-08 13:36 ` [Intel-gfx] [PATCH v2] " Andrzej Hajda
` (2 preceding siblings ...)
2023-03-09 0:11 ` Andi Shyti
@ 2023-03-16 18:20 ` Andrzej Hajda
3 siblings, 0 replies; 14+ messages in thread
From: Andrzej Hajda @ 2023-03-16 18:20 UTC (permalink / raw)
To: intel-gfx; +Cc: Nirmoy Das, chris.p.wilson, Matthew Auld, Rodrigo Vivi
On 08.03.2023 14:36, Andrzej Hajda wrote:
> Tests on DG2 machines show that releasing forcewakes during BAR resize
> results later in forcewake ack timeouts. Since forcewakes can be realeased
> asynchronously the simplest way to prevent it is to get all forcewakes
> for duration of BAR resizing.
>
> v2: hold rpm as well during resizing (Rodrigo)
>
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
Queued to drm-intel-gt-next.
Regards
Andrzej
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2023-03-16 18:20 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-08 11:23 [Intel-gfx] [PATCH] drm/i915/gt: prevent forcewake releases during BAR resize Andrzej Hajda
2023-03-08 13:16 ` Rodrigo Vivi
2023-03-08 13:34 ` Andrzej Hajda
2023-03-08 13:36 ` [Intel-gfx] [PATCH v2] " Andrzej Hajda
2023-03-08 17:29 ` Das, Nirmoy
2023-03-09 7:54 ` Andrzej Hajda
2023-03-09 8:31 ` Das, Nirmoy
2023-03-08 17:31 ` Rodrigo Vivi
2023-03-09 0:11 ` Andi Shyti
2023-03-16 18:20 ` Andrzej Hajda
2023-03-08 15:44 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: prevent forcewake releases during BAR resize (rev3) Patchwork
2023-03-08 16:08 ` Andrzej Hajda
2023-03-09 20:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: prevent forcewake releases during BAR resize (rev5) Patchwork
2023-03-11 19:06 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.